VOGONS


Reply 22 of 44, by ih8registrations

User metadata
Rank Oldbie
Rank
Oldbie

As for bumpy, I ran a cvsbuild and it shows the same thing.
and running a cvs build /w just graphicsopt applied doesn't show that corruption. what other patches do you have applied?

Reply 23 of 44, by ykhwong

User metadata
Rank Oldbie
Rank
Oldbie

I applied your graphicopt patch to a clean cvs.
Then, there was no problem in a screen as for prehistorik2.
However, Bumpy's adventure still has such a problem in a clean cvs with the optimization patch. Especially, game over scene is filled with a blue background.
I tried my latest build and gulikoza's and my clean cvs, but everything was ok.

Reply 25 of 44, by ykhwong

User metadata
Rank Oldbie
Rank
Oldbie

Well.. the blue background appeared in my working build w/ your opt patch. the color is black in a clean cvs with the patch.

Here is a screenshot.

Attachments

  • Filename
    check.JPG
    File size
    130.31 KiB
    Downloads
    109 downloads
    File license
    Fair use/fair dealing exception

Reply 27 of 44, by ykhwong

User metadata
Rank Oldbie
Rank
Oldbie

I am using the latest version of MinGW/MSYS with gcc 3.4.5.

Not a debug mode, no optimization flags... (default settings).
I hit ./configure;make;strip ./src/dosbox.exe

Here is an executable that I compiled.

Reply 31 of 44, by ih8registrations

User metadata
Rank Oldbie
Rank
Oldbie

I narrowed it down to an issue with rasterop, I think having to do with vga.latch.d, but I'm still scratching my head. Attached is graphicsopt4.diff, which skips everything but rasterop. Also added an optimization for the modes wd was interested in and others; old way would calc bank address on every read/write; the optimization pulls that(a multiply) out, now done in vga_gfx.cpp, where it's modified less often(on a bank switch, other twiggling).

Attachments

  • Filename
    graphicsopt4.diff
    File size
    16.34 KiB
    Downloads
    201 downloads
    File license
    Fair use/fair dealing exception

Reply 35 of 44, by kekko

User metadata
Rank Oldbie
Rank
Oldbie

allows time for any bugs to surface

That's true; but the cycle transition slowdown is actually a bug. And I noticed that with that patch the sound works perfectly in any condition.
I don't know if your patch is already bug-free or if is the best way to fix the bug, however i think that something should be done.

Reply 36 of 44, by ih8registrations

User metadata
Rank Oldbie
Rank
Oldbie

That's one thing I'd like to see that's never done, a response on why a patch isn't included. I guess I'll need to email them to ask what the sticking point(s) is/are to find out.

Reply 39 of 44, by Qbix

User metadata
Rank DOSBox Author
Rank
DOSBox Author

the autocycles patch has better change to be accepted if you remove the
tinkering with the titlebar.

Water flows down the stream
How to ask questions the smart way!