Pic.cpp question \ VOGONS

Pic.cpp question

Topic actions

Post a reply

First post, by danoon

Posted on 2011-01-04, 19:20

danoon Offline

Rank Member

Rank: Member
Posts: 217
Joined: 2011-01-04, 19:12

In pic.cpp in the function:

static void write_command(Bitu port,Bitu val,Bitu iolen) {

I'm trying to understand the intent of this code

1if(pic[0].special || pics[1].special) 
2	PIC_Special_Mode = true; else 
3	PIC_Special_Mode = false;

pics is defined as

1static PIC_Controller pics[2];

and pic is defined as

1PIC_Controller * pic=&pics[port==0x20 ? 0 : 1];

Do you think pic[0].special intentionally meant pic->special or is this a typo and it should be pics[0]?

Reply 1 of 3, by Qbix

Posted on 2011-01-04, 20:31

Qbix Offline

Rank DOSBox Author

Rank: DOSBox Author
Posts: 11233
Joined: 2002-11-27, 14:50
Location: Fryslan

there is indeed a "s" missing there.
should be pics[0].special
I changed the code in question. Thanks.

Water flows down the stream
How to ask questions the smart way!

Reply 2 of 3, by wd

Posted on 2011-01-04, 20:45

wd Offline

Rank DOSBox Author

Rank: DOSBox Author
Posts: 10813
Joined: 2003-12-03, 21:23

That should be identical for the most use cases, but it's indeed a typo (know who you can blame 😀 ).

Reply 3 of 3, by Qbix

Posted on 2011-01-04, 20:49

Qbix Offline

Rank DOSBox Author

Rank: DOSBox Author
Posts: 11233
Joined: 2002-11-27, 14:50
Location: Fryslan

Yes, but I wrote that part myself 😀
The results are most likely to be identical though, as I don't know of programs that only put one pic in special mode.

Water flows down the stream
How to ask questions the smart way!

Go to top of page Go to top of page

Back to DOSBox Development

Main menu

Common searches

Pic.cpp question

Topic actions

First post, by danoon

Reply 1 of 3, by Qbix

Reply 2 of 3, by wd

Reply 3 of 3, by Qbix