VOGONS


First post, by rajmurt

User metadata
Rank Newbie
Rank
Newbie

I tried to compile dosbox 0.74 with debug feature using gcc 4.9.2, and I am getting the following error (not exact, from memory):

src/debug/debug.cpp error: LOG(..)(out1) not literal string ...

I had to fix this by getting rid of out1 variable and sprintf() function call and just applying the formatting string and parameters directly in LOG()().

Maybe we shouldn't use temporary out1 character array in forming log messages at all? I don't see any advantage of doing that other than wasting 512 bytes of memory. I'm attaching a patch file for review.

Attachments

  • Filename
    dosbox-debug-LOG.patch
    File size
    5.67 KiB
    Downloads
    121 downloads
    File license
    Fair use/fair dealing exception

Reply 1 of 1, by Dominus

User metadata
Rank DOSBox Moderator
Rank
DOSBox Moderator

You should use SVN of dosbox for such things to make sure that stuff is not already fixed...

Windows 3.1x guide for DOSBox
60 seconds guide to DOSBox