Reply 420 of 757, by VileR
The games in the videos appear to be using mode 8/9 16-color graphics, and although the PCjr does have a composite out, things will look better in general with a RGB monitor hooked up to the RGB out. If you're suggesting some kind of composite output for all modes, that would seem to be beyond the scope of the current patch.
No, only for modes 4-6 - the 16-color modes would indeed be too much for the paletted approach (and I can't think of anything that actually used the 16-color modes for artifact color generation, anyway).
At any rate, games that absolutely need both composite video and machine=pcjr/tandy are rare indeed, so maybe that's best left for later, if at all.
In mode 4 the artifact colors on the PCjr are different than both CGA and Tandy (I have no idea how far the hue is offset by; if any one is interested I can do some captures when I get a chance). Offhand the only game I can think of that utilizes this is Below the Root; it's really CGA mode 4 no matter what machine you have, but on a PCjr it uses different color patterns so on a composite monitor the results look similar to the CGA composite version. In mode 6 I think PCjr should be same as new CGA with no offset (though that's from memory, I would need to double check that).
Since the 16 solid/chroma colors appear to be the same as new CGA, at least in the abovementioned videos, I find it a bit odd that the artifact colors should be any different. But yes, a few representative captures could be interesting if you get a chance.
I tried to check what Below the Root does when it detects a PCjr, but DOSBox didn't get me very far - with machine=pcjr I can hear 3-voice music and then gameplay sounds, but the screen is just blank. My test copy is a DOS conversion, so I don't know if they broke something while converting it, or it's original behavior that DOSBox is choking on.
Run the below program and take pictures of the output, that will show what the colors are supposed to be.
CHART.COM seems to be using 0x3d8/9, so I don't think it'll give the desired results on a real PCjr.