No palette update for 4bpp SVGA modes

Here you can discuss the development of patches.

No palette update for 4bpp SVGA modes

Postby h-a-l-9000 » 2007-7-24 @ 22:35

DOSBox doesn't set a new palette for M_LIN4 graphics modes. The bug might not have surfaced yet because the previous palette was identical.


Code: Select all
Index: src/ints/int10_modes.cpp
===================================================================
RCS file: /cvsroot/dosbox/dosbox/src/ints/int10_modes.cpp,v
retrieving revision 1.61
diff -u -r1.61 int10_modes.cpp
--- src/ints/int10_modes.cpp   5 Jul 2007 19:36:53 -0000   1.61
+++ src/ints/int10_modes.cpp   24 Jul 2007 22:29:12 -0000
@@ -912,6 +912,7 @@
             }
             break;
          }
+      case M_LIN4:
 dac_text16:
          for (i=0;i<64;i++) {
             IO_Write(0x3c9,text_palette[i][0]);
h-a-l-9000
DOSBox Author
 
Posts: 4512
Joined: 2005-2-23 @ 00:14

Re: No palette update for 4bpp SVGA modes

Postby wd » 2007-7-24 @ 22:45

lin4 is quite rare, but doesn't make much sense to omit the palette set.
Did you check univbe or some bios, or where did it occur?
wd
DOSBox Author
 
Posts: 10818
Joined: 2003-12-03 @ 21:23

Re: No palette update for 4bpp SVGA modes

Postby h-a-l-9000 » 2007-7-24 @ 23:04

I found this when fixing the ET4000 palette bug in Vasyls SVGA patch. Didn't really find anything that breaks but M_LIN4 seems not so uncommon with CAD software. I have one that uses M_LIN4 (video mode 6A) but doesn't break because the previos palette is correct. (It does break with ET4000 because the attrib palette pointers are wrong there - it's this sick greenish look).
I've looked at the palette the S3 BIOS sets in that case and it is identical with the text mode palette.
1+1=10
h-a-l-9000
DOSBox Author
 
Posts: 4512
Joined: 2005-2-23 @ 00:14

Re: No palette update for 4bpp SVGA modes

Postby wd » 2007-7-24 @ 23:19

Ok thanks for the infos (and get some serious cad system ;) ).
wd
DOSBox Author
 
Posts: 10818
Joined: 2003-12-03 @ 21:23


Return to DOSBox Patches

Who is online

Users browsing this forum: No registered users and 3 guests