SDL patch (fixes memory leak in DirectDraw backend)

Here you can discuss the development of patches.

SDL patch (fixes memory leak in DirectDraw backend)

Postby Kippesoep » 2009-6-20 @ 19:47

As discussed in the #dosbox IRC channel.

This fixes the memory leak h-a-l-9000 experienced on SDL_SetVideoMode.
You do not have the required permissions to view the files attached to this post.
User avatar
Kippesoep
Oldbie
 
Posts: 1015
Joined: 2005-5-04 @ 22:36
Location: Netherlands

Re: SDL patch (fixes memory leak in DirectDraw backend)

Postby Dominus » 2009-6-22 @ 19:59

could you elaborate just a bit? And does this patch SDL or Dosbox? And anyway, can a mod move it to the patches forum, so I can find it again, when the need arises? :)
User avatar
Dominus
DOSBox Moderator
 
Posts: 7694
Joined: 2002-10-03 @ 09:54
Location: Ludwigsburg

Re: SDL patch (fixes memory leak in DirectDraw backend)

Postby wd » 2009-6-22 @ 20:13

Patch is againsd sdl, we're using a path that the sdl people don't care about
(directx backend with fast rendering).
wd
DOSBox Author
 
Posts: 10818
Joined: 2003-12-03 @ 21:23

Re: SDL patch (fixes memory leak in DirectDraw backend)

Postby Kippesoep » 2009-6-27 @ 02:57

Since the SDL people aren't likely to respond any time soon, attached is an updated DLL file that incorporates the fix (as well as the regular DOSBox-specific changes).
You do not have the required permissions to view the files attached to this post.
User avatar
Kippesoep
Oldbie
 
Posts: 1015
Joined: 2005-5-04 @ 22:36
Location: Netherlands

Re: SDL patch (fixes memory leak in DirectDraw backend)

Postby Good Ol' TarviS » 2011-3-23 @ 07:36

I'm sorry about bumping this, but why is this not included in more recent builds (namely those with direct3d output support?) Changing modes is nearly instant with this SDL.DLL compared with the stock one in ykhwong's build. At least I've noticed this is System Shock, which goes back to 320x200 whenever the main menu or map is brought up.
User avatar
Good Ol' TarviS
Newbie
 
Posts: 67
Joined: 2009-7-24 @ 14:28

Re: SDL patch (fixes memory leak in DirectDraw backend)

Postby wd » 2011-3-23 @ 07:38

Please post reports ONLY against the latest official release.
wd
DOSBox Author
 
Posts: 10818
Joined: 2003-12-03 @ 21:23

Re: SDL patch (fixes memory leak in DirectDraw backend)

Postby Good Ol' TarviS » 2011-3-23 @ 07:47

There are no improvements for DOSBOX 0.74 using this DLL. OpenGL and OpenGLNB still have considerable delays when changing modes.

Still, I feel it is significant that it greatly improves performance of the Direct3D9 patch.
User avatar
Good Ol' TarviS
Newbie
 
Posts: 67
Joined: 2009-7-24 @ 14:28

Re: SDL patch (fixes memory leak in DirectDraw backend)

Postby Kippesoep » 2011-3-23 @ 08:15

This has nothing to do with the speed of mode switching. All it does is fix one memory leak when using DirectDraw. It does absolutely nothing with OpenGL. Any improvements in speed are purely coincidental except in edge cases and are much more likely due to your graphics card driver. This is not a performance patch. It is a memory bugfix.
My site: Ramblings on mostly tech stuff.
User avatar
Kippesoep
Oldbie
 
Posts: 1015
Joined: 2005-5-04 @ 22:36
Location: Netherlands


Return to DOSBox Patches

Who is online

Users browsing this forum: No registered users and 1 guest