VOGONS

Common searches


SDL patch (fixes memory leak in DirectDraw backend)

Topic actions

  • This topic is locked. You cannot reply or edit posts.

First post, by Kippesoep

User metadata
Rank Oldbie
Rank
Oldbie

As discussed in the #dosbox IRC channel.

This fixes the memory leak h-a-l-9000 experienced on SDL_SetVideoMode.

Attachments

  • Filename
    bugfix.diff
    File size
    1.16 KiB
    Downloads
    77 downloads
    File comment
    Patch for SDL 1.2.13.
    File license
    Fair use/fair dealing exception

Reply 1 of 7, by Dominus

User metadata
Rank DOSBox Moderator
Rank
DOSBox Moderator

could you elaborate just a bit? And does this patch SDL or Dosbox? And anyway, can a mod move it to the patches forum, so I can find it again, when the need arises? 😀

Windows 3.1x guide for DOSBox
60 seconds guide to DOSBox
DOSBox SVN snapshot for macOS (10.4-11.x ppc/intel 32/64bit) notarized for gatekeeper

Reply 3 of 7, by Kippesoep

User metadata
Rank Oldbie
Rank
Oldbie

Since the SDL people aren't likely to respond any time soon, attached is an updated DLL file that incorporates the fix (as well as the regular DOSBox-specific changes).

Attachments

  • Filename
    SDL.zip
    File size
    112.32 KiB
    Downloads
    45 downloads
    File comment
    Patched DLL
    File license
    Fair use/fair dealing exception

Reply 4 of 7, by Good Ol' TarviS

User metadata
Rank Newbie
Rank
Newbie

I'm sorry about bumping this, but why is this not included in more recent builds (namely those with direct3d output support?) Changing modes is nearly instant with this SDL.DLL compared with the stock one in ykhwong's build. At least I've noticed this is System Shock, which goes back to 320x200 whenever the main menu or map is brought up.

Reply 7 of 7, by Kippesoep

User metadata
Rank Oldbie
Rank
Oldbie

This has nothing to do with the speed of mode switching. All it does is fix one memory leak when using DirectDraw. It does absolutely nothing with OpenGL. Any improvements in speed are purely coincidental except in edge cases and are much more likely due to your graphics card driver. This is not a performance patch. It is a memory bugfix.

My site: Ramblings on mostly tech stuff.