DOSBox-X branch

Here you can discuss the development of patches.

Re: DOSBox-X branch

Postby hail-to-the-ryzen » 2018-8-30 @ 01:27

Is this patch compatible with the dosbox-x menu code? It seems to correct the issue where the window position is set at coordinate 0,0 after exiting fullscreen mode. The expected behavior is where the window position is not reset but instead retains its previous location.
Code: Select all
diff -rupN SDL-1.2-Orig//src/video/windib/SDL_dibvideo.c SDL-1.2/src/video/windib/SDL_dibvideo.c
--- SDL-1.2-Orig//src/video/windib/SDL_dibvideo.c
+++ SDL-1.2/src/video/windib/SDL_dibvideo.c
@@ -948,8 +948,8 @@ SDL_Surface *DIB_SetVideoMode(_THIS, SDL
 
    if ((video->flags & SDL_FULLSCREEN) == SDL_FULLSCREEN) {
       /* HACK */
-      SDL_windowX = 0;
-      SDL_windowY = 0;
+      // SDL_windowX = 0;
+      // SDL_windowY = 0;
 
       /* pay attention! */
       SetFocus(SDL_Window);
hail-to-the-ryzen
Member
 
Posts: 325
Joined: 2017-3-09 @ 01:34

Re: DOSBox-X branch

Postby TheGreatCodeholio » 2018-8-30 @ 02:12

hail-to-the-ryzen wrote:Is this patch compatible with the dosbox-x menu code? It seems to correct the issue where the window position is set at coordinate 0,0 after exiting fullscreen mode. The expected behavior is where the window position is not reset but instead retains its previous location.
Code: Select all
diff -rupN SDL-1.2-Orig//src/video/windib/SDL_dibvideo.c SDL-1.2/src/video/windib/SDL_dibvideo.c
--- SDL-1.2-Orig//src/video/windib/SDL_dibvideo.c
+++ SDL-1.2/src/video/windib/SDL_dibvideo.c
@@ -948,8 +948,8 @@ SDL_Surface *DIB_SetVideoMode(_THIS, SDL
 
    if ((video->flags & SDL_FULLSCREEN) == SDL_FULLSCREEN) {
       /* HACK */
-      SDL_windowX = 0;
-      SDL_windowY = 0;
+      // SDL_windowX = 0;
+      // SDL_windowY = 0;
 
       /* pay attention! */
       SetFocus(SDL_Window);


Looks good to me.
DOSBox-X project: more emulation better accuracy.
DOSLIB and DOSLIB2: Learn how to tinker and hack hardware and software from DOS.
User avatar
TheGreatCodeholio
Oldbie
 
Posts: 690
Joined: 2011-8-18 @ 20:15
Location: Seattle, WA

Re: DOSBox-X branch

Postby hail-to-the-ryzen » 2018-8-30 @ 02:18

:)

I also replicated the ROM "writes" to the EMS memory frame where loading the Windows 95 version of EMS386. As you indicated, it was a different (and higher) region of memory. I assume that the OS on boot is verifying that memory area as not writable.
hail-to-the-ryzen
Member
 
Posts: 325
Joined: 2017-3-09 @ 01:34

Re: DOSBox-X branch

Postby hail-to-the-ryzen » 2018-8-31 @ 04:30

Interesting findings on the S3 Trio and its drivers. Would it be useful to emulate a true ISA based S3 card for testing against the Windows 3.x drivers? Also, after this LFB work, is it necessary to continue to offer the vesa_nolfb machine type?
hail-to-the-ryzen
Member
 
Posts: 325
Joined: 2017-3-09 @ 01:34

Re: DOSBox-X branch

Postby TheGreatCodeholio » 2018-8-31 @ 04:41

hail-to-the-ryzen wrote:Interesting findings on the S3 Trio and its drivers. Would it be useful to emulate a true ISA based S3 card for testing against the Windows 3.x drivers? Also, after this LFB work, is it necessary to continue to offer the vesa_nolfb machine type?


The vesa_nolfb option if I understand is meant to tell DOSBox to emulate S3 but to emulate a VESA BIOS that does not emulate a linear framebuffer, so that DOS games that are incompatible with it can run, right?

It's also useful for testing your own retro-development to see how well your code can handle a VESA BIOS without linear framebuffer support.

ISA S3 emulation will have to emulate a card that pre-dates the PCI, EISA, and VESA slots. From what I understand, that means emulating an S3 chipset that's older than the Trio64 cards.
DOSBox-X project: more emulation better accuracy.
DOSLIB and DOSLIB2: Learn how to tinker and hack hardware and software from DOS.
User avatar
TheGreatCodeholio
Oldbie
 
Posts: 690
Joined: 2011-8-18 @ 20:15
Location: Seattle, WA

Re: DOSBox-X branch

Postby hail-to-the-ryzen » 2018-8-31 @ 04:50

If the LFB is now configurable in DOSBox-X, then it should be possible to turn it off from an application instead of specifying a machine type, but certainly the option is useful in the configuration file.

From a cursory search, I couldn't find which versions of the S3 cards correspond to the different slots. It seems that nearly all sites classify an EISA card as an ISA.
hail-to-the-ryzen
Member
 
Posts: 325
Joined: 2017-3-09 @ 01:34

Re: DOSBox-X branch

Postby TheGreatCodeholio » 2018-8-31 @ 05:12

http://vgamuseum.info seems to be the best resource out there, so far. Including datasheets.
DOSBox-X project: more emulation better accuracy.
DOSLIB and DOSLIB2: Learn how to tinker and hack hardware and software from DOS.
User avatar
TheGreatCodeholio
Oldbie
 
Posts: 690
Joined: 2011-8-18 @ 20:15
Location: Seattle, WA

Re: DOSBox-X branch

Postby hail-to-the-ryzen » 2018-8-31 @ 05:19

I searched some of the entries and it seems that the S3 Trio is >ISA, but the early versions of the Diamond Stealth are ISA based cards. It seems that 1991/2 are ISA, but I didn't find a 1993 example, and then the later cards are advanced slots.
hail-to-the-ryzen
Member
 
Posts: 325
Joined: 2017-3-09 @ 01:34

Re: DOSBox-X branch

Postby vogoner » 2018-8-31 @ 14:30

Hi all, I'm new here but I play PC games since the CGA era.

I've been using DOSBox SVN-Daum for quite some time but I would like to try DOSBox-X. I downloaded it from here -> https://github.com/joncampbell123/dosbox-x/releases, but it does not work in Windows XP. Is there a fix for this? or can someone point me to a version that works in Windows XP? I hope this will be fixed in the next version.

Thank you.
vogoner
Newbie
 
Posts: 3
Joined: 2018-8-29 @ 23:16

Re: DOSBox-X branch

Postby TheGreatCodeholio » 2018-8-31 @ 18:38

vogoner wrote:Hi all, I'm new here but I play PC games since the CGA era.

I've been using DOSBox SVN-Daum for quite some time but I would like to try DOSBox-X. I downloaded it from here -> https://github.com/joncampbell123/dosbox-x/releases, but it does not work in Windows XP. Is there a fix for this? or can someone point me to a version that works in Windows XP? I hope this will be fixed in the next version.

Thank you.


The main release cannot support Windows XP because Visual Studio 2017 doesn't support it properly.

The MinGW builds however should work on Windows XP.
DOSBox-X project: more emulation better accuracy.
DOSLIB and DOSLIB2: Learn how to tinker and hack hardware and software from DOS.
User avatar
TheGreatCodeholio
Oldbie
 
Posts: 690
Joined: 2011-8-18 @ 20:15
Location: Seattle, WA

Re: DOSBox-X branch

Postby hail-to-the-ryzen » 2018-9-01 @ 11:06

hail-to-the-ryzen wrote:A greater concern is that the output=opengl mode now has a long time delay where switching from window to full screen mode. I noted it today, but it occurs in my current build and one I built in March. I think it may be from the yesterday's Windows 10 update. I haven't tested for the issue in other builds yet.

Solution is to disable this activated feature of Windows 10: https://www.google.com/search?q=focus+assist+disable
hail-to-the-ryzen
Member
 
Posts: 325
Joined: 2017-3-09 @ 01:34

Re: DOSBox-X branch

Postby TheGreatCodeholio » 2018-9-01 @ 22:01

DOSBox-X 0.82.9 is released. Mouse pointer integration, MCGA and MDA emulation, EGA bug fixes, Video capture and run command, hacks, fixes, and more. See changelog for details. https://github.com/joncampbell123/dosbo ... ws-v0.82.9
DOSBox-X project: more emulation better accuracy.
DOSLIB and DOSLIB2: Learn how to tinker and hack hardware and software from DOS.
User avatar
TheGreatCodeholio
Oldbie
 
Posts: 690
Joined: 2011-8-18 @ 20:15
Location: Seattle, WA

Re: DOSBox-X branch

Postby Timbi » 2018-9-02 @ 10:59

Hi

Thanks for the release


I run the system from image and I think I found a bug associated with config.sys>menucolor. It occurs also in the older versions.
Shouldn't the background and font color be saved?
No matter what is loaded, device or executable, the color data is always flushed out and strings print with defaults.
https://i.imgur.com/CrHaSCs.png
User avatar
Timbi
Newbie
 
Posts: 14
Joined: 2016-4-11 @ 09:07

Re: DOSBox-X branch

Postby TheGreatCodeholio » 2018-9-02 @ 14:25

Timbi wrote:Hi

Thanks for the release


I run the system from image and I think I found a bug associated with config.sys>menucolor. It occurs also in the older versions.
Shouldn't the background and font color be saved?
No matter what is loaded, device or executable, the color data is always flushed out and strings print with defaults.
https://i.imgur.com/CrHaSCs.png


Since this is low level, that would be a fault with INT 10h emulation, correct?

So this is a case where INT 10h is writing a color attribute when it shouldn't, then?
DOSBox-X project: more emulation better accuracy.
DOSLIB and DOSLIB2: Learn how to tinker and hack hardware and software from DOS.
User avatar
TheGreatCodeholio
Oldbie
 
Posts: 690
Joined: 2011-8-18 @ 20:15
Location: Seattle, WA

Re: DOSBox-X branch

Postby vogoner » 2018-9-03 @ 09:39

TheGreatCodeholio wrote:The main release cannot support Windows XP because Visual Studio 2017 doesn't support it properly.

The MinGW builds however should work on Windows XP.

And where can I download those builds?
vogoner
Newbie
 
Posts: 3
Joined: 2018-8-29 @ 23:16

Re: DOSBox-X branch

Postby TheGreatCodeholio » 2018-9-03 @ 14:11

vogoner wrote:
TheGreatCodeholio wrote:The main release cannot support Windows XP because Visual Studio 2017 doesn't support it properly.

The MinGW builds however should work on Windows XP.

And where can I download those builds?


Github, of course!

https://github.com/joncampbell123/dosbox-x/releases
DOSBox-X project: more emulation better accuracy.
DOSLIB and DOSLIB2: Learn how to tinker and hack hardware and software from DOS.
User avatar
TheGreatCodeholio
Oldbie
 
Posts: 690
Joined: 2011-8-18 @ 20:15
Location: Seattle, WA

Re: DOSBox-X branch

Postby vogoner » 2018-9-03 @ 14:40

^Thank you very much for your help, and sorry I completely missed that link.
vogoner
Newbie
 
Posts: 3
Joined: 2018-8-29 @ 23:16

Re: DOSBox-X branch

Postby hail-to-the-ryzen » 2018-9-05 @ 07:19

This FDC configuration option doesn't seem available: auto-attach to int 13h.
hail-to-the-ryzen
Member
 
Posts: 325
Joined: 2017-3-09 @ 01:34

Re: DOSBox-X branch

Postby TheGreatCodeholio » 2018-9-05 @ 08:11

hail-to-the-ryzen wrote:This FDC configuration option doesn't seem available: auto-attach to int 13h.


Currently it auto-attaches to A: and B: as a means to attach a floppy disk image at all, especially if booting into a guest OS.
DOSBox-X project: more emulation better accuracy.
DOSLIB and DOSLIB2: Learn how to tinker and hack hardware and software from DOS.
User avatar
TheGreatCodeholio
Oldbie
 
Posts: 690
Joined: 2011-8-18 @ 20:15
Location: Seattle, WA

Re: DOSBox-X branch

Postby hail-to-the-ryzen » 2018-9-05 @ 08:40

Could that option be removed from the configuration list? Also, is it ever necessary to set "allow dma address decrement" to false?
hail-to-the-ryzen
Member
 
Posts: 325
Joined: 2017-3-09 @ 01:34

PreviousNext

Return to DOSBox Patches

Who is online

Users browsing this forum: Ringding and 1 guest