Reply 40 of 58, by Serious Callers Only
Bumping this since this patch starting failing to apply since r4130. I may try to fix it for myself on the ppa but i'd prefer this was fixed in the thread.
And i mean 'fixed' as a diff, not a executable being shared ofc.
edit:'fixed' it on the ppa by hacking around it on this commit (the voodoo patch is just a 'drift' update and not relevant), not sure if it's subtly broken or not because i don't really understand the code.
There were only two 'real' changes that caused the patch to fail on recent revisions on drive_fat.cpp.
One was very simple to fix, a new function variable assignment was introduced instead of being inline...
the other, a cleanup 'if' was expanded greatly on this upstream commit (this is a clone repository) https://bazaar.launchpad.net/~i30817/dosbox/t … k/revision/4028 (line 731), that was changed by the original patch to do the opposite that upstream does, i moved the original part out and recreated what the original patch did (left created_successfully == true, assigned 'fattype = FAT32' and returned) and left the rest of the conditions assigning 'created_successfully = false;' for the new error cases. I'm not sure this really works considering how the rest of the file interacts with both the patch and the new code at upstream r4130, whatever.
I only use this patch on large windows 95 games i want to run on dosbox (which requires fdisk formated native images), so it's a borderline use anyway.