VIDEO - Multiple SVGA Chipset patch (commited)

Here you can discuss the development of patches.

Re: Patch for Tseng SVGA support is available in SourceForge

Postby Plan9FOS » 2007-7-02 @ 04:59

Found it.

Thanks for the help.
Plan9FOS
Newbie
 
Posts: 55
Joined: 2007-7-01 @ 21:14

Re: Multiple SVGA Chipset patch

Postby ykhwong » 2007-9-23 @ 08:01

The existing SVGA patch seems not to work with a new implementation of ega machine.
Just a note.

Code: Select all
2007-09-20 18:42  c2woody

   * include/dosbox.h, src/dosbox.cpp, src/dos/dev_con.h,
     src/dos/dos_keyboard_layout.cpp, src/hardware/dma.cpp,
     src/hardware/gus.cpp, src/hardware/sblaster.cpp,
     src/hardware/vga.cpp, src/hardware/vga_attr.cpp,
     src/hardware/vga_crtc.cpp, src/hardware/vga_dac.cpp,
     src/hardware/vga_draw.cpp, src/hardware/vga_gfx.cpp,
     src/hardware/vga_memory.cpp, src/hardware/vga_misc.cpp,
     src/hardware/vga_seq.cpp, src/hardware/vga_xga.cpp,
     src/ints/bios.cpp, src/ints/int10.cpp, src/ints/int10_char.cpp,
     src/ints/int10_memory.cpp, src/ints/int10_modes.cpp,
     src/ints/int10_pal.cpp: add partial ega-only machine
ykhwong
Oldbie
 
Posts: 627
Joined: 2004-3-17 @ 15:35

Re: Multiple SVGA Chipset patch

Postby vasyl » 2007-9-23 @ 09:12

Thanks for letting me know. I will check it tomorrow.
vasyl
Oldbie
 
Posts: 680
Joined: 2005-3-27 @ 04:53

Re: Multiple SVGA Chipset patch

Postby gulikoza » 2007-9-23 @ 12:56

Don't forget to include the MMIO fix (see dosbox changelog) :wink:
User avatar
gulikoza
Oldbie
 
Posts: 1698
Joined: 2004-6-25 @ 14:53

Re: Multiple SVGA Chipset patch

Postby wd » 2007-9-23 @ 17:07

Thanks for letting me know. I will check it tomorrow.

There's more to come, so maybe delay it somewhat.
wd
DOSBox Author
 
Posts: 10818
Joined: 2003-12-03 @ 21:23

Re: Multiple SVGA Chipset patch

Postby h-a-l-9000 » 2007-9-23 @ 17:39

You'll fix the vesa scanline length problem for 4bpp too?
1+1=10
h-a-l-9000
DOSBox Author
 
Posts: 4512
Joined: 2005-2-23 @ 00:14

Re: Multiple SVGA Chipset patch

Postby vasyl » 2007-9-24 @ 08:36

Checked... ouch! This may take some time to integrate and test properly. Looks like I've been out of the loop for too long.
@wd: When do you expect the rest of your changes to go in? If it's less than a week, I'll wait. Otherwise I will risk doing the same work twice :s-face:
vasyl
Oldbie
 
Posts: 680
Joined: 2005-3-27 @ 04:53

Re: Multiple SVGA Chipset patch

Postby wd » 2007-9-24 @ 09:11

Suppose at the end of this week most stuff should be up, maybe pm me before
you're going to adapt things.
wd
DOSBox Author
 
Posts: 10818
Joined: 2003-12-03 @ 21:23

Re: Multiple SVGA Chipset patch

Postby vasyl » 2007-10-01 @ 06:42

The new version is up. I did not have time to test every single feature but it seems to work properly so far. Enjoy!
vasyl
Oldbie
 
Posts: 680
Joined: 2005-3-27 @ 04:53

Re: Multiple SVGA Chipset patch

Postby DOSGuy » 2007-10-02 @ 20:03

Hi vasyl.

First of all, great job on the SVGA plugin. I've been able to use an emulator called RIXAI to emulate an 8514/a adapter using the Tseng ET4000 svgachipset. To the best of my knowledge, I'm the first person to play Mah Jongg -8514- in DOSBox. That's a pretty amazing accomplishment for your plugin considering that you weren't even working on 8514 emulation.

I'm getting a ton of errors in the status window that look like:

Code: Select all
Illegal write to c003364b CS:IP    c7ff:      1d,phys c003364b


Some kind of register issue? Just wanted to bring this to your attention. Links to Mah Jongg -8514-, RIXAI, and the discussion that led to all of this are at Accelerator board? In those old days?
"Today entirely the maniac there is no excuse with the article." Get free DOS, OS/2 and Windows games at RGB Classic Games
User avatar
DOSGuy
Newbie
 
Posts: 31
Joined: 2007-10-02 @ 09:52

Re: Multiple SVGA Chipset patch

Postby vasyl » 2007-10-03 @ 03:01

I will take a look. I haven't seen that error message before, could be a bug in emulation but it might be in the game or RIXAI utility. I am quite curious about that utility now -- it supposedly does register-level emulation, that's unusual for DOS TSRs.
vasyl
Oldbie
 
Posts: 680
Joined: 2005-3-27 @ 04:53

Re: Multiple SVGA Chipset patch

Postby OSH » 2007-12-03 @ 19:36

I have one simple question. How can force DOSBOX to use SVGA? I'm using D.O.G. and can't find SVGA-Setup...
User avatar
OSH
Member
 
Posts: 171
Joined: 2007-10-28 @ 23:34

Re: Multiple SVGA Chipset patch

Postby DOSGuy » 2007-12-03 @ 19:44

This plugin stores its variables in a section of dosbox.conf called "VGA". There are two variables: svgachipset and videoram. S3 is the default, but that's no guarantee of compatibility. Games that support SVGA resolutions will usually indicate which chipsets they support, and often how much video RAM they need. I used to get by with my Trident 1 MB card, but I couldn't display as many colors as I wanted at the resolutions I wanted in Windows 3.1. "2048" (2 MB) should be a safe minimum.
"Today entirely the maniac there is no excuse with the article." Get free DOS, OS/2 and Windows games at RGB Classic Games
User avatar
DOSGuy
Newbie
 
Posts: 31
Joined: 2007-10-02 @ 09:52

Re: Multiple SVGA Chipset patch

Postby Dominus » 2007-12-03 @ 19:51

You have to edit dosbox.conf directly and you need to use a special build of Dosbox that has this patch integrated. Lock, stock Dosbox does not have this.
User avatar
Dominus
DOSBox Moderator
 
Posts: 7385
Joined: 2002-10-03 @ 09:54
Location: Vienna

Re: Multiple SVGA Chipset patch

Postby DosFreak » 2007-12-03 @ 19:52

Should Hal's patch be included with this one? Is Vasyl still alive? I guess the question is, Is Hal's S3 patch a candidate to be included in the official version of DosBox?
Game Acronym List
DosBox CVS Builds
DosBox Feature Request Thread
DosBox FAQ
PC Game Compatibility List
"Who's got time to read all the way down to the bottom of an email?"
User avatar
DosFreak
l33t++
 
Posts: 9542
Joined: 2002-6-30 @ 16:35
Location: Your Head

Re: Multiple SVGA Chipset patch

Postby wd » 2007-12-03 @ 20:06

Yes, i'll try to merge it by times.
wd
DOSBox Author
 
Posts: 10818
Joined: 2003-12-03 @ 21:23

Re: Multiple SVGA Chipset patch

Postby vasyl » 2007-12-04 @ 03:37

Is Vasyl still alive?

Yes, I am pretty much alive, just very busy lately -- not much time left between day job and family. There was also a mishap while upgrading main home PC, that took much more of my time than expected (and two motherboards sent to warranty repairs). I do remember about my promise to split my patch into manageable chunks... I will get to it when I can.
vasyl
Oldbie
 
Posts: 680
Joined: 2005-3-27 @ 04:53

Re: Multiple SVGA Chipset patch

Postby DosFreak » 2007-12-04 @ 04:30

heh, Just joking man hadn't seen you around here in awhile is all.

Too bad about the motherboards. Haven't had that happen to me yet. Been pretty lucky in that regard when building my computers.
Game Acronym List
DosBox CVS Builds
DosBox Feature Request Thread
DosBox FAQ
PC Game Compatibility List
"Who's got time to read all the way down to the bottom of an email?"
User avatar
DosFreak
l33t++
 
Posts: 9542
Joined: 2002-6-30 @ 16:35
Location: Your Head

Re: Multiple SVGA Chipset patch

Postby vasyl » 2007-12-26 @ 08:45

Yet another refresh. No functional changes, just making it to compile and run with recent CVS. The code is starting to show some staleness, e.g., there are a couple of S3-isms in vga_draw.cpp that I did not clean up yet. On the positive side, some things became more consistent between CVS and the patch, like those screen geometry calculations in SetupDrawing -- my patch had some fixes there before, now not needed.
Now, the plan. Looks like I may have a little time in a few coming weeks so I finally can break the patch down to pieces and present it to DOSBox devs so we may see at least some parts merged in.
1) there are a few generic bug fixes in the patch, nothing major but they don't belong to this patch. These will be taken care of separately;
2) a lot of changes (mostly in vga_memory and vga_draw) are due to the dynamic VRAM allocation. This can be done as a separate "second stage" patch;
3) large part of the patch is caused by moving mode lines from int10_modes to drivers. It is almost correct but not exactly. The "correct" layered solution would be to actually have driver-specific branches of int10_modes (int10_modes_s3, int10_modes_tseng, etc.) For the simplicity I am going to move those pieces back to int10_modes and add checks for SVGA type where needed (those checks are necessary anyway, now that we have VGANone in CVS);
4) currently, some lines are moved from other files to vga_s3.cpp. Strictly speaking, this is not necessary. I will try to rewrite relevant parts to minimize the diff;
5) I am going to move chipset control from [vga] section to machine= line for consistency with some recent changes.
Stay tuned.
vasyl
Oldbie
 
Posts: 680
Joined: 2005-3-27 @ 04:53

Re: Multiple SVGA Chipset patch

Postby vasyl » 2008-1-10 @ 06:41

Important status update. The outlined plan is complete and, big thanks to wd, the essential portion of the patch is already in CVS. Pretty much the only part of the patch that is still not in is the dynamic VRAM allocation and boundary checks. I will update the patch on SF shortly. The remainder is about 1/4 in size.
There is one important functional change. Instead of [vga] section, machine= line in [dosbox] section is used. In addition to existing values you can specify "vga_et4000", "vga_et3000", or "vga_pvga1a" with some alternative spellings ("svga" can be used instead of "vga"). The updated version of the patch will allow to specify VRAM size on the same line as a number; it will also understand "new" for ET4000 chipsets.
vasyl
Oldbie
 
Posts: 680
Joined: 2005-3-27 @ 04:53

PreviousNext

Return to DOSBox Patches

Who is online

Users browsing this forum: No registered users and 2 guests