DosBox for OS/2

Here you can discuss the development of patches.

DosBox for OS/2

Postby josch » 2005-6-17 @ 16:21

I have almost finished the OS/2 port of version 0.63.
Now I have two questions?
Who should receive the source code?
Should I sent patches or the whole thing?

Bye Jochen
User avatar
josch
Newbie
 
Posts: 28
Joined: 2005-2-10 @ 12:40
Location: Schifferstadt

Re: How to submit a port?

Postby `Moe` » 2005-6-17 @ 17:15

SDL changes should go to Sam Latinga <slouken@libsdl.org>, dosbox changes should be posted in the "Patches" section of http://sourceforge.net/projects/dosbox/. Create Patches against latest CVS using "cvs diff -u". Drop us a line if you need more advice ;)
User avatar
`Moe`
Oldbie
 
Posts: 1169
Joined: 2004-4-29 @ 01:06
Location: Oldenburg, Germany

Re: How to submit a port?

Postby josch » 2005-6-17 @ 21:56

It's really a patch against 0.63.
CVS HEAD would be the next step.
And how can I integrate new files with cvs diff?
User avatar
josch
Newbie
 
Posts: 28
Joined: 2005-2-10 @ 12:40
Location: Schifferstadt

Re: How to submit a port?

Postby Qbix » 2005-6-18 @ 10:32

uhm cvs add would what I use.
but not sure if that is possible on anonymouse acces.

it' would be nice if you can get it working against CVS HEAD.
It may look quite different but it's not.
altough the code of dosbox has increased/improved quite a lot since 0.63
Water flows down the stream
How to ask questions the smart way!
User avatar
Qbix
DOSBox Author
 
Posts: 10555
Joined: 2002-11-27 @ 14:50
Location: Fryslan

Re: How to submit a port?

Postby `Moe` » 2005-6-19 @ 15:12

Make sure you don't do too many adjustments in dosbox when they really belong into SDL. SDL is supposed to be the cross-platform interface. Since I don't know your code, I have no idea if this suggestion applies to you.

About diffing with added files: you can't "cvs add" with anonymous cvs. Check out a second tree, and use something like "diff -ruN dosbox-original dosbox-os2", then edit the resulting patch and remove all sections that don't belong to your source files (like Makefiles and these). You can add multiple options like "-x Makefile.in", "-x Makefile", ... to exclude some files automatically. It's a bit tedious, but if you save your diff command in a shell script/batch file, you need to tune this only once.
User avatar
`Moe`
Oldbie
 
Posts: 1169
Joined: 2004-4-29 @ 01:06
Location: Oldenburg, Germany

Re: How to submit a port?

Postby Qbix » 2005-6-19 @ 18:26

cvs diff -ruN ?

according to my manual cvs does accept this option
Water flows down the stream
How to ask questions the smart way!
User avatar
Qbix
DOSBox Author
 
Posts: 10555
Joined: 2002-11-27 @ 14:50
Location: Fryslan

Re: How to submit a port?

Postby `Moe` » 2005-6-19 @ 22:13

No, not "cvs diff", just "diff". r == recurse into subdirs, u == unified format, N == also include new files
User avatar
`Moe`
Oldbie
 
Posts: 1169
Joined: 2004-4-29 @ 01:06
Location: Oldenburg, Germany

Re: How to submit a port?

Postby josch » 2005-6-20 @ 20:03

Perhaps I did something wrong, but I did use -ruN. I will try it again.
SDL: No didn't change anything with SDL (I believe). I really didn't make much anyway.
CVS head: Yes I will do that, but my problem here is that the assignment, which started the whole thing wants a 0.63 version.
So I like to submit a 0.63 patch, so the OS/2 folks can use a stable release.
If that's done, I will integrate the changes into head. I really like to see the Win16 support myself ;-)

Bye JoSch
User avatar
josch
Newbie
 
Posts: 28
Joined: 2005-2-10 @ 12:40
Location: Schifferstadt

Re: How to submit a port?

Postby josch » 2005-6-23 @ 12:16

I have submitted the patch ;-)
User avatar
josch
Newbie
 
Posts: 28
Joined: 2005-2-10 @ 12:40
Location: Schifferstadt

Re: How to submit a port?

Postby mirekluza » 2005-6-23 @ 12:27

Well, the description "This patch adds support for OS/2 to DOSBOX v0.63." is not the best one... It implies rather that DOSBOX now runs OS/2 (in the same way as W3.x etc.) than what you really meant - that it is possible to use DOSBOX in OS/2.

Mirek
mirekluza
DOSBox Moderator
 
Posts: 1697
Joined: 2003-8-21 @ 04:19

Re: How to submit a port?

Postby Qbix » 2005-6-23 @ 12:43

patch looks good btw.
unfortunate the serial support is undergoing a rewrite by H-A-l-900
Let's hope it's compatible with your code.

Will copy/move this thread to the dosbox patches forum as well.
Water flows down the stream
How to ask questions the smart way!
User avatar
Qbix
DOSBox Author
 
Posts: 10555
Joined: 2002-11-27 @ 14:50
Location: Fryslan

Re: Was: DOSBOX port for OS/2

Postby josch » 2005-6-25 @ 08:56

If the serial support changes, I will redo that. Essentially, I took the Win32 version and replaced the Win32 calls with the appropiate OS/2 calls.

BTW, do you need some binaries for the download page?

Bye Jochen
User avatar
josch
Newbie
 
Posts: 28
Joined: 2005-2-10 @ 12:40
Location: Schifferstadt


Return to DOSBox Patches

Who is online

Users browsing this forum: No registered users and 2 guests