Enable CON to handle DBCS characters

Here you can discuss the development of patches.

Enable CON to handle DBCS characters

Postby cyberwalker » 2005-7-14 @ 20:25

The console (CON) is supposed to use Int 10H to display characters, but actually it bypassed for speed. So new Int 10H handler will not take effect on CON while hook on Int 16H will. This behavior will prevent applications from using their own 10H to display far east DBCS characters (Chinese/Korea/Japanese) at prompt.

This patch will restore compatibility by using real INT10 service instead of INT10 routines for CON outputting.

I have tested ET35(CHT) and XZL/TWAY(CHS) with this patch applied. Users running applicaitons use their own INT10H hook may be interested in this patch. I think compatibility is more important than speed.

I hope you will find this patch helpful.
You do not have the required permissions to view the files attached to this post.
Last edited by cyberwalker on 2005-7-16 @ 18:25, edited 2 times in total.
cyberwalker
Newbie
 
Posts: 58
Joined: 2004-11-24 @ 06:10

Re: Patch for CON to handle DBCS characters

Postby Qbix » 2005-7-14 @ 20:53

It looks quite complex.
Can't you just call interrupt 29 ? (which in turns calls intt10 ?)

or does it lack some "intelligence" in dealing with certain characters/postioning elements.
Not sure though. maybe int29 should have the ansi parsing and not the con device. well details :)
Water flows down the stream
How to ask questions the smart way!
User avatar
Qbix
DOSBox Author
 
Posts: 10556
Joined: 2002-11-27 @ 14:50
Location: Fryslan

Re: Patch for CON to handle DBCS characters

Postby cyberwalker » 2005-7-14 @ 22:22

Qbix wrote:It looks quite complex.
Can't you just call interrupt 29 ? (which in turns calls intt10 ?)

or does it lack some "intelligence" in dealing with certain characters/postioning elements.
Not sure though. maybe int29 should have the ansi parsing and not the con device. well details :)


Maybe you are right. What I have done was to get it working by converting source directly.
cyberwalker
Newbie
 
Posts: 58
Joined: 2004-11-24 @ 06:10

Re: Patch for CON to handle DBCS characters

Postby cyberwalker » 2005-7-16 @ 04:36

A new file (shell_misc.cpp) added.
cyberwalker
Newbie
 
Posts: 58
Joined: 2004-11-24 @ 06:10

Re: Patch for CON to handle DBCS characters

Postby ykhwong » 2005-7-16 @ 16:59

Why don't you make a patch by typing 'diff -urN A(previous) B(changed) < filename'?
It can be an easy way to check the changes or apply the patch.
You do not have the required permissions to view the files attached to this post.
ykhwong
Oldbie
 
Posts: 627
Joined: 2004-3-17 @ 15:35

Re: Patch for CON to handle DBCS characters

Postby cyberwalker » 2005-7-16 @ 18:24

ykhwong wrote:Why don't you make a patch by typing 'diff -urN A(previous) B(changed) < filename'?
It can be an easy way to check the changes or apply the patch.


I had thought a complete code was good for users not to use CVS tools and users could generate *.diff on their own. However *.diff files added.
Thank you.
cyberwalker
Newbie
 
Posts: 58
Joined: 2004-11-24 @ 06:10

Re: Patch for CON to handle DBCS characters

Postby HunterZ » 2005-7-16 @ 18:56

I think it's that a lot of people are maintaining their own CVS builds and would like to integrate your changes into theirs for experimental testing purposes. A patch makes this much easier to accomplish.
You're perfect, yes it's true...but without me, you're only you.
User avatar
HunterZ
l33t++
 
Posts: 6073
Joined: 2003-1-31 @ 19:04
Location: Seattle

Re: Patch for CON to handle DBCS characters

Postby cyberwalker » 2005-7-17 @ 14:45

ykhwong wrote:Why don't you make a patch by typing 'diff -urN A(previous) B(changed) < filename'?
It can be an easy way to check the changes or apply the patch.


ykhwong, I tested your recent build and found no F11/F12 patch applied. The information on your english page requires correcting.
cyberwalker
Newbie
 
Posts: 58
Joined: 2004-11-24 @ 06:10

Re: Patch for CON to handle DBCS characters

Postby ykhwong » 2005-7-17 @ 15:36

I didn't add the keys ('/','*','+' and '-' on keypad) that will be recevied by DOS apps. But F11/F12 keys are not working? I thought that I properly applied it.

It was difficult for me to combine three files with a patch file below.
keyb.patch, qemukeyboard.cpp, and bios_keyboard.cpp

Check the attchment. Can you point out mistakes that I made?
You do not have the required permissions to view the files attached to this post.
ykhwong
Oldbie
 
Posts: 627
Joined: 2004-3-17 @ 15:35

Re: Patch for CON to handle DBCS characters

Postby cyberwalker » 2005-7-17 @ 16:57

ykhwong wrote:I didn't add the keys ('/','*','+' and '-' on keypad) that will be recevied by DOS apps. But F11/F12 keys are not working? I thought that I properly applied it.
It was difficult for me to combine three files with a patch file below.
keyb.patch, qemukeyboard.cpp, and bios_keyboard.cpp
Check the attchment. Can you point out mistakes that I made?


I have checked your diff file briefly. The file sdl_mapper.cpp was quite different than CVS's(and mine). I think new bugs have been brought in when you patched it before. You may want to debug your build.
cyberwalker
Newbie
 
Posts: 58
Joined: 2004-11-24 @ 06:10

Re: Patch for CON to handle DBCS characters

Postby ykhwong » 2005-7-17 @ 17:34

Check this patch that moe modified. http://garni.ch/~jwalt/intlkey.diff
does the file sdl_mapper.cpp affect the operation of f11/f12 keys working in dos apps?
ykhwong
Oldbie
 
Posts: 627
Joined: 2004-3-17 @ 15:35

Re: Patch for CON to handle DBCS characters

Postby cyberwalker » 2005-7-18 @ 08:46

ykhwong wrote:Check this patch that moe modified. http://garni.ch/~jwalt/intlkey.diff
does the file sdl_mapper.cpp affect the operation of f11/f12 keys working in dos apps?


I think applying this patch should be ok. It seems keyboard.cpp patched with intlkey.diff in your last post changed the behavior of keyboard. I am not so sure. Debugging will tell the difference.
cyberwalker
Newbie
 
Posts: 58
Joined: 2004-11-24 @ 06:10

Re: Patch for CON to handle DBCS characters

Postby ykhwong » 2005-7-18 @ 10:02

I assume that some strings are repeated and max code was wrong in keyboard.cpp
I deleted three lines and changed code number 61 to 58.
Can you test dosbox.exe that I attached, cyberwalker? :)
(I found that f11/f12 keys really do work in MdirIII app under my build)
ykhwong
Oldbie
 
Posts: 627
Joined: 2004-3-17 @ 15:35

Re: Patch for CON to handle DBCS characters

Postby cyberwalker » 2005-7-18 @ 18:41

ykhwong wrote:I assume that some strings are repeated and max code was wrong in keyboard.cpp
I deleted three lines and changed code number 61 to 58.
Can you test dosbox.exe that I attached, cyberwalker? :)
(I found that f11/f12 keys really do work in MdirIII app under my build)


This build worked as expected. I think you have figured out what is wrong with keyboard.cpp.

I also found with Smart Updating enabled, the CPU usage decreased greatly when DOS is "Idle". Maybe Smart Updating will give DOSBOX a big advantage over VMware and VPC in running DOS applications, though it flickers displaying and forgets to update screen sometime.
cyberwalker
Newbie
 
Posts: 58
Joined: 2004-11-24 @ 06:10

Re: Patch for CON to handle DBCS characters

Postby Qbix » 2005-7-20 @ 20:09

moved it to the patches section
It needs some discussion before I add it.
Added some comments on the sf page as well
http://sourceforge.net/tracker/index.ph ... tid=467234
Water flows down the stream
How to ask questions the smart way!
User avatar
Qbix
DOSBox Author
 
Posts: 10556
Joined: 2002-11-27 @ 14:50
Location: Fryslan

Doxbox with Turkish keywords

Postby knowen » 2007-7-18 @ 16:31

hi all

i have a big problem about dos based prog. name is eta

it is working on win9x but we upgrade the system winxp pro sp2 and now eta is not working when i open the program i get ntvdm cpu error message and later program is closing

now i am working with dosbox v.70 it is working but i cant use turkish keywords (ş,ü,ö)

i searched the language file turkish.lng but i couldnt found

how i can resolve this problem ??

thanks a lot forums members
knowen
Newbie
 
Posts: 7
Joined: 2007-7-18 @ 16:18

Re: Enable CON to handle DBCS characters

Postby bugs_bugger » 2007-7-18 @ 17:23

You have to load codepage 857 to get an s with cedilla.
bugs_bugger
Member
 
Posts: 127
Joined: 2006-1-23 @ 15:11
Location: Germany

Re: Enable CON to handle DBCS characters

Postby wd » 2007-7-18 @ 20:29

Be aware that in filenames special characters are NOT allowed
or translated to the host code page.
wd
DOSBox Author
 
Posts: 10818
Joined: 2003-12-03 @ 21:23

Re: Enable CON to handle DBCS characters

Postby knowen » 2007-7-18 @ 20:30

i have to but how

i search the cedilla and find only windows versiyon i need a dos versiyon

thanks
knowen
Newbie
 
Posts: 7
Joined: 2007-7-18 @ 16:18

Re: Enable CON to handle DBCS characters

Postby knowen » 2007-7-18 @ 20:58

for example z:\>mount f c:\eta and program is openin but the turkish char. is missing (ü,ç) dosbox codepage according to us not turkey

how can i

thanks
knowen
Newbie
 
Posts: 7
Joined: 2007-7-18 @ 16:18

Next

Return to DOSBox Patches

Who is online

Users browsing this forum: unsure and 2 guests