VOGONS


First post, by h-a-l-9000

User metadata
Rank DOSBox Author
Rank
DOSBox Author

DOSBox doesn't set a new palette for M_LIN4 graphics modes. The bug might not have surfaced yet because the previous palette was identical.

Index: src/ints/int10_modes.cpp
===================================================================
RCS file: /cvsroot/dosbox/dosbox/src/ints/int10_modes.cpp,v
retrieving revision 1.61
diff -u -r1.61 int10_modes.cpp
--- src/ints/int10_modes.cpp 5 Jul 2007 19:36:53 -0000 1.61
+++ src/ints/int10_modes.cpp 24 Jul 2007 22:29:12 -0000
@@ -912,6 +912,7 @@
}
break;
}
+ case M_LIN4:
dac_text16:
for (i=0;i<64;i++) {
IO_Write(0x3c9,text_palette[i][0]);

Reply 1 of 3, by wd

User metadata
Rank DOSBox Author
Rank
DOSBox Author

lin4 is quite rare, but doesn't make much sense to omit the palette set.
Did you check univbe or some bios, or where did it occur?

Reply 2 of 3, by h-a-l-9000

User metadata
Rank DOSBox Author
Rank
DOSBox Author

I found this when fixing the ET4000 palette bug in Vasyls SVGA patch. Didn't really find anything that breaks but M_LIN4 seems not so uncommon with CAD software. I have one that uses M_LIN4 (video mode 6A) but doesn't break because the previos palette is correct. (It does break with ET4000 because the attrib palette pointers are wrong there - it's this sick greenish look).
I've looked at the palette the S3 BIOS sets in that case and it is identical with the text mode palette.

1+1=10

Reply 3 of 3, by wd

User metadata
Rank DOSBox Author
Rank
DOSBox Author

Ok thanks for the infos (and get some serious cad system 😉 ).