VOGONS


Problem with OS/2 port.

Topic actions

First post, by josch

User metadata
Rank Newbie
Rank
Newbie

Hi there.

I have taken up the work on the OS/2 port again. It now builds just fine, but I have one issue, on which I need some feedback:
In one OS/2 header is a typedef of LINE, which collides with the LINE value of the DrawMode enum in vga.h.
My solution to get it building was to drop the OS/2 header in DOSBOX's include directory and rename the typedef.
That works, but makes me uneasy, because I would have to add this file to the repository.
The other (better?) solution would be to change the name of the enum value. The changes needed would be rather straightforward.
What's your opinion on that? Change the enum? If yes, what should be the new name?

Bye Jochen

Reply 1 of 2, by Qbix

User metadata
Rank DOSBox Author
Rank
DOSBox Author

DRAW_LINES or something like that ?

Water flows down the stream
How to ask questions the smart way!

Reply 2 of 2, by josch

User metadata
Rank Newbie
Rank
Newbie

When I find time, I will change that and send the patch to you.