VIDEO Patch for pixel-perfect scaling (SDL1)

Here you can discuss the development of patches.

Re: VIDEO Patch for pixel-perfect scaling (SDL1)

Postby Yesterplay80 » 2018-4-17 @ 08:24

Hey, Ant_222, I just wanted to let you know that your patch doesn't apply any longer to the current revision of DOSBox (r4095), it might even breka the changes introduced with it (more than 256 colors in opengl output). I (hopefully) was able to fix it in ECE by manually implementing the changes in the diff and by removing two more instances of the check that get newly set at another point, effectively breaking the changes made before (see PP3.jpg).
PP1.JPG

PP2.JPG

PP3.JPG
You do not have the required permissions to view the files attached to this post.
My full-featured DOSBox SVN builds (without debugger) for Windows: Vanilla DOSBox and DOSBox ECE (Enhanced Community Edition)
User avatar
Yesterplay80
Member
 
Posts: 309
Joined: 2016-2-23 @ 11:02
Location: Germany

Re: VIDEO Patch for pixel-perfect scaling (SDL1)

Postby Ant_222 » 2018-4-17 @ 12:15

Thanks a lot, Yesterplay80. Can you please clarify what you did. In the first image I see unpatched code. The current SVN version is to the left and your modification to the right? Is the same true of the second image?

The third image shows some changes to the patched code. What is on the left and what is on the right?

When I have time, I will examine those changes and will try to add them to the patch.
Ant_222
Member
 
Posts: 355
Joined: 2010-7-24 @ 21:29

Re: VIDEO Patch for pixel-perfect scaling (SDL1)

Postby Yesterplay80 » 2018-4-17 @ 14:56

On the left, marked in red, is always your latest patch (adapted to ECE, so the line numbers might differ). The first two images on the right show, marked in green, the changes that were required to make it applicable (again, with ECE) again, the third image shows the changes I made to re-enable the support for more than 256 colors in OpenGL output, which the latest revision added.
My full-featured DOSBox SVN builds (without debugger) for Windows: Vanilla DOSBox and DOSBox ECE (Enhanced Community Edition)
User avatar
Yesterplay80
Member
 
Posts: 309
Joined: 2016-2-23 @ 11:02
Location: Germany

Re: VIDEO Patch for pixel-perfect scaling (SDL1)

Postby Ant_222 » 2018-4-17 @ 21:40

I think your changes are correct and should not break anything. Please test, however, the attached modification. I cannot currently upload it to the title post because of a problem with this forum.
You do not have the required permissions to view the files attached to this post.
Ant_222
Member
 
Posts: 355
Joined: 2010-7-24 @ 21:29

Re: VIDEO Patch for pixel-perfect scaling (SDL1)

Postby Ant_222 » 2018-4-17 @ 21:41

Sorry, wrong attachment. The correct one is here.
You do not have the required permissions to view the files attached to this post.
Ant_222
Member
 
Posts: 355
Joined: 2010-7-24 @ 21:29

Re: VIDEO Patch for pixel-perfect scaling (SDL1)

Postby Yesterplay80 » 2018-4-19 @ 06:53

Thanks, I will try the patch with the next DOSBox revision!
My full-featured DOSBox SVN builds (without debugger) for Windows: Vanilla DOSBox and DOSBox ECE (Enhanced Community Edition)
User avatar
Yesterplay80
Member
 
Posts: 309
Joined: 2016-2-23 @ 11:02
Location: Germany

Re: VIDEO Patch for pixel-perfect scaling (SDL1)

Postby Ant_222 » 2018-4-19 @ 19:31

To whomever it may concern: the diff between r4094 and r4095 has this change:
Code: Select all
--- src/gui/sdlmain.cpp   (revision 4094)
+++ src/gui/sdlmain.cpp   (revision 4095)
@@ -414,6 +414,8 @@
       goto check_gotbpp;
 #endif
    case SCREEN_OVERLAY:
+      //We only accept 32bit output from the scalers here
+      //Can't handle true color inputs
       if (flags & GFX_RGBONLY || !(flags&GFX_CAN_32)) goto check_surface;
       flags|=GFX_SCALING;
       flags&=~(GFX_CAN_8|GFX_CAN_15|GFX_CAN_16);
That is, in spite of the comment, the test of was not made more rigorous.
Ant_222
Member
 
Posts: 355
Joined: 2010-7-24 @ 21:29

Re: VIDEO Patch for pixel-perfect scaling (SDL1)

Postby Serious Callers Only » 2018-4-19 @ 21:01

The complete change is less rigorous (for opengl output), not overlay:
https://bazaar.launchpad.net/~i30817/do ... ision/3998
Serious Callers Only
Member
 
Posts: 369
Joined: 2003-4-26 @ 21:34

Re: VIDEO Patch for pixel-perfect scaling (SDL1)

Postby Yesterplay80 » 2018-7-13 @ 17:46

I don't know if Ant_222 is active here any more, however: The latest revision r4132 breaks his patch, but that's easily fixed. Et voilà!
pp15b.diff
You do not have the required permissions to view the files attached to this post.
My full-featured DOSBox SVN builds (without debugger) for Windows: Vanilla DOSBox and DOSBox ECE (Enhanced Community Edition)
User avatar
Yesterplay80
Member
 
Posts: 309
Joined: 2016-2-23 @ 11:02
Location: Germany

Re: VIDEO Patch for pixel-perfect scaling (SDL1)

Postby Ant_222 » 2018-7-14 @ 09:13

Yesterplay80 wrote:I don't know if Ant_222 is active here any more, however: The latest revision r4132 breaks his patch, but that's easily fixed. Et voilà!
pp15b.diff
Thanks for the notification, Yesterplay80. I am going on vacation tomorrow, but I will try to fix it upon return.

Edit: What is the easiest way to update a patch according to incompatible changes in the source? My procedure is tedious: check which places are broken, take the last successfully patched version, and manually implement in it the changes from the SVN.
Ant_222
Member
 
Posts: 355
Joined: 2010-7-24 @ 21:29

Re: VIDEO Patch for pixel-perfect scaling (SDL1)

Postby Yesterplay80 » 2018-7-15 @ 07:02

Ne need to try, the diff I posted already is the fixed version. Have fun in your vacations!
My full-featured DOSBox SVN builds (without debugger) for Windows: Vanilla DOSBox and DOSBox ECE (Enhanced Community Edition)
User avatar
Yesterplay80
Member
 
Posts: 309
Joined: 2016-2-23 @ 11:02
Location: Germany

Re: VIDEO Patch for pixel-perfect scaling (SDL1)

Postby Ant_222 » 2018-7-15 @ 09:33

Thank you kindly. I have added your patch to the title post as pixel-perfect-alpha14-4132.patch.zip .
Ant_222
Member
 
Posts: 355
Joined: 2010-7-24 @ 21:29

Previous

Return to DOSBox Patches

Who is online

Users browsing this forum: No registered users and 1 guest