Dosbox SVN r4019 + savestates Build (Alpha)

Here you can discuss the development of patches.

Re: Dosbox SVN r4019 + savestates Build (Alpha)

Postby gandhig » 2018-10-19 @ 08:51

SedrynTyros wrote:I took a shot at updating the bruenor patch with work with 4168, but had to give up after several hours of fiddling with it. The merging of the MAMEsound branch into the trunk in r4075 made massive changes to the way the sound is setup. Reworking the save state patch to work with the new design is well beyond my capabilities.


Recently I came out of the music phase I was in for the past 6 months or so.

Give me some time to recall and jump into the phase I was...when I left.

BTW, nice to see that there is still interest.

Edit (20/10/18): Thanks for your efforts, SedrynTyros. Glad to know about your possible success so far and if you upload your patch for SVN r4074, that would definitely give me a good head start. Just seeing the SVN Log History of 6 pages of commits was daunting by itself. Also, requesting to not expect much due to the usual reason mentioned countless times in this thread. Ok, one small step at a time...
Last edited by gandhig on 2018-10-20 @ 13:05, edited 2 times in total.
User avatar
gandhig
Member
 
Posts: 367
Joined: 2014-2-12 @ 08:35
Location: Unknown...yet. Triangulating inside...

Re: Dosbox SVN r4019 + savestates Build (Alpha)

Postby gandhig » 2018-10-19 @ 09:06

Kerr Avon wrote:The brilliant Spectrum emulator for the PSP, FUSE PSP, saves it's save states with a screenshot included, and when you go to the load/save screenshot page, it shows you the ten save slots, with each slot showing the screen shot if there is a save state in that slot, as two rows of five, and then you move to the slot you wish to load or save to, and press the correct button to load or to delete or to save the save state into the selected slot (you can of course save over an existing save-game if you choose).

Also, slot ten is special, in that it's an auto-load slot, so that if you load the game then if there's a saved snapshot in slot 10 then it's automatically loaded after the game is loaded. You can disable this if you like, but this might be a nice addition to DOSBOx, I think. Maybe with a "There is a save-state in the autoload slot for this game, would you like to load it now [Y]es/[N]o" message appearing after the game is first loaded.


I started this originally as a study project which later turned into a hobby. My knowledge of coding is very limited. Since the priority is to adapt this patch w.r.t updates in the main code branch, please allow me to put your 'Need for Feature' into the pending list.

Thanks.
User avatar
gandhig
Member
 
Posts: 367
Joined: 2014-2-12 @ 08:35
Location: Unknown...yet. Triangulating inside...

Re: Dosbox SVN r4019 + savestates Build (Alpha)

Postby SedrynTyros » 2018-10-19 @ 15:46

gandhig wrote:
SedrynTyros wrote:I took a shot at updating the bruenor patch with work with 4168, but had to give up after several hours of fiddling with it. The merging of the MAMEsound branch into the trunk in r4075 made massive changes to the way the sound is setup. Reworking the save state patch to work with the new design is well beyond my capabilities.


Recently I came out of the music phase I was in for the past 6 months or so.

Give me some time to recall and jump into the phase I was...when I left.

BTW, nice to see that there is still interest.


Oh yeah, definitely still interested in having a save states patch compatible with current DOSBox builds! I have a feeling the DOSBox devs are done with making major changes to the code pending the upcoming 0.75 release, so if you or bruenor can figure out how to modify the save state code to be compatible with the Gameblaster and Tandy changes and produce a patch we're probably be good to go for the foreseeable future. And thanks again for all the work you guys have done on this!

EDIT:

I was able to clean up the r4019 patch to work with r4074. I'll do some more testing to see if it actually works with games, but initial results look good. If I can find the time to confirm it works I'll upload the patch here.
User avatar
SedrynTyros
Member
 
Posts: 107
Joined: 2012-7-24 @ 21:44

Re: Dosbox SVN r4019 + savestates Build (Alpha)

Postby SedrynTyros » 2018-10-21 @ 21:26

I've attached the modified patch that applies cleanly to DOSBox r4074 named "bruenor41_savestate_r4074_win32_mingw_v2_st-update.patch". The patch is based on "bruenor41_savestate_r4019_win32_mingw.patch" but also includes the fix for raiden that bruenor41 posted here:

viewtopic.php?f=41&t=53116&start=40#p633198

I've tested a few games and Save States seem to work correctly. I don't really have time for extensive testing right now, but I've attached "DOSBox-SVN-r4074-with-Save-States.rar" which is the basic DOSBox build I compiled for testing if somebody else wants to play around with it.
You do not have the required permissions to view the files attached to this post.
User avatar
SedrynTyros
Member
 
Posts: 107
Joined: 2012-7-24 @ 21:44

Re: Dosbox SVN r4019 + savestates Build (Alpha)

Postby gandhig » 2018-10-25 @ 15:07

SedrynTyros wrote:I've attached the modified patch that applies cleanly to DOSBox r4074 named "bruenor41_savestate_r4074_win32_mingw_v2_st-update.patch". The patch is based on "bruenor41_savestate_r4019_win32_mingw.patch" but also includes the fix for raiden that bruenor41 posted here:

viewtopic.php?f=41&t=53116&start=40#p633198

I've tested a few games and Save States seem to work correctly. I don't really have time for extensive testing right now, but I've attached "DOSBox-SVN-r4074-with-Save-States.rar" which is the basic DOSBox build I compiled for testing if somebody else wants to play around with it.


Yep, works fine at my end too :cool: .

I will be able to work on this during the weekends only and since there is quite a lot to catch up, please bear with me. Also, I will be intermittently switching between this and DOSBox compilation guides(if DosFreak becomes active on that).
User avatar
gandhig
Member
 
Posts: 367
Joined: 2014-2-12 @ 08:35
Location: Unknown...yet. Triangulating inside...

Re: Dosbox SVN r4019 + savestates Build (Alpha)

Postby DosFreak » 2018-10-25 @ 15:20

That's the plan, I'm just slow. Trying to debug this xorg mouse issue right now. I'm sure it's something small I'm just ignorant. :)
User avatar
DosFreak
l33t++
 
Posts: 9935
Joined: 2002-6-30 @ 16:35
Location: Your Head

Re: Dosbox SVN r4019 + savestates Build (Alpha)

Postby gandhig » 2018-10-25 @ 15:56

Well, I recently upgraded to Ubuntu 18.04 LTS, but the Xorg version is 1.19.6. I'm probably more ignorant than you :dead: , still, I will check out this weekend,
User avatar
gandhig
Member
 
Posts: 367
Joined: 2014-2-12 @ 08:35
Location: Unknown...yet. Triangulating inside...

Re: Dosbox SVN r4019 + savestates Build (Alpha)

Postby DosFreak » 2018-10-25 @ 17:01

18.04 w/ Xorg 1.19.6 is fine. Xorg 1.20.x exhibits the issue: (comes with Ubuntu 18.10): viewtopic.php?f=31&t=62703&hilit=xorg
User avatar
DosFreak
l33t++
 
Posts: 9935
Joined: 2002-6-30 @ 16:35
Location: Your Head

Re: Dosbox SVN r4019 + savestates Build (Alpha)

Postby SedrynTyros » 2018-10-26 @ 15:56

gandhig wrote:
SedrynTyros wrote:I've attached the modified patch that applies cleanly to DOSBox r4074 named "bruenor41_savestate_r4074_win32_mingw_v2_st-update.patch". The patch is based on "bruenor41_savestate_r4019_win32_mingw.patch" but also includes the fix for raiden that bruenor41 posted here:

viewtopic.php?f=41&t=53116&start=40#p633198

I've tested a few games and Save States seem to work correctly. I don't really have time for extensive testing right now, but I've attached "DOSBox-SVN-r4074-with-Save-States.rar" which is the basic DOSBox build I compiled for testing if somebody else wants to play around with it.


Yep, works fine at my end too :cool: .

I will be able to work on this during the weekends only and since there is quite a lot to catch up, please bear with me. Also, I will be intermittently switching between this and DOSBox compilation guides(if DosFreak becomes active on that).


Hey, no worries. I really appreciate the work you and bruenor41 have done so far.
User avatar
SedrynTyros
Member
 
Posts: 107
Joined: 2012-7-24 @ 21:44

Re: Dosbox SVN r4019 + savestates Build (Alpha)

Postby bruenor41 » 2018-10-30 @ 20:56

If I remember well, when mame core appeared in dosbox branch, there was code for save/load states, but was removed during implementation. Find it would be useful, or maybe save states can be updated to latest svn without support for mame core. I want look at this later, just now I am very busy at work.
bruenor41
Newbie
 
Posts: 17
Joined: 2013-4-22 @ 08:58

Re: Dosbox SVN r4019 + savestates Build (Alpha)

Postby gandhig » 2018-10-31 @ 15:06

Welcome bruenor41! Take your time, no hurry. Meanwhile, warm-up process is underway at this end due to a rusty feel w.r.t dosbox and coding. Hoping to start from this weekend.
User avatar
gandhig
Member
 
Posts: 367
Joined: 2014-2-12 @ 08:35
Location: Unknown...yet. Triangulating inside...

Previous

Return to DOSBox Patches

Who is online

Users browsing this forum: No registered users and 1 guest