normal4x, normal5x, one day ?

Developer's Forum, for discussion of bugs, code, and other developmental aspects of DOSBox.

normal4x, normal5x, one day ?

Postby Dfg11333 » 2013-4-11 @ 21:17

Hi,

I'm using dosbox to play many games and I love it ! However, I struggle quite a lot to have screen resolutions ok for all my games.

Playing with scalers, I googled to see if a normal4x would be available on dosbox on newer versions but I didn't find any positive answer. Did I miss something ?

I found on the forum a couple of threads with attached patches to add the normal4x mode. All threads are quite ridiculous to read a couple of years after (discussion from "who on earth would have a screen resolution higher than 1024x768" to "I closed this thread because someone said something idiot").

I even found a tutorial on "how to patch yourself your dosbox to have normal4x" ( http://ashton-lockey.blogspot.fr/2012/0 ... eater.html ).

At this point, it's just getting ridiculous. It doesn't seem to be a technical problem (the patch seems just trivial and there were many proposed). I don't think anyone would deny that many people today have 1920x1080 screens, which makes the point for 4x or 5x modes. And we know that tomorrow will see bigger resolution screens.

So, can someone explain what's going wrong with this request ?
Dfg11333
Newbie
 
Posts: 3
Joined: 2013-4-11 @ 21:04

Re: normal4x, normal5x, one day ?

Postby Great Hierophant » 2013-4-12 @ 01:26

The blog post you link to has already done all the hard work. I will try adding these code changes and try to make a .diff file.
Last edited by Great Hierophant on 2013-4-12 @ 02:35, edited 1 time in total.
http://nerdlypleasures.blogspot.com/ - Nerdly Pleasures - My Retro Gaming, Computing & Tech Blog
User avatar
Great Hierophant
l33t
 
Posts: 2398
Joined: 2003-4-27 @ 08:20

Re: normal4x, normal5x, one day ?

Postby Hater Depot » 2013-4-12 @ 02:14

Is there an advantage to using a normal4x scaler rather than setting fullresolution or windowresolution to 1280x960?
Korea Beat -- my cool translation blog.
Hater Depot
Member
 
Posts: 277
Joined: 2007-10-03 @ 05:08

Re: normal4x, normal5x, one day ?

Postby Great Hierophant » 2013-4-12 @ 02:35

I have attached a DOSBox based on r3827 with a working normal4x, normal5x and normal6x. Compiled on Microsoft Visual C++ 2008 Express Edition using the wiki's instructions. If someone could tell me how to make a diff file, I would appreciate it because I really do not want to have to figure out and type all that code again.

I have a 1920x1200 screen, so normal6x is useful. However, the normal?x scalers only work with 320-type resolutions. 80-column text modes will not be scaled.
Attachments
dosbox.exe
(2.11 MiB) Downloaded 316 times
http://nerdlypleasures.blogspot.com/ - Nerdly Pleasures - My Retro Gaming, Computing & Tech Blog
User avatar
Great Hierophant
l33t
 
Posts: 2398
Joined: 2003-4-27 @ 08:20

Re: normal4x, normal5x, one day ?

Postby VileRancour » 2013-4-12 @ 03:32

Nice! This has been in my DOSBox wish list too, I was just unaware that somebody has already done the dirty work, and too plain lazy to tackle it myself. ;)

Great Hierophant wrote:I have attached a DOSBox based on r3827 with a working normal4x, normal5x and normal6x. Compiled on Microsoft Visual C++ 2008 Express Edition using the wiki's instructions.

Excellent, seems to work exactly as intended - I can't quite test 5x and 6x in fullscreen as my native resolution isn't big enough, but forcing them in a window works fine.

If someone could tell me how to make a diff file, I would appreciate it because I really do not want to have to figure out and type all that code again.

Grab the win32 binaries for diffutils and see the options for 'diff'. From memory this should do the trick:
diff -ubr [svn_source_dir] [patched_source_dir] > patch.diff

I have a 1920x1200 screen, so normal6x is useful. However, the normal?x scalers only work with 320-type resolutions. 80-column text modes will not be scaled.

640x* modes do get scaled if you append 'forced'. In fact, using "scaler=normal4x forced" in fullscreen gives me the best possible results with this patch (I use a pair of 1280x1024 panels, so with normal4x I get crisp scaling for both 320- and 640-column modes).
web  /   blog   /   tube
User avatar
VileRancour
Oldbie
 
Posts: 1720
Joined: 2003-5-14 @ 22:11
Location: 1-01-80 0:00a

Re: normal4x, normal5x, one day ?

Postby Great Hierophant » 2013-4-12 @ 05:46

Here is the diff file, I hope I did it right.

I cannot code a line, but I can identify patterns and deduce the next logical result.

I prefer the openglnb output because it automatically can scale the image to the resolution indicated. So openglnb and fullscreen resolution of 1920x1200 gives me perfectly scaled graphics in 640 and 320 modes. In other words, it acts like normal3x with 640 modes and normal6x in 320 modes. There isn't a great solution for those oddball 720 and 360 modes.
Attachments
patch.diff
(54.65 KiB) Downloaded 171 times
http://nerdlypleasures.blogspot.com/ - Nerdly Pleasures - My Retro Gaming, Computing & Tech Blog
User avatar
Great Hierophant
l33t
 
Posts: 2398
Joined: 2003-4-27 @ 08:20

Re: normal4x, normal5x, one day ?

Postby VileRancour » 2013-4-12 @ 13:41

openglnb isn't always optimal, since in certain resolutions the pixel sizes would be uneven (especially with aspect=true), so higher factors for the normal scaler are very welcome indeed.

the diff looks like you swapped the two directories (or perhaps I swapped them in my example), since there are removals where there should be additions, and vice versa. Also, everything from line 297 onwards should probably be deleted as it's specific to Visual Studio (the visualc stuff plus winres.rc)... forgot to mention that.
web  /   blog   /   tube
User avatar
VileRancour
Oldbie
 
Posts: 1720
Joined: 2003-5-14 @ 22:11
Location: 1-01-80 0:00a

Re: normal4x, normal5x, one day ?

Postby Dfg11333 » 2013-4-12 @ 14:16

Actually, as stated in my original post, many patches have already been proposed (search on this forum there are a couple of patches, not counting the external link I provided).

Most of the patches have been written by non-experimented developers, which proves that this is trivial stuff.

So, the problem is not technical, it's only a matter of having a dosbox developer who has access to the source tree (and should therefore have enough skill to code that in 5 minutes) do it and commit it.
Dfg11333
Newbie
 
Posts: 3
Joined: 2013-4-11 @ 21:04

Re: normal4x, normal5x, one day ?

Postby Dfg11333 » 2013-4-12 @ 14:18

And yes, I know, in open-source projects, you don't say "I want this feature", you propose a patch for commit. But really, in this case, integrating the patch is more work than writing it.
Dfg11333
Newbie
 
Posts: 3
Joined: 2013-4-11 @ 21:04

Re: normal4x, normal5x, one day ?

Postby robertmo » 2013-4-12 @ 14:23

I think dosbox developers don't want people to use high normalnx scalers as they slow dosbox down. They encourage you to use hardware scalers. And hardware scalers are not perfect as that is difficult to achieve. And there are more important things to develop for dosbox and also there is not much development in dosbox at all.
User avatar
robertmo
l33t
 
Posts: 4750
Joined: 2003-6-18 @ 10:35

Re: normal4x, normal5x, one day ?

Postby VileRancour » 2013-4-12 @ 15:24

Dfg11333 wrote:But really, in this case, integrating the patch is more work than writing it.

...how's that specific to this case vs. any other patch though?

robertmo wrote:I think dosbox developers don't want people to use high normalnx scalers as they slow dosbox down.

As expected, normal6x seems to consume ~4 times more cpu power than normal3x, but in the *rare* case that this becomes a problem for a modern cpu we're all free to use something else...
Last edited by VileRancour on 2013-4-12 @ 15:29, edited 1 time in total.
web  /   blog   /   tube
User avatar
VileRancour
Oldbie
 
Posts: 1720
Joined: 2003-5-14 @ 22:11
Location: 1-01-80 0:00a

Re: normal4x, normal5x, one day ?

Postby robertmo » 2013-4-12 @ 15:27

ykhwong build gives you freedom of choice :)
User avatar
robertmo
l33t
 
Posts: 4750
Joined: 2003-6-18 @ 10:35

Re: normal4x, normal5x, one day ?

Postby Dominus » 2013-4-12 @ 15:33

In the case of scalers I still hope someone will do a scaler lib to easily integrate scalers in projects that use them (scummvm, dosbox, etc....)
User avatar
Dominus
DOSBox Moderator
 
Posts: 7968
Joined: 2002-10-03 @ 09:54
Location: Ludwigsburg


Return to DOSBox Development

Who is online

Users browsing this forum: No registered users and 2 guests