Build current SVN in macOS High Sierra?

Developer's Forum, for discussion of bugs, code, and other developmental aspects of DOSBox.

Build current SVN in macOS High Sierra?

Postby emendelson » 2017-12-14 @ 15:01

About a year ago, I put together a lot of work by Dominus and made a single build script for DOSBox SVN under macOS:

https://github.com/emendelson/OneStopDOSBoxOSX

I tried using it under High Sierra (with my existing build environment), and it produced this error from the make command:

Making all in serialport
nullmodem.cpp:151:21: error: ordered comparison between pointer and zero
('TCPClientSocket *' and 'int')
setCD(clientsocket > 0); // CD on if connection established
~~~~~~~~~~~~ ^ ~
1 error generated.
make[4]: *** [nullmodem.o] Error 1
make[4]: *** Waiting for unfinished jobs....
make[3]: *** [all-recursive] Error 1
make[2]: *** [all-recursive] Error 1
make[1]: *** [all-recursive] Error 1
make: *** [all] Error 2
-e **Error** line #597 : make failed.


Is this error the result of my ignorance (very likely), or has something changed in SVN that would cause this problem in macOS?

Any insights gratefully received.
emendelson
Oldbie
 
Posts: 746
Joined: 2010-2-14 @ 02:00

Re: Build current SVN in macOS High Sierra?

Postby ripsaw8080 » 2017-12-14 @ 15:30

Fussy compiler, I guess. Maybe it will like this instead: setCD(clientsocket != 0);

Edit: thinking about it, the compiler has a point, and my suggestion makes better sense.
User avatar
ripsaw8080
DOSBox Author
 
Posts: 4232
Joined: 2006-4-25 @ 23:24

Re: Build current SVN in macOS High Sierra?

Postby Dominus » 2017-12-14 @ 15:59

Curios, I've built current source correctly but then My target might be different
User avatar
Dominus
DOSBox Moderator
 
Posts: 7644
Joined: 2002-10-03 @ 09:54
Location: Ludwigsburg

Re: Build current SVN in macOS High Sierra?

Postby emendelson » 2017-12-14 @ 16:27

@Dominus - It's very curious. I'm using the "build static-linked DOSBox" part of my script - and it's entirely based on your suggestions...!

@ripsaw8080 - Your suggested edit fixes the problem (and at least I guessed in a vague way that something like that would fix it, but didn't know enough to put into effect). Thank you!
emendelson
Oldbie
 
Posts: 746
Joined: 2010-2-14 @ 02:00

Re: Build current SVN in macOS High Sierra?

Postby Qbix » 2017-12-14 @ 16:38

Sounds a bit like the opengl extension "fix", which sparked a patch to reverse it..
https://sourceforge.net/p/dosbox/code-0/4007
Compilers don't always seem to agree, but the fix seems fine to me.
Water flows down the stream
How to ask questions the smart way!
User avatar
Qbix
DOSBox Author
 
Posts: 10652
Joined: 2002-11-27 @ 14:50
Location: Fryslan


Return to DOSBox Development

Who is online

Users browsing this forum: Google Feedfetcher and 4 guests