VOGONS

Build current SVN in macOS High Sierra?

Topic actions

First post, by emendelson

Posted on 
User metadata
Rank Oldbie
Rank
Oldbie

About a year ago, I put together a lot of work by Dominus and made a single build script for DOSBox SVN under macOS:

https://github.com/emendelson/OneStopDOSBoxOSX

I tried using it under High Sierra (with my existing build environment), and it produced this error from the make command:

Making all in serialport nullmodem.cpp:151:21: error: ordered comparison between pointer and zero ('TCPClientSocket *' and […]
Show full quote

Making all in serialport
nullmodem.cpp:151:21: error: ordered comparison between pointer and zero
('TCPClientSocket *' and 'int')
setCD(clientsocket > 0); // CD on if connection established
~~~~~~~~~~~~ ^ ~
1 error generated.
make[4]: *** [nullmodem.o] Error 1
make[4]: *** Waiting for unfinished jobs....
make[3]: *** [all-recursive] Error 1
make[2]: *** [all-recursive] Error 1
make[1]: *** [all-recursive] Error 1
make: *** [all] Error 2
-e **Error** line #597 : make failed.

Is this error the result of my ignorance (very likely), or has something changed in SVN that would cause this problem in macOS?

Any insights gratefully received.

Reply 1 of 4, by ripsaw8080

Posted on 
User metadata
Rank DOSBox Author
Rank
DOSBox Author

Fussy compiler, I guess. Maybe it will like this instead: setCD(clientsocket != 0);

Edit: thinking about it, the compiler has a point, and my suggestion makes better sense.

Reply 3 of 4, by emendelson

Posted on 
User metadata
Rank Oldbie
Rank
Oldbie

@Dominus - It's very curious. I'm using the "build static-linked DOSBox" part of my script - and it's entirely based on your suggestions...!

@ripsaw8080 - Your suggested edit fixes the problem (and at least I guessed in a vague way that something like that would fix it, but didn't know enough to put into effect). Thank you!

Go to top of page Go to top of page
Back to DOSBox Development
Close window
Close window