Baron von Riedesel wrote on 2023-04-01, 16:00:
crazii wrote on 2023-04-01, 15:29:
@Baron von Riedesel, I think at least an open sourced repo will help diff the code. 😁
I have no problem with that. It's already on github, as a private repo. If you don't mind, I'll make it public..
However, I'm not sure that it will help - because my goal is to finally remove the Mpxplay part ( that code was never meant to be a "library", it's virtually uncommented and huge parts aren't needed for sbemu ). So I already removed and "adjusted" quite a bit of it - making it futile to run a simple diff between this code and yours.
OK, I didn't know that until now, I thought that there's no big difference between the two. Are you planning to open source eventually? if yes, then under what circumstances? that when MPXPlay is totally removed?
About the MPXPlay part, I agree that it is not a library, when porting & tailoring it to djgpp for SBEMU, I found some code coupling which gives me headache and I have to include files that are mostly not useful. But, it doesn't need to be a good portable library. I still preferred to keep it as "original" as possible, with minimal modifications, the bugfix can feed back to the original author of MPXPlay to make itself better, and he can easily cherry-pick the changes. it's a win-win situation. it's just what open sourced for, isn't it? That's why the macro "SBEMU" is used for MPXPlay, for most changes I'll guard the changes with the macro and keep the original code. That's the experience of a 15 years programmer - me.
I'm not trying to sell my coding philosophy, but MPXPlay now is working with low maintenance cost, I don't see any actual needs to reform it, adding comments won't hurt; the unused code is left there with some kilobytes extra XMS cost. it's not worth the effort. I'm in no position to persuade you, but I just don't understand, are you really, really sure to do that? to transform a third party code into your own, instead of making it better for both? that question can also apply to SBEMU, are you really want to make "another SBEMU", instead of helping making this one better? I'm more confused than ever.
Toshiba Satellite Pro 4300 - YMF744, Savage IX
Toshiba Satellite 2805-S501 - YMF754, GeForce 2Go
IBM Thinkpad A21p - CS4624, Mobility Radeon 128
main: Intel NUC11PHKi7C Phantom Canyon: i7-1165G7 RTX2060 64G 2T760PSDD