Hi almeath,

> The patch is meant to also work with standard (SDL1) DOSBox SVN?

It's bit-rotten since its last update here, but the work has found a home in DOSBox ECE, DOSBox-X, DOSBox Core, and DOSBox Staging.

For SVN, I'd suggest using the latest state of the patch used by ECE - it was last modified here: DOSBox ECE (for Windows & Linux)

> Also, if I am not needing to actually encode any CD audio into the respective formats, are there any baseline benefits to audio playback that are noticeable in standard DOSBox

Exactly; if you're only playing existing GoG (OGG Vorbis) encoded CD-DA tracks or mounting BIN/CUE's, then the extra codecs add no value.

> or is it just the underlying efficiency of the code that is improved?

Right; there was some mild refactoring done, but certainly nothing "make or break" in terms of performance.

Hope that helps!

--
Edit: added DOSBox-X; thanks for the reminder @Wengier!

krcroft wrote on 2021-04-04, 15:39:

Hope that helps!

It definitely does, thanks for the update.

krcroft wrote on 2021-04-04, 15:39:

It's bit-rotten since its last update here, but the work has found a home in ECE and Staging, like you've mentioned.

And it has found a home in DOSBox-X too (of course - thanks to your work). It is already supported by all major forks by now.

Is there a patch for Wing Commander Privateer and the ol OriginFX games?

i don't think no one at WCNews did that yet, it would be interesting to see GoG or stock Privateer with high quality ripped audio instead of MIDI soundtracks.

Deffnator wrote on 2021-07-24, 19:24:

it would be interesting to see GoG or stock Privateer with high quality ripped audio instead of MIDI soundtracks.

Hi Deffnator, I don't think Privateer's CDROM ever came with CDDA tracks; so your highest-quality option is to use MIDI with you favourite SoundFont.

krcroft wrote on 2021-07-24, 22:08:

Deffnator wrote on 2021-07-24, 19:24:

it would be interesting to see GoG or stock Privateer with high quality ripped audio instead of MIDI soundtracks.

Hi Deffnator, I don't think Privateer's CDROM ever came with CDDA tracks; so your highest-quality option is to use MIDI with you favourite SoundFont.

i know, but i was thinking here of the idea of dosbox replacing the MIDI soundtrack with CD/External files audio by wrapping using roland or Soundblaster with dosbox loading the external music with the game's midi filenames.
i came to think of it while looking Warcraft 1 DOS vs MAC ports.

Attached is "dosbox-svn-r4494_krcroft-audio patch.zip", a reworked version of krcroft's "dosbox-r4294_cdda-and-staging_v14.patch" from the first post of this thread.

This patch version applies cleanly to the vanilla DOSBox SVN r4494. There's a file included named "dosbox-svn-r4494_krcroft-audio - BUILD-MINGW32.txt" that details how to setup the MSYS2 MinGW32 environment to use the patch.

Also attached is "DOSBox SVN r4494 krcroft audio.zip", a DOSBox SVN r4494 with the krcroft audio patch build for those who just want to use it without dealing with building it themselves.

I've done minimal testing with the GOG release of "Dungeon Keeper Gold" but cue sheets with WAV/Ogg/MP3/Opus/Flac files all seemed to work fine. Cue sheet formatting should be as krcroft described in the first post:

FILE "data.iso" BINARY
TRACK 01 MODE1/2048
INDEX 01 00:00:00

FILE "track02.opus" OPUS
TRACK 02 AUDIO
PREGAP 00:02:00
INDEX 01 00:00:00

FILE "track03.flac" FLAC
TRACK 03 AUDIO
INDEX 01 00:00:00

FILE "track04.ogg" OGG
TRACK 04 AUDIO
INDEX 01 00:00:00

FILE "track05.mp3" MP3
TRACK 05 AUDIO
INDEX 01 00:00:00

FILE "track06.wav" WAVE
TRACK 06 AUDIO
INDEX 01 00:00:00

EDIT:

Full disclosure, I used ChatGPT 5.1 to do the heavy lifting here. While I'm a technical person, I'm not anywhere near well-versed enough in coding to revise anything as complex as what krcroft created. Hats off to him for all his hard work on this!

Small update to fix an issue with "MIXER: Got different values from SDL: freq 44100, blocksize 1024" incorrectly being disabled in the DOSBox console. The old patch and old dosbox.exe with this error have been appended with "-beta"