VOGONS


Get Rid of Warnings...

Topic actions

First post, by DoomWarrior

User metadata
Rank Newbie
Rank
Newbie

hi

to make it short, i have warnings 😳 , so i 'fixed' some in cmopl.c
i attached the diff. If this is ok, i will fix the other in ymf262.c too 😀

bye

Reply 1 of 6, by HunterZ

User metadata
Rank l33t++
Rank
l33t++

What warnings?

Qbix (or anyone else who knows): Are the warnings invalid?

Reply 2 of 6, by gulikoza

User metadata
Rank Oldbie
Rank
Oldbie

There's already a patch for this by Moe on sourceforge (and it makes adlib more cpu cache friendly as far as I've understood it)

Reply 3 of 6, by almightyjustin

User metadata
Rank Newbie
Rank
Newbie

As I said on SourceForge, the FM code is from the MAME project, so if you have any patches, it's better to submit them directly to MAMEDEV (instructions are at http://mamedev.com/ ) and then get DosBox to re-sync to MAME's new version. That way MAME and all the other projects that use the same code (like AdPlug) can benefit from your changes.

Swim, swim, hungry! Stupid fish.

Reply 4 of 6, by DoomWarrior

User metadata
Rank Newbie
Rank
Newbie

@almightyjustin: to who do you taking ? to gulikoza or me ?

Reply 5 of 6, by HunterZ

User metadata
Rank l33t++
Rank
l33t++

You and Moe probably, and anyone else who makes changes to the MAME-derived OPL emulation code.

I should mention that the current official MAME version of that code is different from the current DOSBox version. I don't know enough about how the OPL code or DOSBox work to be able to determine whether or not it's worth merging the changes into DOSBox (and I definitely don't know how to go about it). Someone more knowledgable may want to look into it, however.

If anyone wants to look at it, the latest stable version of the source is here: http://www.mame.net/downmain.html
Patches to the latest development snapshot are here: http://mamedev.com/source.html

I looked but couldn't find a public CVS archive.

Reply 6 of 6, by almightyjustin

User metadata
Rank Newbie
Rank
Newbie

Yeah, unfortunately it looks like there have been some changes on both the DosBox and MAME sides, so it could be tricky to sync up again.

MAMEDEV doesn't use CVS, they send patches to a private mailing list and use the development releases to keep in sync.

Swim, swim, hungry! Stupid fish.