VOGONS


VIDEO Patch for pixel-perfect scaling (SDL1)

Topic actions

Reply 280 of 733, by Ant_222

User metadata
Rank Oldbie
Rank
Oldbie
KainXVIII wrote:

And here is with windowresolution=desktop (maybe it helps)

Thank you. I have narrowed-down the location of the bug to two places. The attached .exe with further logging will show where it is exactly. Please, test again.

Reply 281 of 733, by KainXVIII

User metadata
Rank Oldbie
Rank
Oldbie

This new version hangs when entered windowed mode in KoX, so results maybe not very accurate, but here is what i managed to capture

Reply 282 of 733, by Ant_222

User metadata
Rank Oldbie
Rank
Oldbie
KainXVIII wrote:

This new version hangs when entered windowed mode in KoX, so results maybe not very accurate, but here is what i managed to capture

Should work now. Does it? Please, post the log either way.

Reply 283 of 733, by KainXVIII

User metadata
Rank Oldbie
Rank
Oldbie
Ant_222 wrote:
KainXVIII wrote:

This new version hangs when entered windowed mode in KoX, so results maybe not very accurate, but here is what i managed to capture

Should work now. Does it? Please, post the log either way.

Yep, it works now, thanks! 😀 So, what was wrong?

Reply 284 of 733, by Ant_222

User metadata
Rank Oldbie
Rank
Oldbie
KainXVIII wrote:

Yep, it works now, thanks! :happy: So, what was wrong?

I will soon upload a fixed patch. What I don't understand is why at your side the aspect ratio of the source image is sometimes reported as 1.17 instead of the correct 1.20, whereas at my side it is always 1.20. Can you please upload your full config file so that I may reproduce this latter behaviour?

Reply 285 of 733, by KainXVIII

User metadata
Rank Oldbie
Rank
Oldbie
Ant_222 wrote:
KainXVIII wrote:

Yep, it works now, thanks! 😀 So, what was wrong?

I will soon upload a fixed patch. What I don't understand is why at your side the aspect ratio of the source image is sometimes reported as 1.17 instead of the correct 1.20, whereas at my side it is always 1.20. Can you please upload your full config file so that I may reproduce this latter behaviour?

Here you go
http://rgho.st/8xTNkyR9q

Reply 286 of 733, by Ant_222

User metadata
Rank Oldbie
Rank
Oldbie
KainXVIII wrote:
Ant_222 wrote:

What I don't understand is why at your side the aspect ratio of the source image is sometimes reported as 1.17 instead of the correct 1.20, whereas at my side it is always 1.20. Can you please upload your full config file so that I may reproduce this latter behaviour?

Here you go
http://rgho.st/8xTNkyR9q

Thank you. I do not observe this with Knights of Xentar. 1.17 may be 7/6, but why... I take this from DOXBox without any calculations.

Reply 287 of 733, by KainXVIII

User metadata
Rank Oldbie
Rank
Oldbie
Ant_222 wrote:
KainXVIII wrote:
Ant_222 wrote:

What I don't understand is why at your side the aspect ratio of the source image is sometimes reported as 1.17 instead of the correct 1.20, whereas at my side it is always 1.20. Can you please upload your full config file so that I may reproduce this latter behaviour?

Here you go
http://rgho.st/8xTNkyR9q

Thank you. I do not observe this with Knights of Xentar. 1.17 may be 7/6, but why... I take this from DOXBox without any calculations.

As i remember you don't have 1080p monitor?

Reply 288 of 733, by Ant_222

User metadata
Rank Oldbie
Rank
Oldbie
KainXVIII wrote:

As i remember you don't have 1080p monitor?

No. Mine is a 1050p one.

Reply 289 of 733, by KainXVIII

User metadata
Rank Oldbie
Rank
Oldbie
Ant_222 wrote:
KainXVIII wrote:

As i remember you don't have 1080p monitor?

No. Mine is a 1050p one.

Maybe this matters if game works fine for you 😀

Reply 290 of 733, by Ant_222

User metadata
Rank Oldbie
Rank
Oldbie
KainXVIII wrote:
Ant_222 wrote:
KainXVIII wrote:

As i remember you don't have 1080p monitor?

No. Mine is a 1050p one.

Maybe this matters if game works fine for you :happy:

Hardly possible. If you will help me with testing, I will find its cause via logging.

I have just uploaded the 12th alpha of the patch, which would have been impossible without your help. It fixes the crash with Knights of Xentar.

Reply 291 of 733, by Yesterplay80

User metadata
Rank Oldbie
Rank
Oldbie

DOSBox ECE is updated with Alpha 12 of your build.

My full-featured DOSBox SVN builds for Windows & Linux: Vanilla DOSBox and DOSBox ECE (Google Drive Mirror)

Reply 292 of 733, by KainXVIII

User metadata
Rank Oldbie
Rank
Oldbie

We will find this bug! 😎
Here is another interesting results (just testing) of game Rusty
Intro fills nearly entire 1080p widescreen monitor with surfacepp output, because of its unusual resolution (640x291?), looks crazy and cool, i wonder what other (japanese?) games use it..
Also ingame fullscreen aspect ratio looks slightly different than in windowed mode (or is it just me?)

The attachment rusty.png is no longer available
The attachment rusty1.png is no longer available
The attachment rusty2.png is no longer available
The attachment rusty3.png is no longer available

Reply 293 of 733, by Ant_222

User metadata
Rank Oldbie
Rank
Oldbie

marooned_on_mars, please check if the incompatibility with munt is fixed in the alpha 12.

Reply 294 of 733, by Ant_222

User metadata
Rank Oldbie
Rank
Oldbie
KainXVIII wrote:

We will find this bug! :cool:

OK—await more builds with additional logging.

Here is another interesting results (just testing) of game Rusty
Intro fills nearly entire 1080p widescreen monitor with surfacepp output, because of its unusual resolution (640x291?),

I think so.

Also ingame fullscreen aspect ratio looks slightly different than in windowed mode (or is it just me?)

It is different indeed. I will check why this happens.

Edit:The explanation is in the console output. The in-game PAR is 2.40, which requires at least 2x5 upscaling, whereas in windowed mode with

windowresolution=original

my patch may upscale but one dimension, so only 1x2 is possible. In fullscreen, however, the upscaling is ideal. Try setting

windowresolution=desktop

or any fixed dimensions that are large enough, e.g.:

windowresolution=1600x1000

Reply 295 of 733, by marooned_on_mars

User metadata
Rank Member
Rank
Member

Sorry, ATM I don't have the time or the resources (my own PC) to test the patch. Will do so in a month or so.

Reply 296 of 733, by Ant_222

User metadata
Rank Oldbie
Rank
Oldbie
marooned_on_mars wrote:

Sorry, ATM I don't have the time or the resources (my own PC) to test the patch. Will do so in a month or so.

OK. As I remember, the only conflict was in the makefile for gui\, which I fixed.

Reply 297 of 733, by Ant_222

User metadata
Rank Oldbie
Rank
Oldbie
Ant_222 wrote:
KainXVIII wrote:

We will find this bug! :cool:

OK—await more builds with additional logging.

KainXVIII, please, test KoX with the attached .exe and show me the console output.

Reply 298 of 733, by KainXVIII

User metadata
Rank Oldbie
Rank
Oldbie
Ant_222 wrote:
Ant_222 wrote:
KainXVIII wrote:

We will find this bug! 😎

OK—await more builds with additional logging.

KainXVIII, please, test KoX with the attached .exe and show me the console output.

Something new?
Before KoX there were Norton Commander loaded.

Reply 299 of 733, by Ant_222

User metadata
Rank Oldbie
Rank
Oldbie
KainXVIII wrote:

Something new?

Yes, it looks as though DOSBox's VGA emulator gives me this PAR of 1.169, and my patch has nothing to do with it. I will add the same logging to a clean SVN version and check again, ok? If my suspicions be confirmed, I shall ask the core developers.