Compilation errors in cpu.cpp on 0.74 \ VOGONS

Compilation errors in cpu.cpp on 0.74

Topic actions

First post, by xjas

Posted on 2017-09-21, 18:45

xjas Offline

Rank l33t

Rank: l33t
Posts: 2564
Joined: 2015-09-07, 02:29

I'm trying to compile DOSBox 0.74 with this patch applied (the final update posted on page 3.) I'm using the version of the source straight off dosbox.com/downloads. I get a ton of errors, mostly in cpu.cpp, but also dos_inc.h. Neither of those files are altered by the patch BTW.

1make
2make  all-recursive
3make[1]: Entering directory '/home/jay/Downloads/dosbox-0.74'
4Making all in src
5make[2]: Entering directory '/home/jay/Downloads/dosbox-0.74/src'
6Making all in cpu
7make[3]: Entering directory '/home/jay/Downloads/dosbox-0.74/src/cpu'
8Making all in core_full
9make[4]: Entering directory '/home/jay/Downloads/dosbox-0.74/src/cpu/core_full'
10make[4]: Nothing to be done for 'all'.
11make[4]: Leaving directory '/home/jay/Downloads/dosbox-0.74/src/cpu/core_full'
12Making all in core_normal
13make[4]: Entering directory '/home/jay/Downloads/dosbox-0.74/src/cpu/core_normal'
14make[4]: Nothing to be done for 'all'.
15make[4]: Leaving directory '/home/jay/Downloads/dosbox-0.74/src/cpu/core_normal'
16Making all in core_dyn_x86
17make[4]: Entering directory '/home/jay/Downloads/dosbox-0.74/src/cpu/core_dyn_x86'
18make[4]: Nothing to be done for 'all'.
19make[4]: Leaving directory '/home/jay/Downloads/dosbox-0.74/src/cpu/core_dyn_x86'
20Making all in core_dynrec
21make[4]: Entering directory '/home/jay/Downloads/dosbox-0.74/src/cpu/core_dynrec'
22make[4]: Nothing to be done for 'all'.
23make[4]: Leaving directory '/home/jay/Downloads/dosbox-0.74/src/cpu/core_dynrec'
24make[4]: Entering directory '/home/jay/Downloads/dosbox-0.74/src/cpu'
25g++ -DHAVE_CONFIG_H -I. -I../..  -I../../include -I/usr/include/SDL -D_GNU_SOURCE=1 -D_REENTRANT  -g -O2  -MT callback.o -MD -MP -MF .deps/callback.Tpo -c -o callback.o callback.cpp
26callback.cpp: In function ‘Bitu CALLBACK_SetupExtra(Bitu, Bitu, PhysPt, bool)’:
27callback.cpp:435:47: warning: format ‘%d’ expects argument of type ‘int’, but argument 2 has type ‘Bitu {aka long unsigned int}’ [-Wformat=]
28   E_Exit("CALLBACK:Setup:Illegal type %d",type);
29                                               ^
30mv -f .deps/callback.Tpo .deps/callback.Po
31g++ -DHAVE_CONFIG_H -I. -I../..  -I../../include -I/usr/include/SDL -D_GNU_SOURCE=1 -D_REENTRANT  -g -O2  -MT cpu.o -MD -MP -MF .deps/cpu.Tpo -c -o cpu.o cpu.cpp
32In file included from ../../include/programs.h:28:0,
33                 from cpu.cpp:29:
34../../include/dos_inc.h: In member function ‘void DOS_MCB::SetFileName(const char*)’:
35../../include/dos_inc.h:543:78: error: expected primary-expression before ‘,’ token
36  void SetFileName(char const * const _name) { MEM_BlockWrite(pt+offsetof(sMCB,filename),_name,8); }
37                                                                              ^
38../../include/dos_inc.h:543:79: error: ‘filename’ was not declared in this scope
39  void SetFileName(char const * const _name) { MEM_BlockWrite(pt+offsetof(sMCB,filename),_name,8); }
40                                                                               ^
41../../include/dos_inc.h:543:87: error: ‘offsetof’ was not declared in this scope
42  void SetFileName(char const * const _name) { MEM_BlockWrite(pt+offsetof(sMCB,filename),_name,8); }
43                                                                                       ^
44../../include/dos_inc.h: In member function ‘void DOS_MCB::GetFileName(char*)’:
45../../include/dos_inc.h:544:71: error: expected primary-expression before ‘,’ token
46  void GetFileName(char * const _name) { MEM_BlockRead(pt+offsetof(sMCB,filename),_name,8);_name[8]=0;}
47                                                                       ^
48../../include/dos_inc.h:544:72: error: ‘filename’ was not declared in this scope
49  void GetFileName(char * const _name) { MEM_BlockRead(pt+offsetof(sMCB,filename),_name,8);_name[8]=0;}
50                                                                        ^
51../../include/dos_inc.h:544:80: error: ‘offsetof’ was not declared in this scope
52  void GetFileName(char * const _name) { MEM_BlockRead(pt+offsetof(sMCB,filename),_name,8);_name[8]=0;}
53                                                                                ^
54cpu.cpp: In member function ‘void TaskStateSegment::Get_SSx_ESPx(Bitu, Bitu&, Bitu&)’:
55cpu.cpp:294:37: error: expected primary-expression before ‘,’ token
56    PhysPt where=base+offsetof(TSS_32,esp0)+level*8;
57                                     ^
58cpu.cpp:294:38: error: ‘esp0’ was not declared in this scope
59    PhysPt where=base+offsetof(TSS_32,esp0)+level*8;
60                                      ^

…Show last 256 lines

61cpu.cpp:294:42: error: ‘offsetof’ was not declared in this scope
62    PhysPt where=base+offsetof(TSS_32,esp0)+level*8;
63                                          ^
64cpu.cpp:298:37: error: expected primary-expression before ‘,’ token
65    PhysPt where=base+offsetof(TSS_16,sp0)+level*4;
66                                     ^
67cpu.cpp:298:38: error: ‘sp0’ was not declared in this scope
68    PhysPt where=base+offsetof(TSS_16,sp0)+level*4;
69                                      ^
70cpu.cpp:298:41: error: ‘offsetof’ was not declared in this scope
71    PhysPt where=base+offsetof(TSS_16,sp0)+level*4;
72                                         ^
73cpu.cpp: In function ‘bool CPU_SwitchTask(Bitu, TSwitchType, Bitu)’:
74cpu.cpp:348:86: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 2 has type ‘Bitu {aka long unsigned int}’ [-Wformat=]
75   E_Exit("Illegal TSS for switch, selector=%x, switchtype=%x",new_tss_selector,tstype);
76                                                                                      ^
77cpu.cpp:362:49: error: expected primary-expression before ‘,’ token
78   new_cr3=mem_readd(new_tss.base+offsetof(TSS_32,cr3));
79                                                 ^
80cpu.cpp:362:50: error: ‘cr3’ was not declared in this scope
81   new_cr3=mem_readd(new_tss.base+offsetof(TSS_32,cr3));
82                                                  ^
83cpu.cpp:362:53: error: ‘offsetof’ was not declared in this scope
84   new_cr3=mem_readd(new_tss.base+offsetof(TSS_32,cr3));
85                                                     ^
86cpu.cpp:363:49: error: expected primary-expression before ‘,’ token
87   new_eip=mem_readd(new_tss.base+offsetof(TSS_32,eip));
88                                                 ^
89cpu.cpp:363:50: error: ‘eip’ was not declared in this scope
90   new_eip=mem_readd(new_tss.base+offsetof(TSS_32,eip));
91                                                  ^
92cpu.cpp:364:52: error: expected primary-expression before ‘,’ token
93   new_eflags=mem_readd(new_tss.base+offsetof(TSS_32,eflags));
94                                                    ^
95cpu.cpp:364:53: error: ‘eflags’ was not declared in this scope
96   new_eflags=mem_readd(new_tss.base+offsetof(TSS_32,eflags));
97                                                     ^
98cpu.cpp:365:49: error: expected primary-expression before ‘,’ token
99   new_eax=mem_readd(new_tss.base+offsetof(TSS_32,eax));
100                                                 ^
101cpu.cpp:365:50: error: ‘eax’ was not declared in this scope
102   new_eax=mem_readd(new_tss.base+offsetof(TSS_32,eax));
103                                                  ^
104cpu.cpp:366:49: error: expected primary-expression before ‘,’ token
105   new_ecx=mem_readd(new_tss.base+offsetof(TSS_32,ecx));
106                                                 ^
107cpu.cpp:366:50: error: ‘ecx’ was not declared in this scope
108   new_ecx=mem_readd(new_tss.base+offsetof(TSS_32,ecx));
109                                                  ^
110cpu.cpp:367:49: error: expected primary-expression before ‘,’ token
111   new_edx=mem_readd(new_tss.base+offsetof(TSS_32,edx));
112                                                 ^
113cpu.cpp:367:50: error: ‘edx’ was not declared in this scope
114   new_edx=mem_readd(new_tss.base+offsetof(TSS_32,edx));
115                                                  ^
116cpu.cpp:368:49: error: expected primary-expression before ‘,’ token
117   new_ebx=mem_readd(new_tss.base+offsetof(TSS_32,ebx));
118                                                 ^
119cpu.cpp:368:50: error: ‘ebx’ was not declared in this scope
120   new_ebx=mem_readd(new_tss.base+offsetof(TSS_32,ebx));
121                                                  ^
122cpu.cpp:369:49: error: expected primary-expression before ‘,’ token
123   new_esp=mem_readd(new_tss.base+offsetof(TSS_32,esp));
124                                                 ^
125cpu.cpp:369:50: error: ‘esp’ was not declared in this scope
126   new_esp=mem_readd(new_tss.base+offsetof(TSS_32,esp));
127                                                  ^
128cpu.cpp:370:49: error: expected primary-expression before ‘,’ token
129   new_ebp=mem_readd(new_tss.base+offsetof(TSS_32,ebp));
130                                                 ^
131cpu.cpp:370:50: error: ‘ebp’ was not declared in this scope
132   new_ebp=mem_readd(new_tss.base+offsetof(TSS_32,ebp));
133                                                  ^
134cpu.cpp:371:49: error: expected primary-expression before ‘,’ token
135   new_edi=mem_readd(new_tss.base+offsetof(TSS_32,edi));
136                                                 ^
137cpu.cpp:371:50: error: ‘edi’ was not declared in this scope
138   new_edi=mem_readd(new_tss.base+offsetof(TSS_32,edi));
139                                                  ^
140cpu.cpp:372:49: error: expected primary-expression before ‘,’ token
141   new_esi=mem_readd(new_tss.base+offsetof(TSS_32,esi));
142                                                 ^
143cpu.cpp:372:50: error: ‘esi’ was not declared in this scope
144   new_esi=mem_readd(new_tss.base+offsetof(TSS_32,esi));
145                                                  ^
146cpu.cpp:374:48: error: expected primary-expression before ‘,’ token
147   new_es=mem_readw(new_tss.base+offsetof(TSS_32,es));
148                                                ^
149cpu.cpp:375:48: error: expected primary-expression before ‘,’ token
150   new_cs=mem_readw(new_tss.base+offsetof(TSS_32,cs));
151                                                ^
152cpu.cpp:376:48: error: expected primary-expression before ‘,’ token
153   new_ss=mem_readw(new_tss.base+offsetof(TSS_32,ss));
154                                                ^
155cpu.cpp:377:48: error: expected primary-expression before ‘,’ token
156   new_ds=mem_readw(new_tss.base+offsetof(TSS_32,ds));
157                                                ^
158cpu.cpp:378:48: error: expected primary-expression before ‘,’ token
159   new_fs=mem_readw(new_tss.base+offsetof(TSS_32,fs));
160                                                ^
161cpu.cpp:379:48: error: expected primary-expression before ‘,’ token
162   new_gs=mem_readw(new_tss.base+offsetof(TSS_32,gs));
163                                                ^
164cpu.cpp:380:49: error: expected primary-expression before ‘,’ token
165   new_ldt=mem_readw(new_tss.base+offsetof(TSS_32,ldt));
166                                                 ^
167cpu.cpp:380:50: error: ‘ldt’ was not declared in this scope
168   new_ldt=mem_readw(new_tss.base+offsetof(TSS_32,ldt));
169                                                  ^
170cpu.cpp:403:42: error: expected primary-expression before ‘,’ token
171   mem_writed(cpu_tss.base+offsetof(TSS_32,eflags),old_flags);
172                                          ^
173cpu.cpp:403:43: error: ‘eflags’ was not declared in this scope
174   mem_writed(cpu_tss.base+offsetof(TSS_32,eflags),old_flags);
175                                           ^
176cpu.cpp:403:49: error: ‘offsetof’ was not declared in this scope
177   mem_writed(cpu_tss.base+offsetof(TSS_32,eflags),old_flags);
178                                                 ^
179cpu.cpp:404:42: error: expected primary-expression before ‘,’ token
180   mem_writed(cpu_tss.base+offsetof(TSS_32,eip),old_eip);
181                                          ^
182cpu.cpp:404:43: error: ‘eip’ was not declared in this scope
183   mem_writed(cpu_tss.base+offsetof(TSS_32,eip),old_eip);
184                                           ^
185cpu.cpp:406:42: error: expected primary-expression before ‘,’ token
186   mem_writed(cpu_tss.base+offsetof(TSS_32,eax),reg_eax);
187                                          ^
188cpu.cpp:406:43: error: ‘eax’ was not declared in this scope
189   mem_writed(cpu_tss.base+offsetof(TSS_32,eax),reg_eax);
190                                           ^
191cpu.cpp:407:42: error: expected primary-expression before ‘,’ token
192   mem_writed(cpu_tss.base+offsetof(TSS_32,ecx),reg_ecx);
193                                          ^
194cpu.cpp:407:43: error: ‘ecx’ was not declared in this scope
195   mem_writed(cpu_tss.base+offsetof(TSS_32,ecx),reg_ecx);
196                                           ^
197cpu.cpp:408:42: error: expected primary-expression before ‘,’ token
198   mem_writed(cpu_tss.base+offsetof(TSS_32,edx),reg_edx);
199                                          ^
200cpu.cpp:408:43: error: ‘edx’ was not declared in this scope
201   mem_writed(cpu_tss.base+offsetof(TSS_32,edx),reg_edx);
202                                           ^
203cpu.cpp:409:42: error: expected primary-expression before ‘,’ token
204   mem_writed(cpu_tss.base+offsetof(TSS_32,ebx),reg_ebx);
205                                          ^
206cpu.cpp:409:43: error: ‘ebx’ was not declared in this scope
207   mem_writed(cpu_tss.base+offsetof(TSS_32,ebx),reg_ebx);
208                                           ^
209cpu.cpp:410:42: error: expected primary-expression before ‘,’ token
210   mem_writed(cpu_tss.base+offsetof(TSS_32,esp),reg_esp);
211                                          ^
212cpu.cpp:410:43: error: ‘esp’ was not declared in this scope
213   mem_writed(cpu_tss.base+offsetof(TSS_32,esp),reg_esp);
214                                           ^
215cpu.cpp:411:42: error: expected primary-expression before ‘,’ token
216   mem_writed(cpu_tss.base+offsetof(TSS_32,ebp),reg_ebp);
217                                          ^
218cpu.cpp:411:43: error: ‘ebp’ was not declared in this scope
219   mem_writed(cpu_tss.base+offsetof(TSS_32,ebp),reg_ebp);
220                                           ^
221cpu.cpp:412:42: error: expected primary-expression before ‘,’ token
222   mem_writed(cpu_tss.base+offsetof(TSS_32,esi),reg_esi);
223                                          ^
224cpu.cpp:412:43: error: ‘esi’ was not declared in this scope
225   mem_writed(cpu_tss.base+offsetof(TSS_32,esi),reg_esi);
226                                           ^
227cpu.cpp:413:42: error: expected primary-expression before ‘,’ token
228   mem_writed(cpu_tss.base+offsetof(TSS_32,edi),reg_edi);
229                                          ^
230cpu.cpp:413:43: error: ‘edi’ was not declared in this scope
231   mem_writed(cpu_tss.base+offsetof(TSS_32,edi),reg_edi);
232                                           ^
233cpu.cpp:415:42: error: expected primary-expression before ‘,’ token
234   mem_writed(cpu_tss.base+offsetof(TSS_32,es),SegValue(es));
235                                          ^
236cpu.cpp:416:42: error: expected primary-expression before ‘,’ token
237   mem_writed(cpu_tss.base+offsetof(TSS_32,cs),SegValue(cs));
238                                          ^
239cpu.cpp:417:42: error: expected primary-expression before ‘,’ token
240   mem_writed(cpu_tss.base+offsetof(TSS_32,ss),SegValue(ss));
241                                          ^
242cpu.cpp:418:42: error: expected primary-expression before ‘,’ token
243   mem_writed(cpu_tss.base+offsetof(TSS_32,ds),SegValue(ds));
244                                          ^
245cpu.cpp:419:42: error: expected primary-expression before ‘,’ token
246   mem_writed(cpu_tss.base+offsetof(TSS_32,fs),SegValue(fs));
247                                          ^
248cpu.cpp:420:42: error: expected primary-expression before ‘,’ token
249   mem_writed(cpu_tss.base+offsetof(TSS_32,gs),SegValue(gs));
250                                          ^
251cpu.cpp:428:43: error: expected primary-expression before ‘,’ token
252    mem_writed(new_tss.base+offsetof(TSS_32,back),cpu_tss.selector);
253                                           ^
254cpu.cpp:428:44: error: ‘back’ was not declared in this scope
255    mem_writed(new_tss.base+offsetof(TSS_32,back),cpu_tss.selector);
256                                            ^
257cpu.cpp:428:48: error: ‘offsetof’ was not declared in this scope
258    mem_writed(new_tss.base+offsetof(TSS_32,back),cpu_tss.selector);
259                                                ^
260cpu.cpp:430:43: error: expected primary-expression before ‘,’ token
261    mem_writew(new_tss.base+offsetof(TSS_16,back),cpu_tss.selector);
262                                           ^
263cpu.cpp:430:44: error: ‘back’ was not declared in this scope
264    mem_writew(new_tss.base+offsetof(TSS_16,back),cpu_tss.selector);
265                                            ^
266cpu.cpp:430:48: error: ‘offsetof’ was not declared in this scope
267    mem_writew(new_tss.base+offsetof(TSS_16,back),cpu_tss.selector);
268                                                ^
269cpu.cpp:502:50: warning: format ‘%d’ expects argument of type ‘int’, but argument 2 has type ‘Bitu {aka long unsigned int}’ [-Wformat=]
270    E_Exit("Task switch CS Type %d",cs_desc.Type());
271                                                  ^
272cpu.cpp: In function ‘void CPU_Interrupt(Bitu, Bitu, Bitu)’:
273cpu.cpp:724:89: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 2 has type ‘Bitu {aka long unsigned int}’ [-Wformat=]
274      E_Exit("INT:Gate Selector points to illegal descriptor with type %x",cs_desc.Type());
275                                                                                         ^
276cpu.cpp:754:66: warning: format ‘%X’ expects argument of type ‘unsigned int’, but argument 2 has type ‘Bitu {aka long unsigned int}’ [-Wformat=]
277    E_Exit("Illegal descriptor type %X for int %X",gate.Type(),num);
278                                                                  ^
279cpu.cpp:754:66: warning: format ‘%X’ expects argument of type ‘unsigned int’, but argument 3 has type ‘Bitu {aka long unsigned int}’ [-Wformat=]
280cpu.cpp: In function ‘void CPU_IRET(bool, Bitu)’:
281cpu.cpp:901:61: warning: format ‘%X’ expects argument of type ‘unsigned int’, but argument 2 has type ‘Bitu {aka long unsigned int}’ [-Wformat=]
282    E_Exit("IRET:Illegal descriptor type %X",n_cs_desc.Type());
283                                                             ^
284cpu.cpp: In function ‘void CPU_JMP(bool, Bitu, Bitu, Bitu)’:
285cpu.cpp:1058:55: warning: format ‘%X’ expects argument of type ‘unsigned int’, but argument 2 has type ‘Bitu {aka long unsigned int}’ [-Wformat=]
286    E_Exit("JMP Illegal descriptor type %X",desc.Type());
287                                                       ^
288cpu.cpp: In function ‘void CPU_CALL(bool, Bitu, Bitu, Bitu)’:
289cpu.cpp:1294:60: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 2 has type ‘Bitu {aka long unsigned int}’ [-Wformat=]
290    E_Exit("CALL:Descriptor type %x unsupported",call.Type());
291                                                            ^
292cpu.cpp: In function ‘void CPU_RET(bool, Bitu, Bitu)’:
293cpu.cpp:1352:61: warning: format ‘%X’ expects argument of type ‘unsigned int’, but argument 2 has type ‘Bitu {aka long unsigned int}’ [-Wformat=]
294     E_Exit("RET from illegal descriptor type %X",desc.Type());
295                                                             ^
296cpu.cpp:1397:61: warning: format ‘%X’ expects argument of type ‘unsigned int’, but argument 2 has type ‘Bitu {aka long unsigned int}’ [-Wformat=]
297     E_Exit("RET from illegal descriptor type %X",desc.Type());  // or #GP(selector)
298                                                             ^
299cpu.cpp: In function ‘bool CPU_LTR(Bitu)’:
300cpu.cpp:1508:80: warning: format ‘%X’ expects argument of type ‘unsigned int’, but argument 2 has type ‘Bitu {aka long unsigned int}’ [-Wformat=]
301   if (!cpu_tss.SetSelector(selector)) E_Exit("LTR failed, selector=%X",selector);
302                                                                                ^
303Makefile:288: recipe for target 'cpu.o' failed
304make[4]: *** [cpu.o] Error 1
305make[4]: Leaving directory '/home/jay/Downloads/dosbox-0.74/src/cpu'
306Makefile:308: recipe for target 'all-recursive' failed
307make[3]: *** [all-recursive] Error 1
308make[3]: Leaving directory '/home/jay/Downloads/dosbox-0.74/src/cpu'
309Makefile:328: recipe for target 'all-recursive' failed
310make[2]: *** [all-recursive] Error 1
311make[2]: Leaving directory '/home/jay/Downloads/dosbox-0.74/src'
312Makefile:277: recipe for target 'all-recursive' failed
313make[1]: *** [all-recursive] Error 1
314make[1]: Leaving directory '/home/jay/Downloads/dosbox-0.74'
315Makefile:215: recipe for target 'all' failed
316make: *** [all] Error 2

I tried this on two different machines, one running Fedora 21 and the other running Mint 18.2 & got the same errors. I have successfully compiled SVN versions multiple times on the same two machines; nothing has been changed in my environment.

What do I need to do to get 0.74 to compile?

(Alternately, can I apply the pinball patch to the latest SVN without alterations?)

twitch.tv/oldskooljay - playing the obscure, forgotten & weird - most Tuesdays & Thursdays @ 6:30 PM PDT. Bonus streams elsewhen!

Reply 1 of 1, by Qbix

Posted on 2017-09-22, 08:29

Qbix Offline

Rank DOSBox Author

Rank: DOSBox Author
Posts: 11324
Joined: 2002-11-27, 14:50
Location: Fryslan

you need to add one patch to 0.74 in order for it to compile on modern compilers.
I don't have it at hand, but it's this one:
https://anonscm.debian.org/cgit/collab-maint/ … m_svn3691.patch

Water flows down the stream
How to ask questions the smart way!

Go to top of page Go to top of page

Back to DOSBox Development