Re: Wrong colors on BIG ENDIAN in games/apps which use 15,16 or 32bit video modes

Posted on 2020-01-27, 09:30

by

by kas1e

in DOSBox Development

in DOSBox Development

@Jmarsh It's not me talking about, its other developer, I only quote what he says and especially point out that its quote. But the truth is AmigaOS4, MorphOS, and Linux PPC (which is far more popular than AmigaOS4 and MorphOS): do have that problem. So are you mean that SDL ports on amigaos4, …

---

Re: Wrong colors on BIG ENDIAN in games/apps which use 15,16 or 32bit video modes

Posted on 2020-01-27, 06:20

by

by kas1e

in DOSBox Development

in DOSBox Development

In other words, it is bugs (or just unsupported features) in DOSBox. As explain one of MorphOS developers: the reason likely stems from the fact that the Wii uses little-endian 15- and 16-bit modes, and the SDL implementation doesn't perform SDL_Surface shadow byteswapping as needed, in which case …

---

Re: Wrong colors on BIG ENDIAN in games/apps which use 15,16 or 32bit video modes

Posted on 2020-01-26, 22:27

by

by kas1e

in DOSBox Development

in DOSBox Development

Ah do you mean it's for fullscreen only.. And yep, I running on 32-bit screens because I am on SDL2 patch for DOSBox assuming that you run on 32bit screen always.

---

Re: Wrong colors on BIG ENDIAN in games/apps which use 15,16 or 32bit video modes

Posted on 2020-01-26, 20:04

by

by kas1e

in DOSBox Development

in DOSBox Development

Fixing it is easy in render_templates.h: #if SBPP == 15 .... #elif DBPP == 16 #define PMAKE(_VAL) (((__builtin_bswap16(_VAL)) & 31) | ((__builtin_bswap16(_VAL)) & ~31) << 1) #if SBPP == 16 ... #elif DBPP == 16 #define PMAKE(_VAL) __builtin_bswap16(_VAL) Tried : nope, didn't change things. Maybe we …

---

Re: Wrong colors on BIG ENDIAN in games/apps which use 15,16 or 32bit video modes

Posted on 2020-01-26, 19:54

by

by kas1e

in DOSBox Development

in DOSBox Development

Probably for us the most important is 16bit as if I remember right, DOS games and apps usually were in 256colors, and 16bit. Do not remember any game which by default was in 32 bit and give no ability to choose 16 at least. At least those games which not ask for 3d accelerator.

---

Re: Wrong colors on BIG ENDIAN in games/apps which use 15,16 or 32bit video modes

Posted on 2020-01-26, 19:22

by

by kas1e

in DOSBox Development

in DOSBox Development

@All Oh, there is really good news now! Kcroft does check it on his Linux PPC on PowerMac, and he have exactly the same issues (absolutely the same look as we have), see further here: https://github.com/dreamer/dosbox-staging/issues/144#issuecomment-578533293 So Jmarsh's Wii there as an exception. …

---

Re: Wrong colors on BIG ENDIAN in games/apps which use 15,16 or 32bit video modes

Posted on 2020-01-26, 18:45

by

by kas1e

in DOSBox Development

in DOSBox Development

@rzookol In theory there are two conversions VGA (LE) -> SDL (BE) -> Gfx card (LE) That probably will slow things down? But at least if we can choose to do such conversion only for 16-bit modes and keep 8bit ones as it was, then better than nothing.

---

Re: Wrong colors on BIG ENDIAN in games/apps which use 15,16 or 32bit video modes

Posted on 2020-01-26, 09:56

by

by kas1e

in DOSBox Development

in DOSBox Development

Oh, and issue with 32bit modes looks pretty common of how it was for Dominus bug (though for him it was 16bit), there: Color distortion with upcoming SDL 1.2.14 and/or OS X 10.6.1

---

Re: Wrong colors on BIG ENDIAN in games/apps which use 15,16 or 32bit video modes

Posted on 2020-01-26, 09:34

by

by kas1e

in DOSBox Development

in DOSBox Development

Sorry, I am not a programmer, so not understand what the latest phrase means and how it related. If DOSBox didn't something, then bugs should happen the same on all Big-Endian oses, but if it happens on some and on some not... So I tried to understand where is issues are. Are you 100% sure, that for …

---

Re: Wrong colors on BIG ENDIAN in games/apps which use 15,16 or 32bit video modes

Posted on 2020-01-26, 09:14

by

by kas1e

in DOSBox Development

in DOSBox Development

Though, that didn't explain why for you 32bit modes work fine on Wii. Can you re-test plz PCPBench with "PCBench.exe 115", so to run it in 32bits? If it will have the same "green" issue as I have in 32bit colors, then it means we may have 2 separate issues: one for 32bit mode for all big-endian …

---

Re: Wrong colors on BIG ENDIAN in games/apps which use 15,16 or 32bit video modes

Posted on 2020-01-26, 09:06

by

by kas1e

in DOSBox Development

in DOSBox Development

Is Wii have PC screen modes or non PC ones? What I mean, is that on AmigaOS4 and MorphOS for 15/16 bit we use PC modes, maybe Wii doesn't and so it works.

---

Re: Wrong colors on BIG ENDIAN in games/apps which use 15,16 or 32 video modes

Posted on 2020-01-26, 07:54

by

by kas1e

in DOSBox Development

in DOSBox Development

DOSBox is the first SDL1/SDL2 program that brings that kind of issue (and we have a gazillion of SDL1/SDL2 apps). It is probably not about SDL implementation, but how screens/etc done on different OS. Or do you mean SDL's code inside of DOSBox? The same issue happens on 2 different PPC OS, with …

---

Re: Wrong colors on BIG ENDIAN in games/apps which use 65k colors

Posted on 2020-01-26, 07:13

by

by kas1e

in DOSBox Development

in DOSBox Development

I find out that PCPBench tool has the ability to choose the size and depth of the screen, and so, I can confirm in which modes we have color issues: 8 bpp: no bugs http://kas1e.mikendezign.com/aos4/dosbox/badcolors/pcnbench_8bpp.jpg 15 bpp: have bugs http://kas1e.mikendezign.com/aos4/dosbox/ …

---

Re: Wrong colors on BIG ENDIAN in games/apps which use 65k colors

Posted on 2020-01-24, 13:46

by

by kas1e

in DOSBox Development

in DOSBox Development

And another info to add by one of MorphOS developers who do the port for that os: It should be some easy bug to fix (maybe MacosX PPC / LinuxPPC uses RGB16 and we on AmigaOS4 and MorphOS mostly use RGB16PC). And I managed to run Hugi with normal colors: - set desktop to 16bit (instead of 32 or 24) - …

---

Re: Wrong colors on BIG ENDIAN in games/apps which use 65k colors

Posted on 2020-01-24, 08:27

by

by kas1e

in DOSBox Development

in DOSBox Development

How interesting .. I checked on other PPC OS - MorphOS, and it has the same issues! I need to try myself on MacOS PPC and Linux PPC.

---

Re: Wrong colors on BIG ENDIAN in games/apps which use 65k colors

Posted on 2020-01-23, 20:19

by

by kas1e

in DOSBox Development

in DOSBox Development

Oh, your bug indeed looks a bit different. For you, only a few colors were swapped, but on my screenshots, all looks like some palette issues. Something now usual "wrong colors swap" but heavier. So I seem again left with our SDL :) Is in terms of SDL in DOSBox 256k and 65000 modes handled …

---

Re: Wrong colors on BIG ENDIAN in games/apps which use 65k colors

Posted on 2020-01-23, 19:50

by

by kas1e

in DOSBox Development

in DOSBox Development

I don't have the issue with the last release of SDL2. And I don't have it with SVN builds against SDL1.2 since 2018 or so. I still have it with my snapshots of sometime 2017. Hm... I also use the latest SDL1 sources as well as the latest SDL2 sources... AND/OR at some point, I did change a simple …

---

Re: PowerPC Dynamic Recompiler (patch)

Posted on 2020-01-23, 14:31

by

by kas1e

in DOSBox Development

in DOSBox Development

@jmarsh Right, moved all there: Wrong colors on BIG ENDIAN in games/apps which use 15,16 or 32bit video modes

---

Wrong colors on BIG ENDIAN in games/apps which use 15,16 or 32bit video modes

Posted on 2020-01-23, 14:31

by

by kas1e

in DOSBox Development

in DOSBox Development

Lately found that on 2 different BIG ENDIAN PPC OS such as AmigaOS4 and MorphOS some games and apps give us broken colors (while everything shows correctly in the same apps/games, on the same DOSBox svn build, with the same config, but on X86 or X84). It doesn't matter if you use "normal" or " …

---

Re: PowerPC Dynamic Recompiler (patch)

Posted on 2020-01-23, 08:08

by

by kas1e

in DOSBox Development

in DOSBox Development

@Dominus I have exactly the same issues with the same games when I use SDL1 build. So it probably should be DOSBox's endian issues. Maybe Jmarsh was in the impression that I have everywhere such issues, but nope, just "hugi" diskmag and those 3 games. And the common from all of them that they indeed …

---