DosBox Windows resource file (winres.rc) \ VOGONS

DosBox Windows resource file (winres.rc)

Topic actions

Post a reply

First post, by bloodbat

Posted on 2010-08-08, 20:36

bloodbat Offline

Rank Oldbie

Rank: Oldbie
Posts: 796
Joined: 2009-12-06, 07:11

Hello, I noticed the internal program information for DosBox in Windows is included in the source, but it's never used in the compiled .exe, it's missing a simple line: #include <Windows.h>, it should be:

1[...]
2#include <Windows.h>
3
4// version resource
5VS_VERSION_INFO VERSIONINFO
6 FILEVERSION 0,74,0,0
7 PRODUCTVERSION 0,74,0,0
8[...]

It doesn't affect functionality one way or another, but if it's there...why not use it?

Reply 1 of 6, by wd

Posted on 2010-08-08, 20:56

wd Offline

Rank DOSBox Author

Rank: DOSBox Author
Posts: 10813
Joined: 2003-12-03, 21:23

it's missing a simple line: #include <Windows.h>

Says who?

Reply 2 of 6, by bloodbat

Posted on 2010-08-09, 02:17

bloodbat Offline

Rank Oldbie

Rank: Oldbie
Posts: 796
Joined: 2009-12-06, 07:11

The source I got from SVN and the fact that if I right click on the official build the information does not show, and also, here: http://msdn.microsoft.com/en-us/library/aa381058.aspx; but if it bothers you, sorry, just trying to help.

Reply 3 of 6, by wd

Posted on 2010-08-09, 06:00

wd Offline

Rank DOSBox Author

Rank: DOSBox Author
Posts: 10813
Joined: 2003-12-03, 21:23

The source I got from SVN

What SVN?

VS_VERSION_INFO is defined through the present include in the resource file,
and file detail information works fine for me both with my vs compiled executable
as well as the 0.74 release.

Reply 4 of 6, by bloodbat

Posted on 2010-08-09, 19:57

bloodbat Offline

Rank Oldbie

Rank: Oldbie
Posts: 796
Joined: 2009-12-06, 07:11

Dosbox's SVN. Odd, it doesn't work for me on the official but it does work (after adding said line) in my VS 2010 build...
Well, as I said, just trying to help.

Reply 5 of 6, by ripa

Posted on 2010-08-09, 20:53

ripa Offline

Rank Oldbie

Rank: Oldbie
Posts: 559
Joined: 2005-04-18, 00:53
Location: Finland

I had to delete #include "afxres.h" (or replace it with #include "windows.h") in winres.rc in order to compile in Visual Studio Express.

Reply 6 of 6, by bloodbat

Posted on 2010-08-10, 20:17

bloodbat Offline

Rank Oldbie

Rank: Oldbie
Posts: 796
Joined: 2009-12-06, 07:11

ripa wrote:
I had to delete #include "afxres.h" (or replace it with #include "windows.h") in winres.rc in order to compile in Visual Studio Express.

Probably because Express editions don't include MFC.

Go to top of page Go to top of page

Back to DOSBox Development

Main menu

Common searches