Monkey Island 1&2: Roland MT-32 + Sound Blaster support

Getting old DOS games working on modern hardware. (DOSBox topics belong in DOSBox areas below, not here).

Re: Monkey Island 1&2: Roland MT-32 + Sound Blaster support

Postby Python1980 » 2013-7-29 @ 23:09

Ok, so the spitting you were referring to was Largo spitting on the wall? I do get that one.

However I am certain (in my copy at least) that the owner of the Bloody Bar & Grill makes a spitting sound when he spits into the mugs to clean them while using Adlib sound. It doesnt play when using Soundblaster though so that may be the difference? I wonder if there are other Adblib effects missed when using Sound Blaster.
Python1980
Newbie
 
Posts: 22
Joined: 2013-5-11 @ 13:13

Re: Monkey Island 1&2: Roland MT-32 + Sound Blaster support

Postby NewRisingSun » 2013-7-30 @ 07:48

It turns out there actually is an AdLib sound effect when the bar owner sneezes into the glass he's cleaning, and that sound effect indeed only gets played with the AdLib, not the Sound Blaster selection. That's obviously another bug in the original game, because there is no reason not to play the sound with the unpatched Sound Blaster selection. I'm beginning to hate LucasArts' sound programmers almost as much as Dynamix'.
NewRisingSun
Oldbie
 
Posts: 852
Joined: 2005-9-02 @ 02:26

Re: Monkey Island 1&2: Roland MT-32 + Sound Blaster support

Postby keropi » 2013-7-30 @ 07:56

I wonder what other sfx are missing in action.... :\
User avatar
keropi
l33t++
 
Posts: 7252
Joined: 2003-9-08 @ 06:45
Location: Greece

Re: Monkey Island 1&2: Roland MT-32 + Sound Blaster support

Postby NewRisingSun » 2013-7-30 @ 08:55

Searching for the script code that checks for the AdLib setting (21 59 69 6A 69) turns up eight instances in MONKEY2.001. Changing all occurrences of 21 59 69 6A 69 to 21 59 69 6C 69 enables the sound effect in the bar, which turns out to be a spitting sound effect after all, even though the barkeep is sneezing, not spitting. I would need to test-play through the whole game with that change applied, to see if this breaks anything, before updating the patch.

Just changing the bytes in this manner certainly breaks those sound effects for the AdLib setting, because instead of only playing them on AdLib, they would only played on Sound Blaster (and Roland+Sound Blaster with the patch applied). The proper sequence would be to ignore the branch instruction completely, which is achieved by changing the byte that immediately follows 21 59 69 6A 69 from whatever it is to 69. That enables the sound effect for both AdLib and (patched & unpatched) Sound Blaster.

ScummVM does a similar hack in engines\scumm\script_v5.cpp:
Code: Select all
void ScummEngine_v5::o5_isEqual() {
   int16 a, b;
   int var;

   if (_game.version <= 2)
      var = fetchScriptByte();
   else
      var = fetchScriptWord();
   a = readVar(var);
   b = getVarOrDirectWord(PARAM_1);

   // HACK: See bug report #602348. The sound effects for Largo's screams
   // are only played on type 5 soundcards. However, there is at least one
   // other sound effect (the bartender spitting) which is only played on
   // type 3 soundcards.

   if (_game.id == GID_MONKEY2 && var == VAR_SOUNDCARD && b == 5)
      b = a;

   // HACK: To allow demo script of Maniac Mansion V2
   // The camera x position is only 100, instead of 180, after game title name scrolls.
   if (_game.id == GID_MANIAC && _game.version == 2 && (_game.features & GF_DEMO) && isScriptRunning(173) && b == 180)
      b = 100;

   jumpRelative(b == a);
}


I have updated the mi2_mtsb.zip in the first post to this thread.
NewRisingSun
Oldbie
 
Posts: 852
Joined: 2005-9-02 @ 02:26

Re: Monkey Island 1&2: Roland MT-32 + Sound Blaster support

Postby keropi » 2013-7-30 @ 10:36

^ awesome work once again!

I assume that if we run just the "change" commands on already patched game it's enough , right?
User avatar
keropi
l33t++
 
Posts: 7252
Joined: 2003-9-08 @ 06:45
Location: Greece

Re: Monkey Island 1&2: Roland MT-32 + Sound Blaster support

Postby dacow » 2013-8-05 @ 12:20

How have I not seen this thread till now, can't wait to give it a go on the weekend!Thanks for the work on this one much appreciated :) :)
User avatar
dacow
Member
 
Posts: 177
Joined: 2011-1-11 @ 10:34
Location: Australia

Re: Monkey Island 1&2: Roland MT-32 + Sound Blaster support

Postby NewRisingSun » 2014-12-23 @ 15:24

I am currently trying to add support for the additional PCM sound effects found in the FM-Towns version. The problem I'm having is that when a PCM sound effect is looped and is played in two screens, changing screens causes SCUMM to reorganize its memory without telling the sound driver. That is not a problem for MIDI, as the pointers to the MIDI sequence get updated as well, but for PCM sound effects, the DMA would need to be informed of that as well.
NewRisingSun
Oldbie
 
Posts: 852
Joined: 2005-9-02 @ 02:26

Re: Monkey Island 1&2: Roland MT-32 + Sound Blaster support

Postby Jolaes76 » 2015-1-15 @ 11:12

I don't know if it has been already discussed or done before but someone really should do the "secretary work" to catalogue and, if permitted, offer downloads for NRS' patches for DOS games.
Some made it to major fan pages like that of Collectors' but Sierra games are just the top of the iceberg... err... ice-cream :)
"Ita in vita ut in lusu alae pessima iactura arte corrigenda est."
Jolaes76
Oldbie
 
Posts: 743
Joined: 2011-3-23 @ 09:31
Location: Hungary

Re: Monkey Island 1&2: Roland MT-32 + Sound Blaster support

Postby Serious Callers Only » 2015-8-24 @ 17:38

Does this work with the 'ultimate talkies edition'?
Serious Callers Only
Member
 
Posts: 376
Joined: 2003-4-26 @ 21:34

Re: Monkey Island 1&2: Roland MT-32 + Sound Blaster support

Postby NewRisingSun » 2015-8-24 @ 20:03

I sure hope not.
NewRisingSun
Oldbie
 
Posts: 852
Joined: 2005-9-02 @ 02:26

Re: Monkey Island 1&2: Roland MT-32 + Sound Blaster support

Postby PhilsComputerLab » 2015-8-25 @ 11:44

With the original game, does Adlib give you the "most" sounds and music compared to Sound Blaster or Roland?
User avatar
PhilsComputerLab
Hardware Mod
 
Posts: 6179
Joined: 2014-9-28 @ 03:33
Location: Western Australia

Re: Monkey Island 1&2: Roland MT-32 + Sound Blaster support

Postby Great Hierophant » 2015-8-26 @ 01:48

philscomputerlab wrote:With the original game, does Adlib give you the "most" sounds and music compared to Sound Blaster or Roland?


Adlib and Game Blaster give you the most music and sound. The original floppy releases do not support Sound Blaster digitized audio playback capabilities at all. Roland gives no sound effects and not all the music is available for the PC Speaker and Tandy.

The Ultimate Talkie Edition comes with full sound effects.
http://nerdlypleasures.blogspot.com/ - Nerdly Pleasures - My Retro Gaming, Computing & Tech Blog
User avatar
Great Hierophant
l33t
 
Posts: 2398
Joined: 2003-4-27 @ 08:20

Re: Monkey Island 1&2: Roland MT-32 + Sound Blaster support

Postby sirlemonhead » 2015-8-26 @ 21:05

NewRisingSun wrote:which turns out to be a spitting sound effect after all, even though the barkeep is sneezing, not spitting.


He's not sneezing in the animation though, he's... hocking up a giant loogie and using that to clean the glass :cry:
User avatar
sirlemonhead
Member
 
Posts: 215
Joined: 2004-9-06 @ 15:16
Location: Ireland

Re: Monkey Island 1&2: Roland MT-32 + Sound Blaster support

Postby The_Atomik_Punk! » 2015-9-08 @ 03:25

Hey guys, I'm late to the party with The Secret of Monkey Island, and have (I think) successfully patched my floppy version (interpreter v 5.0.18) to play both Roland MT-32 music with Adlib sound effects, but I'd like to verify that I have it working properly as I don't know what to be listening for.

I hear a scratchy sqweek sound when I open the SCUMM Bar door, and that's not present when I import the game to SCUMMVM; is that the Adlib sound effects correctly being called? What other Adlib sound effects should I look out for near the beginning of the game to make sure the patch by NewRisingSun is working properly?
The_Atomik_Punk!
Newbie
 
Posts: 15
Joined: 2015-8-04 @ 20:59

Re: Monkey Island 1&2: Roland MT-32 + Sound Blaster support

Postby Great Hierophant » 2015-9-08 @ 11:37

Try the chicken pulley at Meathook's house.
http://nerdlypleasures.blogspot.com/ - Nerdly Pleasures - My Retro Gaming, Computing & Tech Blog
User avatar
Great Hierophant
l33t
 
Posts: 2398
Joined: 2003-4-27 @ 08:20

Re: Monkey Island 1&2: Roland MT-32 + Sound Blaster support

Postby NewRisingSun » 2015-9-09 @ 17:08

The_Atomik_Punk! wrote:I don't know what to be listening for.
You're looking for the same sound effects that you get when running the unpatched game with "monkey a".
NewRisingSun
Oldbie
 
Posts: 852
Joined: 2005-9-02 @ 02:26

Re: Monkey Island 1&2: Roland MT-32 + Sound Blaster support

Postby The_Atomik_Punk! » 2015-9-10 @ 04:21

That makes perfects sense; using that as a baseline, your patch is working perfectly in combining Roland MT32 music and Adlib sound effects- thanks for the insight and patch!
The_Atomik_Punk!
Newbie
 
Posts: 15
Joined: 2015-8-04 @ 20:59

Re: Monkey Island 1&2: Roland MT-32 + Sound Blaster support

Postby slx » 2016-5-24 @ 18:40

I found some missing Adlib sound effects in MI2!
there are NO SOUND EFFECTS WHEN GUYBRUSH KICKS IN THE HAND-RAIL AND HE FALLS INTO THE KITCHEN AND SLAMS ON THE FLOOR at the 'Bloody Lip Bar and Grill';
there is NO SOUND EFFECT WHEN THE INNKEEPER RUNS AFTER THE ALLIGATOR in the Inn;
there is NO (ADLIB/SB) EFFECT SOUND WHEN YOU OPEN/CLOSE THE DOOR in the Inn, either.
User avatar
slx
Newbie
 
Posts: 33
Joined: 2013-10-19 @ 16:05

Re: Monkey Island 1&2: Roland MT-32 + Sound Blaster support

Postby lukeman3000 » 2017-1-18 @ 20:51

Hi -

I'm curious as to why ScummVM breaks the retro gaming experience. What does DOSBox do differently and what are the reasons I might want to play Monkey Island with DOSBox as opposed to ScummVM?

Furthermore, if I tick the "mixed adlib/midi mode" checkbox in ScummVM, will I hear all of the music and sound effects in ScummVM as I would with this patch?
lukeman3000
Member
 
Posts: 198
Joined: 2009-3-17 @ 00:59

Re: Monkey Island 1&2: Roland MT-32 + Sound Blaster support

Postby NooNaN » 2017-1-18 @ 21:21

Is it possible to get the Ultimate Talkie versions going on a DOS 6.22 machine with Win 98? Ideally, natively in DOS...
User avatar
NooNaN
Member
 
Posts: 123
Joined: 2015-8-13 @ 12:46
Location: Boston, MA USA

PreviousNext

Return to DOS

Who is online

Users browsing this forum: No registered users and 1 guest