should CallBack_Handlers index be checked? \ VOGONS

should CallBack_Handlers index be checked?

Topic actions

First post, by peterferrie

Posted on 2011-05-12, 19:16

peterferrie Offline

Rank Oldbie

Rank: Oldbie
Posts: 649
Joined: 2008-05-08, 21:54

fe 38 00 01
just to a random memory location and runs the native code there.
that seems a little unsafe.
I understand that DOSBox isn't security-reviewed, but still...

Reply 1 of 2, by Qbix

Posted on 2011-05-12, 19:19

Qbix Offline

Rank DOSBox Author

Rank: DOSBox Author
Posts: 11324
Joined: 2002-11-27, 14:50
Location: Fryslan

weren't they zeroed out for nice crashes ?

Water flows down the stream
How to ask questions the smart way!

Reply 2 of 2, by peterferrie

Posted on 2011-05-12, 22:58

peterferrie Offline

Rank Oldbie

Rank: Oldbie
Posts: 649
Joined: 2008-05-08, 21:54

zeroed only inside the array, but the bounds aren't checked so you can access beyond the end of the array, and who knows what's there.

Go to top of page Go to top of page

Back to DOSBox Development