emendelson wrote:

(Of course, it would be best if the screen got redrawn whenever the DOSBox window was restored after being minimized, but I suppose that would be a lot more complicated.)

The "restore window event" may be a detectable event in the SDL OSX driver and set to reset the screen. However, in dosbox, you could bind a key to the GFX_ResetScreen function. That may fix the palette problem and it is called when you exit the mapper program.

truth5678 wrote:

emendelson wrote:

(Of course, it would be best if the screen got redrawn whenever the DOSBox window was restored after being minimized, but I suppose that would be a lot more complicated.)

The "restore window event" may be a detectable event in the SDL OSX driver and set to reset the screen. However, in dosbox, you could bind a key to the GFX_ResetScreen function. That may fix the palette problem and it is called when you exit the mapper program.

Thank you for this. If I knew more, I could probably follow this suggestion, but this is as far as I got:

1. I added this line to sdlmain.cpp:

1 MAPPER_AddHandler(GFX_ResetScreen,MK_f3,MMOD1|MMOD2,"redraw","Redraw Screen");

2. When I compiled in OS X, I got these errors that don't appear if that line is absent:

1sdlmain.cpp: In function ‘void GUI_StartUp(Section*)’:
2sdlmain.cpp:1348: error: invalid conversion from ‘void (*)()’ to ‘void (*)(bool)’
3sdlmain.cpp:1348: error:   initializing argument 1 of ‘void MAPPER_AddHandler(void (*)(bool), MapKeys, Bitu, const char*, const char*)’
4...
5make[3]: *** [sdlmain.o] Error 1

Where the "..." is in the above, these errors also appear, but they appear in a successful build also:

1sdlmain.cpp: In function ‘void show_warning(const char*)’:
2sdlmain.cpp:1655: warning: format not a string literal and no format arguments
3sdlmain.cpp:1655: warning: format not a string literal and no format arguments

What obvious thing am I doing incorrectly here? Apologies for coming back for more help after you provided help already!

Try the attached patch against DOSBox SVN; or copy the lines which start with "+" to sdl_mapper.cpp.

That's perfect! Works beautifully. Thank you!

I hope the devs might consider adding this to SVN. It's clearly useful for games, and really needed under OS X - until someone figures out how to make the same thing happen automatically when DOSBox gets restored after being minimized.

Thank you again!

Glad it worked! 😀

Two lines in that patch may fix the other issue on switching from text to graphics mode in OSX:
KEYBOARD_ClrBuffer();
GFX_LosingFocus();

Those lines will clear the keyboard buffer and may prevent the repeating keypresses on changing OSX resolution (text -> graphics). I recall there is a function (perhaps in sdlmain) for changing graphics resolution, those two lines could be added there along with defining the code block as OSX only.

The closest thing I could find that fits your description in sdlmain.cpp was this:

1case SDL_VIDEORESIZE:
2//			HandleVideoResize(&event.resize);
3			break;

Because I don't know any better, I simply inserted the two lines that you suggested, between the commented line and "break", but I didn't see any consistent effect. My guess is that I need a block that begins something like:

1static void HandleVideoResize

but I haven't the faintest idea of how to write it. Am I at least looking in the right direction? If this problem could be solved, it would eliminate the last serious annoyances in DOSBox under OS X.

Again, I can't thank you enough for the trouble you've taken over this.

I think this function may fit:
GFX_SetSize

or the focus gain/loss function

Thanks, Qbix!

1void GFX_LosingFocus(void) {
2+	KEYBOARD_ClrBuffer();

Just in case, here is the 2nd option:

1Bitu GFX_SetSize(Bitu width,Bitu height,Bitu flags,double scalex,double scaley,GFX_CallBack_t callback) {
2+	KEYBOARD_ClrBuffer();
3+	GFX_LosingFocus();

truth5678 wrote:

Just in case, here is the 2nd option: […]
Show full quote

Just in case, here is the 2nd option:

Copy code to clipboard

1Bitu GFX_SetSize(Bitu width,Bitu height,Bitu flags,double scalex,double scaley,GFX_CallBack_t callback) {
2+	KEYBOARD_ClrBuffer();
3+	GFX_LosingFocus();

This one solved it! (The other one seems to have produced the same results I saw earlier, repeated keys.) At least I haven't seen the problem in my first tests, but I'll continue testing it.

Incidentally, the symptom of the problem (now solved, apparently) is that the repeated characters do NOT occur the first time I shift from text to graphics, and rarely occurs when I switch from graphics back to text, but always occurs when I switch from text to graphics, or switch between different graphic modes, after the first time.

If this fix doesn't cause any other problems, I hope it might go into SVN. The problem has been discussed more than once on the forum and would seem to apply to games.

Again, thank you!

In the hope of avoiding the problem of changing colors (after restoring DOSBox from being minimized, in OS X), I looked around the SDL docs, and found that the "videoresize" event in SDL occurs when the window has been changed by the window manager and needs to be rewritten.

I wonder if this might point to a solution of the color-changing problem? I tried adding some lines of code from your RedrawScreen.diff file to sdlmain.cpp, underneath "case SDL_VIDEORESIZE", but of course it didn't work because your patch works only in sdl_mapper.cpp.

But is it possible to adapt that code to work in sdlmain.cpp? That might do away with this problem forever.