VOGONS

Strange Issue with 0.72 Window Display Title

Topic actions

First post, by Iz

Posted on 
User metadata
Rank Newbie
Rank
Newbie

First post but great program guys, been using it for years. Thanks for all the time you put into bring back our good old DOS games! 😀

I never noticed this before but in .72 the main dos box window shows up as "SDL_app" until I change the frameskip or something that forces an update. Also there is no icon at the top left of the window, just the default windows bluebar/whitebox.

This happens when I am connected to a computer via windows terminal services and then run DOSBOX. (Win32 build)

I was going to submit it as a bug but I wanted to make sure I wasn't nuts and that other people are having this issue? (I didn't see it listed in sourceforge.)

Reply 1 of 5, by Iz

Posted on 
User metadata
Rank Newbie
Rank
Newbie

I was able to fix this problem by breaking out the icon setting routine into its own function inside of the sdlmain.cpp file.

Then calling both this new sub and the existing GFX_SetTitle function after
if (sdl.surface == NULL) occurs but before the video mode is actually set.

(Then recompiling of course!)

It was just a test to see if it fixed the issue, I wouldn't recommend anyone actually use my C++ code. 🤣....

Anyway there could be more instances where a video mode reset because of a display failure could screw up the icon and title, just something to keep in mind for the devs. I do not mean that in a presumptuous way, they are doing a fantastic job and this is such a non issue, but I figured I could help. If for some reason they actually want to see the code change pm me and I can email the one .cpp file that was modified.

Reply 2 of 5, by wd

Posted on 
User metadata
Rank DOSBox Author
Rank
DOSBox Author

Hm i remember some bug that did surface with win95/win98, don't know
the exact cause though (bug in SDL which is fixed in their latest release
or cvs version).
Any way feel free to post your code changes (diff or source files).

Reply 3 of 5, by Iz

Posted on 
User metadata
Rank Newbie
Rank
Newbie

I have the latest SDL files as I just put together my DOSBOX build environment today. I think it's because when it fails to create the screen and gets to this point in the code it destroys everything and recreates the window. That's a guess, but it seems reasonable.

What method do you guys use for posting diffs, I have Araxis Merge but don't think that's what you folks use. I'm pretty much just a Win32 developer, and don't want to make things more difficult by using the wrong tool.

EDIT: I just tested the release build of 0.72 with the latest SDL and SDL NET DLL files and you were right, the problem is fixed. Guess you will be including these with the next release version. Good stuff. 😀

Reply 4 of 5, by wd

Posted on 
User metadata
Rank DOSBox Author
Rank
DOSBox Author

Hm strange though that it doesn't work with your own build.

Araxis spits out some strange formats especially for directory diffs,
if you want to stick to windows try some cvs tools like tortoise cvs
where you can create diffs against the cvs sources.

Reply 5 of 5, by Iz

Posted on 
User metadata
Rank Newbie
Rank
Newbie

I'll take a look at those programs, thanks!

I have it working in my build too, recompiled everything etc etc... Had the "old" dlls in my release folder for some reason. Glad to see it wasn't a DOSBOX bug though. 😁

Go to top of page Go to top of page
Back to DOSBox General
Close window
Close window