.fx Shader Requirements \ VOGONS

.fx Shader Requirements

Topic actions

First post, by Yushatak

Posted on 2011-01-21, 13:58

Yushatak Offline

Rank Member

Rank: Member
Posts: 201
Joined: 2010-05-29, 18:39

With the versions of DOSBox patched to use shaders when rendering in DirectX mode, I keep finding shaders that I'd like to use that refuse to function with DOSBox.

Ex. I've wanted CRT emulation in DOSBox for a while now, and I recently came across some shaders that do just that. I wanted to try them out, but when I dropped them in there, DOSBox complained about the formatting. I realized it had an XML header and footer, so I removed them. I then tried again, and it tossed errors about variable declarations being "unexpected" and such. I realize that some variables and function names need to be rewritten to conform to the standard set for DOSBox shaders, but what exactly needs to be done? What are the input variables, what is the main function name, is there any special outputs? Etc..

Anybody have a clue? 😖

Here's the shader I've been trying to get to work, needs variable name changes, but I don't know to what..

1        uniform sampler2D rubyTexture;
2        uniform vec2 rubyInputSize;
3        uniform vec2 rubyOutputSize;
4        uniform vec2 rubyTextureSize;
5
6        #define TEX2D(c) texture2D(rubyTexture,(c))
7        #define PI 3.141592653589
8        #define phase 0.0
9        #define gamma 2.7
10
11        #define distortion 0.2
12
13        vec2 barrelDistortion(vec2 coord) {
14                vec2 cc = coord*rubyTextureSize/rubyInputSize - 0.5;
15                float dist = dot(cc, cc);
16                return coord + (cc * (dist + distortion * dist * dist) * distortion)*rubyInputSize/rubyTextureSize;
17        }
18
19        void main()
20        {
21                vec2 xy = barrelDistortion(gl_TexCoord[0].xy);
22
23                vec2 one          = 1.0/rubyTextureSize;
24
25
26                vec2 uv_ratio     = fract(xy*rubyTextureSize);
27xy.x = floor(xy.x/one.x)*one.x;
28
29
30                vec4 col, col2;
31
32                vec4 coeffs = vec4(1.0 + uv_ratio.x, uv_ratio.x, 1.0 - uv_ratio.x, 2.0 - uv_ratio.x);
33                coeffs = mix((sin(PI * coeffs) * sin(PI * coeffs / 2.0)) / (coeffs * coeffs), vec4(1.0), lessThan(abs(coeffs), vec4(0.01)));
34                coeffs = coeffs / (coeffs.x+coeffs.y+coeffs.z+coeffs.w);
35
36                col  = clamp(coeffs.x * TEX2D(xy + vec2(-one.x,0.0)) + coeffs.y * TEX2D(xy) + coeffs.z * TEX2D(xy + vec2(one.x, 0.0)) + coeffs.w * TEX2D(xy + vec2(2.0 * one.x, 0.0)),0.0,1.0);
37                col2 = clamp(coeffs.x * TEX2D(xy + vec2(-one.x,one.y)) + coeffs.y * TEX2D(xy + vec2(0.0, one.y)) + coeffs.z * TEX2D(xy + one) + coeffs.w * TEX2D(xy + vec2(2.0 * one.x, one.y)),0.0,1.0);
38                col = pow(col, vec4(gamma));
39                col2 = pow(col2, vec4(gamma));
40
41                vec4 wid = 2.0 + 2.0 * pow(col, vec4(4.0));
42                vec4 weights = vec4(uv_ratio.y/0.3);
43                weights = 0.51*exp(-pow(weights*sqrt(2.0/wid),wid))/0.3/(0.6+0.2*wid);
44                wid = 2.0 + 2.0 * pow(col2,vec4(4.0));
45                vec4 weights2 = vec4((1.0-uv_ratio.y)/0.3);
46                weights2 = 0.51*exp(-pow(weights2*sqrt(2.0/wid),wid))/0.3/(0.6+0.2*wid);
47
48                vec4 mcol = vec4(1.0);
49                if ( mod(gl_TexCoord[0].x*rubyOutputSize.x*rubyTextureSize.x/rubyInputSize.x,2.0) < 1.0)
50                  mcol.g = 0.7;
51                else
52                  mcol.rb = vec2(0.7);
53
54                gl_FragColor = pow(mcol*(col * weights + col2 * weights2), vec4(1.0/2.2));
55        }

Reply 1 of 9, by Yushatak

Posted on 2011-01-21, 15:08

Yushatak Offline

Rank Member

Rank: Member
Posts: 201
Joined: 2010-05-29, 18:39

Some progress...

1        #include "scaling.inc"
2	string name : NAME = "CRT1x";
3	float scaling : SCALING = 1.0;
4	string combineTechnique : COMBINETECHNIQUE = "CRT1x";
5	float2 TexCoord : TEXCOORD0;
6
7        #define TEX2D(c) texture2D(SourceSampler,(c))
8        #define PI 3.141592653589
9        #define phase 0.0
10        #define gamma 2.7
11
12        #define distortion 0.2
13
14
15        void main()
16        {
17                float2 xy =  TexCoord[0] + (TexCoord[0]*TexelSize/SourceDims - 0.5 * (dot(TexCoord[0]*TexelSize/SourceDims - 0.5, TexCoord[0]*TexelSize/SourceDims - 0.5) + distortion * dot(TexCoord[0]*TexelSize/SourceDims - 0.5, TexCoord[0]*TexelSize/SourceDims - 0.5) * dot(TexCoord[0]*TexelSize/SourceDims - 0.5, TexCoord[0]*TexelSize/SourceDims - 0.5)) * distortion)*SourceDims/TexelSize;
18
19
20                float2 one          = 1.0/TexelSize;
21
22
23                float2 uv_ratio     = frac(xy*TexelSize);
24xy.x = floor(xy.x/one.x)*one.x;
25
26
27                float4 col, col2;
28                float4 coeffs = float4(1.0 + uv_ratio.x, uv_ratio.x, 1.0 - uv_ratio.x, 2.0 - uv_ratio.x);
29                coeffs = mix((sin(PI * coeffs) * sin(PI * coeffs / 2.0)) / (coeffs * coeffs), float4(1.0), lessThan(abs(coeffs), float4(0.01)));
30                coeffs = coeffs / (coeffs.x+coeffs.y+coeffs.z+coeffs.w);
31
32                col  = clamp(coeffs.x * TEX2D(xy + float2(-one.x,0.0)) + coeffs.y * TEX2D(xy) + coeffs.z * TEX2D(xy + float2(one.x, 0.0)) + coeffs.w * TEX2D(xy + float2(2.0 * one.x, 0.0)),0.0,1.0);
33                col2 = clamp(coeffs.x * TEX2D(xy + float2(-one.x,one.y)) + coeffs.y * TEX2D(xy + float2(0.0, one.y)) + coeffs.z * TEX2D(xy + one) + coeffs.w * TEX2D(xy + float2(2.0 * one.x, one.y)),0.0,1.0);
34                col = pow(col, float4(gamma));
35                col2 = pow(col2, float4(gamma));
36
37                float4 wid = 2.0 + 2.0 * pow(col, float4(4.0));
38                float4 weights = float4(uv_ratio.y/0.3);
39                weights = 0.51*exp(-pow(weights*sqrt(2.0/wid),wid))/0.3/(0.6+0.2*wid);
40                wid = 2.0 + 2.0 * pow(col2,float4(4.0));
41                float4 weights2 = float4((1.0-uv_ratio.y)/0.3);
42                weights2 = 0.51*exp(-pow(weights2*sqrt(2.0/wid),wid))/0.3/(0.6+0.2*wid);
43
44                float4 mcol = float4(1.0);
45                if ( mod(TexCoord[0].x*SourceDims.x*TexelSize.x/SourceDims.x,2.0) < 1.0)
46                  mcol.g = 0.7;
47                else
48                  mcol.rb = float2(0.7);
49
50                gl_FragColor = pow(mcol*(col * weights + col2 * weights2), float4(1.0/2.2));
51        }
52	
53	technique CRT1x
54	{
55	pass P0
56	{
57	VertexShader = compile vs_2_0 main();
58	}
59	}

Current Error:
Line 30, incorrect number of arguments to numeric-type contstructor.

Edit: This is a bruteforce attack on shader language, btw. I know neither GLSL nor HLSL, just applying general progamming theory/experience with Google as supplement..

Reply 2 of 9, by Yushatak

Posted on 2011-01-21, 17:10

Yushatak Offline

Rank Member

Rank: Member
Posts: 201
Joined: 2010-05-29, 18:39

Defeated that line.

1        #include "scaling.inc"
2	string name : NAME = "CRT1x";
3	float scaling : SCALING = 1.0;
4	string combineTechnique : COMBINETECHNIQUE = "CRT1x";
5	float2 TexCoord : TEXCOORD0;
6
7        #define TEX2D(c) texture2D(SourceSampler,(c))
8        #define PI 3.141592653589
9        #define phase 0.0
10        #define gamma 2.7
11
12        #define distortion 0.2
13
14
15        void main()
16        {
17                float2 xy =  TexCoord[0] + (TexCoord[0]*TexelSize/SourceDims - 0.5 * (dot(TexCoord[0]*TexelSize/SourceDims - 0.5, TexCoord[0]*TexelSize/SourceDims - 0.5) + distortion * dot(TexCoord[0]*TexelSize/SourceDims - 0.5, TexCoord[0]*TexelSize/SourceDims - 0.5) * dot(TexCoord[0]*TexelSize/SourceDims - 0.5, TexCoord[0]*TexelSize/SourceDims - 0.5)) * distortion)*SourceDims/TexelSize;
18
19
20                float2 one          = 1.0/TexelSize;
21
22
23                float2 uv_ratio     = frac(xy*TexelSize);
24		xy.x = floor(xy.x/one.x)*one.x;
25
26
27                float4 col, col2;
28                float4 coeffs = float4(1.0 + uv_ratio.x, uv_ratio.x, 1.0 - uv_ratio.x, 2.0 - uv_ratio.x);
29		coeffs = ( 1.0 - (abs(coeffs) < float4(0.01,0.01,0.01,0.01)) )* ((sin(PI * coeffs) * sin(PI * coeffs / 2.0)) / (coeffs * coeffs)) + (abs(coeffs) < float4(0.01,0.01,0.01,0.01)) * float4(1.0,1.0,1.0,1.0);
30                
31                coeffs = coeffs / (coeffs.x+coeffs.y+coeffs.z+coeffs.w);
32
33                col  = clamp(coeffs.x * TEX2D(xy + float2(-one.x,0.0)) + coeffs.y * TEX2D(xy) + coeffs.z * TEX2D(xy + float2(one.x, 0.0)) + coeffs.w * TEX2D(xy + float2(2.0 * one.x, 0.0)),0.0,1.0);
34                col2 = clamp(coeffs.x * TEX2D(xy + float2(-one.x,one.y)) + coeffs.y * TEX2D(xy + float2(0.0, one.y)) + coeffs.z * TEX2D(xy + one) + coeffs.w * TEX2D(xy + float2(2.0 * one.x, one.y)),0.0,1.0);
35                col = pow(col, float4(gamma));
36                col2 = pow(col2, float4(gamma));
37
38                float4 wid = 2.0 + 2.0 * pow(col, float4(4.0));
39                float4 weights = float4(uv_ratio.y/0.3);
40                weights = 0.51*exp(-pow(weights*sqrt(2.0/wid),wid))/0.3/(0.6+0.2*wid);
41                wid = 2.0 + 2.0 * pow(col2,float4(4.0));
42                float4 weights2 = float4((1.0-uv_ratio.y)/0.3);
43                weights2 = 0.51*exp(-pow(weights2*sqrt(2.0/wid),wid))/0.3/(0.6+0.2*wid);
44
45                float4 mcol = float4(1.0);
46                if ( mod(TexCoord[0].x*SourceDims.x*TexelSize.x/SourceDims.x,2.0) < 1.0)
47                  mcol.g = 0.7;
48                else
49                  mcol.rb = float2(0.7);
50
51                gl_FragColor = pow(mcol*(col * weights + col2 * weights2), float4(1.0/2.2));
52        }
53	
54	technique CRT1x
55	{
56	pass P0
57	{
58	VertexShader = compile vs_2_0 main();
59	}
60	}

New Error:
Line 33, Constructors only defined for numeric base types.

Reply 3 of 9, by Yushatak

Posted on 2011-01-21, 17:55

Yushatak Offline

Rank Member

Rank: Member
Posts: 201
Joined: 2010-05-29, 18:39

1        #include "scaling.inc"
2	string name : NAME = "CRT1x";
3	float scaling : SCALING = 1.0;
4	string combineTechnique : COMBINETECHNIQUE = "CRT1x";
5	float2 TexCoord : TEXCOORD0;
6
7        #define tex2D(c) texture2D(SourceSampler,(c))
8        #define PI 3.141592653589
9        #define phase 0.0
10        #define gamma 2.7
11
12        #define distortion 0.2
13
14
15        void main()
16        {
17                float2 xy =  TexCoord[0] + (TexCoord[0]*TexelSize/SourceDims - 0.5 * (dot(TexCoord[0]*TexelSize/SourceDims - 0.5, TexCoord[0]*TexelSize/SourceDims - 0.5) + distortion * dot(TexCoord[0]*TexelSize/SourceDims - 0.5, TexCoord[0]*TexelSize/SourceDims - 0.5) * dot(TexCoord[0]*TexelSize/SourceDims - 0.5, TexCoord[0]*TexelSize/SourceDims - 0.5)) * distortion)*SourceDims/TexelSize;
18
19
20                float2 one          = 1.0/TexelSize;
21
22
23                float2 uv_ratio     = frac(xy*TexelSize);
24		xy.x = floor(xy.x/one.x)*one.x;
25		
26
27                float4 coeffs = float4(1.0 + uv_ratio.x, uv_ratio.x, 1.0 - uv_ratio.x, 2.0 - uv_ratio.x);
28		coeffs = ( 1.0 - (abs(coeffs) < float4(0.01,0.01,0.01,0.01)) )* ((sin(PI * coeffs) * sin(PI * coeffs / 2.0)) / (coeffs * coeffs)) + (abs(coeffs) < float4(0.01,0.01,0.01,0.01)) * float4(1.0,1.0,1.0,1.0);
29                coeffs = coeffs / (coeffs.x+coeffs.y+coeffs.z+coeffs.w);
30		
31		float4 col, col2;
32		col=clamp((coeffs.x * tex2D(xy + float2(-one.x,0.0)) + coeffs.y * tex2D(xy) + coeffs.z * tex2D(xy + float2(one.x, 0.0)) + coeffs.w * tex2D(xy + float2(2.0 * one.x, 0.0))),0.0,1.0);
33                col2  = clamp((coeffs.x * tex2D(xy + float2(-one.x,one.y)) + coeffs.y * tex2D(xy + float2(0.0, one.y)) + coeffs.z * tex2D(xy + one) + coeffs.w * tex2D(xy + float2(2.0 * one.x, one.y))),0.0,1.0);
34                col = pow(col, float4(gamma));
35                col2 = pow(col2, float4(gamma));
36
37                float4 wid = 2.0 + 2.0 * pow(col, float4(4.0));
38                float4 weights = float4(uv_ratio.y/0.3);
39                weights = 0.51*exp(-pow(weights*sqrt(2.0/wid),wid))/0.3/(0.6+0.2*wid);
40                wid = 2.0 + 2.0 * pow(col2,float4(4.0));
41                float4 weights2 = float4((1.0-uv_ratio.y)/0.3);
42                weights2 = 0.51*exp(-pow(weights2*sqrt(2.0/wid),wid))/0.3/(0.6+0.2*wid);
43
44                float4 mcol = float4(1.0);
45                if ( mod(TexCoord[0].x*SourceDims.x*TexelSize.x/SourceDims.x,2.0) < 1.0)
46                  mcol.g = 0.7;
47                else
48                  mcol.rb = float2(0.7);
49
50                gl_FragColor = pow(mcol*(col * weights + col2 * weights2), float4(1.0/2.2));
51        }
52	
53	technique CRT1x
54	{
55	pass P0
56	{
57	PixelShader = compile ps_2_0 main();
58	}
59	}

I'm lost. Can't fix this error... I know it's something simple, but I just don't get it.

Something to do with "#define tex2D(c) texture2D(SourceSampler,(c))"? If I remove it it complains a bit..

Reply 4 of 9, by gulikoza

Posted on 2011-01-21, 19:08

gulikoza Offline

Rank Oldbie

Rank: Oldbie
Posts: 1705
Joined: 2004-06-25, 14:53

Just a wild guess, save tex2D result to a variable and do not use the define?

http://www.si-gamer.net/gulikoza

Reply 5 of 9, by Yushatak

Posted on 2011-01-22, 01:49

Yushatak Offline

Rank Member

Rank: Member
Posts: 201
Joined: 2010-05-29, 18:39

Tried that. Putting tex2D results into variables makes no difference, and removing the define produces:

"cannot implicitly convert from 'const float2' to 'const sampler2D'. (line 32)

I'm afraid I don't know how to EXplicitly convert these.. I come from a world called Python where types just poof into one another at will when it's convenient.

I presumed due to my ignorance that the define was intended to deal with that.

Reply 6 of 9, by gulikoza

Posted on 2011-01-22, 12:12

gulikoza Offline

Rank Oldbie

Rank: Oldbie
Posts: 1705
Joined: 2004-06-25, 14:53

If you remove the define, you call real tex2D function which requires 2 parameters - sampler and coordinates. You are only passing the coordinates.

I'm not even sure HLSL (the directx shading language) has texture2D() function, I cannot find any reference to it (GLSL on the other hand - the OpenGL shading language - has it), the texture sampling function is named tex2D.

So...try replacing all tex2D(c) with tex2D(sampler, c). If you still get the "constructors only defined for numeric base types" error, save all the texture samples to a variable and use that.

HLSL is running on the GPU. GPUs are quite specific and limited and that has to be taken into account. I assume you cannot mix arithmetic and texture operations in a single statement that's why you need to first save the texture lookup data and later use it. But you might run out of registers if there's too much samples...

http://www.si-gamer.net/gulikoza

Reply 7 of 9, by gulikoza

Posted on 2011-01-22, 12:18

gulikoza Offline

Rank Oldbie

Rank: Oldbie
Posts: 1705
Joined: 2004-06-25, 14:53

Further more...it seems you are indeed porting a GLSL program to HLSL. HLSL does not have uniform and vecX types, I just noticed from the original program. Also there is no main() function in HLSL. Please take a look at some existing .fx file and try to do something similar.

http://www.si-gamer.net/gulikoza

Reply 8 of 9, by Yushatak

Posted on 2011-01-28, 01:38

Yushatak Offline

Rank Member

Rank: Member
Posts: 201
Joined: 2010-05-29, 18:39

msdn.microsoft.com/en-us/library/ff471376(v=vs.85).aspx

I've been using this as reference, and it does indeed have a tex2d function.

Good call on it requiring two parameters, I will try that..

As for vecX types, I blindly replaced them all with floatX types. I'm not sure what effect that will have, but afaik it will let me at least bypass the problem and get the shader into a functional state.

Reply 9 of 9, by gulikoza

Posted on 2011-01-28, 07:09

gulikoza Offline

Rank Oldbie

Rank: Oldbie
Posts: 1705
Joined: 2004-06-25, 14:53

Yushatak wrote:
As for vecX types, I blindly replaced them all with floatX types.

That seems fine 😀

http://www.si-gamer.net/gulikoza

Go to top of page Go to top of page

Back to DOSBox Development