Buffer overflow \ VOGONS

Buffer overflow

Topic actions

First post, by MatureTech

Posted on 2013-11-06, 03:21

MatureTech Offline

Rank Newbie

Rank: Newbie
Posts: 55
Joined: 2013-10-09, 13:51

Current SVN, trunk/src/gui/sdl_mapper.cpp, lines 2394 and 2395. button_pressed belongs in the 8 loop. In 0.74, bug exists at lines 2388 and 2389.

Also, +1 to removing the 4-axis limit as discussed here. The 8-way hat on the Logitech Extreme 3D Pro shows up as axes 5 and 6 and I want to use it as the second joystick in Llamatron.

Thanks.

ISA go Bragh™

Reply 1 of 1, by ripsaw8080

Posted on 2013-11-06, 10:58

ripsaw8080 Offline

Rank DOSBox Author

Rank: DOSBox Author
Posts: 5094
Joined: 2006-04-25, 23:24

Yes, and in the 8-loop there is a typo where the first stick is initialized twice, leaving the second stick uninitialized. The issues were reported on SourceForge: http://sourceforge.net/p/dosbox/patches/257/

Because the struct is initialized with false and zero values, memset() should work nicely in place of the loops:

1memset(&virtual_joysticks,0,sizeof(virtual_joysticks));

Go to top of page Go to top of page

Back to DOSBox Development