Nice, thanks 😀

Very cool indeed, works perfectly.

Adding to your note about Archimedean Dynasty: the game seems to display graphics fine using Zeckensacks wrapper, although it has windowing issues (at least for me, controlling the game with his wrapper is impossible).

Seems like OpenGlide has a variety of issues as of now... Hope to be able to fix a couple of them.

Thanks, haven't tried it with zeckensack's yet 😉
Try to set the configuration to render in the game window (the default option is to render in it's own window). But it's still somewhat annoying since it will switch resolutions. Somebody has to hexedit the dll and NOP that ChangeDisplaySetting call 😜

Oh, I forgot to mention I am compiling with VC8, and for anyone who wants to do that, as well:

1.) Add the files which the patch adds to the source tree to the VC project file, namely:
src\hardware\glide.cpp
include\glide.h
include\glidedef.h

2.) Change these 2 lines in glide.cpp:
Line 393: typedef FxBool FX_CALL (*pfxSplashInit)(FxU32 hWnd, FxU32 screenWidth, FxU32 screenHeight,
To: typedef FxBool (FX_CALL *pfxSplashInit)(FxU32 hWnd, FxU32 screenWidth, FxU32 screenHeight,

Line 395: typedef void FX_CALL (*pfxSplash)(float x, float y, float w, float h, FxU32 frameNumber);
To: typedef void (FX_CALL *pfxSplash)(float x, float y, float w, float h, FxU32 frameNumber);

Hi,

I just tried the patch on Linux, but it fails when compiling glide.cpp:

g++ -DHAVE_CONFIG_H -I. -I../.. -I../../include -I/usr/include/SDL -D_GNU_SOURCE=1 -D_REENTRANT -g -O2 -MT glide.o -MD -MP -MF .deps/glide.Tpo -c -o glide.o glide.cpp
../../include/sdk2_glide.h:53: error: expected `)' before ‘*’ token
glide.cpp: In constructor ‘GLIDE::GLIDE(Section*)’:
glide.cpp:204: error: expected primary-expression before ‘void’
glide.cpp:204: error: expected `)' before ‘void’
glide.cpp: At global scope:
glide.cpp:393: error: typedef ‘__stdcall’ is initialized (use __typeof__ instead)
glide.cpp:393: error: ‘pfxSplashInit’ was not declared in this scope
glide.cpp:395: error: typedef ‘__stdcall’ is initialized (use __typeof__ instead)
glide.cpp:395: error: ‘pfxSplash’ was not declared in this scope

and then the make process fails, quitting with an error...

Looking at line 53 of sdk2_glide.h, the "culprit" is this one:

typedef void (FX_CALL *GrProc)();

It probably isn't a matter of g++ 4.1 vs 3.4, because I tried them both with the same result: besides, I successfully installed Openglide CVS using 4.1.

What could be the reason?
Thanks in advance, hope to hear from you soon!

There's one ) missing at glide.cpp:204. The 393 error is probably the same as qsonic reported, will check what's wrong at sdk2_glide.h:53 and fix my patch accordingly 😀

I managed to turn around the compilation problems this way:

1) I forced the defines of FX_ENTRY and FX_CALL to
#define FX_ENTRY extern
#define FX_CALL
in sdk2_3dfx.h, because otherwise it kept introducing __stdcall which doesn't exist in Linux;

2) I didn't notice the mixxing bracket at line 204, you're right; however, I just removed the (void*) caster, since dlsym already returns a void*, and it compiled fine.

Unfortunately, dosbox crashes when trying to start it...

CONFIG:Loading primary settings from config file dosbox.conf ALSA:Client initialised [17:0] MIDI:Opened device:alsa Glide:Warnin […]
Show full quote

CONFIG:Loading primary settings from config file dosbox.conf
ALSA:Client initialised [17:0]
MIDI:Opened device:alsa
Glide:Warning, unable to load grSstConfigPipeline from glide2x
Glide:Warning, unable to load grSstVidMode from glide2x
Glide:Warning, unable to load guMPDrawTriangle from glide2x
Glide:Warning, unable to load guMPInit from glide2x
Glide:Warning, unable to load guMPTexCombineFunction from glide2x
Glide:Warning, unable to load guMPTexSource from glide2x
Glide:Warning, unable to load guMovieSetName from glide2x
Glide:Warning, unable to load guMovieStart from glide2x
Glide:Warning, unable to load guMovieStop from glide2x
Segmentation fault

This is the backtrace:

[Thread debugging using libthread_db enabled] [New Thread -1208506640 (LWP 13227)] [New Thread 25160592 (LWP 13230)] CONFIG:Load […]
Show full quote

[Thread debugging using libthread_db enabled]
[New Thread -1208506640 (LWP 13227)]
[New Thread 25160592 (LWP 13230)]
CONFIG:Loading primary settings from config file dosbox.conf
[New Thread 35650448 (LWP 13231)]
ALSA:Client initialised [17:0]
MIDI:Opened device:alsa
Glide:Warning, unable to load grSstConfigPipeline from glide2x
Glide:Warning, unable to load grSstVidMode from glide2x
Glide:Warning, unable to load guMPDrawTriangle from glide2x
Glide:Warning, unable to load guMPInit from glide2x
Glide:Warning, unable to load guMPTexCombineFunction from glide2x
Glide:Warning, unable to load guMPTexSource from glide2x
Glide:Warning, unable to load guMovieSetName from glide2x
Glide:Warning, unable to load guMovieStart from glide2x
Glide:Warning, unable to load guMovieStop from glide2x

Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread -1208506640 (LWP 13227)]
0x00ceff5c in malloc_consolidate () from /lib/libc.so.6
(gdb) bt
#0 0x00ceff5c in malloc_consolidate () from /lib/libc.so.6
#1 0x00cf20bd in _int_malloc () from /lib/libc.so.6
#2 0x00cf3ebe in malloc () from /lib/libc.so.6
#3 0x07a42557 in operator new () from /usr/lib/libstdc++.so.6
#4 0x07a1dc0b in std::string::_Rep::_S_create () from /usr/lib/libstdc++.so.6
#5 0x07a1e7a8 in std::string::_Rep::_M_clone () from /usr/lib/libstdc++.so.6
#6 0x07a1f358 in std::string::reserve () from /usr/lib/libstdc++.so.6
#7 0x07a18003 in std::basic_stringbuf<char, std::char_traits<char>, std::allocator<char> >::overflow () from /usr/lib/libstdc++.so.6
#8 0x07a1cdd1 in std::basic_streambuf<char, std::char_traits<char> >::xsputn
() from /usr/lib/libstdc++.so.6
#9 0x07a1217b in std::operator<< <std::char_traits<char> > ()
from /usr/lib/libstdc++.so.6
#10 0x080e8841 in GLIDE_Init (sec=0x9e92158)
at /usr/lib/gcc/i386-redhat-linux/3.4.6/../../../../include/c++/3.4.6/bits/ostream.tcc:86
#11 0x081c4f5b in Section::ExecuteInit (this=0x9e92158, initall=true)
at /usr/lib/gcc/i386-redhat-linux/3.4.6/../../../../include/c++/3.4.6/bits/stl_list.h:131
#12 0x081c4f95 in Config::Init (this=0xbfb88070)
at /usr/lib/gcc/i386-redhat-linux/3.4.6/../../../../include/c++/3.4.6/bits/stl_list.h:212
#13 0x080fa877 in main (argc=1, argv=0xbfb88134) at sdlmain.cpp:1499

The dosbox.conf I used is exactly the same as the one I used wih the stable dosbox, with the only addons being the [glide] context copied from ykhwong's one.

Any idea what it could be?

Okay...fixed the compilation problems, the patch is updated in the first post.
But this crash is strange...I can't reproduce it, and it crashes somewhere inside malloc??

Just tried recompiling with your new patch, and now it compiles fine without having to touch anything. I also added --enable-debug to see if it gave me more info about the crash. However, now it didn't crash at all!
So I made a few tests:

The 3dfx diagnostic kit tests worked fine;

Tomb Raider also did start fine, even if it crashed when leaving the game;

Redguard instead crashed after leaving the game menu, which, as it was in ykhwong's build, was corrupt anyway (the main diary page is invisible, you can see the side of the book on the right).

But it's a great step ahead from the previous issues 😀

I recompiled disabling the debug, and dosbox crashes again on startup... it looks like debug mode made it more fault tolerant. 😕

Crashes inside malloc usually result from a buffer overrun that has clobbered malloc's data structures. A double free might also apply, but IIRC modern glibcs should detect those.

BTW, is that a 32-bit or a 64-bit build?

Hi Moe,
it's a 32-bit build, in a Fedora 7 OS. Let me know if there's anything I can do to help you sort out the problem.

Investigating the issues another bit, I found out a line where the problem might be. The backtrace reports:

1(gdb) bt
2#0  0x00ceff5c in malloc_consolidate () from /lib/libc.so.6
3#1  0x00cf20bd in _int_malloc () from /lib/libc.so.6
4#2  0x00cf3ebe in malloc () from /lib/libc.so.6
5#3  0x07a42557 in operator new () from /usr/lib/libstdc++.so.6
6#4  0x07a1dc0b in std::string::_Rep::_S_create () from /usr/lib/libstdc++.so.6
7#5  0x07a1e7a8 in std::string::_Rep::_M_clone () from /usr/lib/libstdc++.so.6
8#6  0x07a1f358 in std::string::reserve () from /usr/lib/libstdc++.so.6
9#7  0x07a18003 in std::basic_stringbuf<char, std::char_traits<char>, std::allocator<char> >::overflow () from /usr/lib/libstdc++.so.6
10#8  0x07a1cdd1 in std::basic_streambuf<char, std::char_traits<char> >::xsputn
11    () from /usr/lib/libstdc++.so.6
12#9  0x07a1217b in std::operator<< <std::char_traits<char> > ()
13   from /usr/lib/libstdc++.so.6
14#10 0x080eca53 in GLIDE (this=0xabf5c80, configuration=0xabc2158)
15    at glide.cpp:217
16#11 0x080ec309 in GLIDE_Init (sec=0xabc2158) at glide.cpp:268
17#12 0x081d4655 in Section::ExecuteInit (this=0xabc2158, initall=true)
18    at setup.cpp:271
19#13 0x081d4ca8 in Config::Init (this=0xbfd6f25c) at setup.cpp:256
20#14 0x080ff887 in main (argc=Cannot access memory at address 0x1
21) at sdlmain.cpp:1499

The overflow appears when compiling a string at the line:

1	ostringstream temp;
2	temp << "SET GLIDE=" << hex << setw(3) << glide_base << ends;

I have no idea why such an operation should fail, I guess temp is correctly initialized... however, considering glide_base is statically set up as 0x300, I removed those lines and forced a static

1    	autoexecline.Install("SET GLIDE=0x300");

which should do the same.
Doing this, dosbox stops crashing at that point but crashes somewhere else:

1Program received signal SIGSEGV, Segmentation fault.
2[Switching to Thread -1208301840 (LWP 14368)]
30x00ceff5c in malloc_consolidate () from /lib/libc.so.6
4(gdb) bt
5#0  0x00ceff5c in malloc_consolidate () from /lib/libc.so.6
6#1  0x00cf20bd in _int_malloc () from /lib/libc.so.6
7#2  0x00cf3ebe in malloc () from /lib/libc.so.6
8#3  0x07a42557 in operator new () from /usr/lib/libstdc++.so.6
9#4  0x080aa2a4 in DOS_SetupFiles () at dos_files.cpp:1091
10#5  0x080a7690 in DOS (this=0xa0a0630, configuration=0xa06b278) at dos.cpp:1089
11#6  0x080a5149 in DOS_Init (sec=0xa06b278) at dos.cpp:1122
12#7  0x081d40e5 in Section::ExecuteInit (this=0xa06b278, initall=true)
13    at setup.cpp:271
14#8  0x081d4738 in Config::Init (this=0xbff72c5c) at setup.cpp:256
15#9  0x080ff317 in main (argc=Cannot access memory at address 0x1
16) at sdlmain.cpp:1499

These errors are related to setting up the file systems, so I really have no idea how I could mess around with this...

I hope all this helped, hope to hear from you soon.

your stack is allready corrupt before that.
have you tried running it through valgrind ?

The autoexec line is not even needed. And it is created the same way as other autoexec lines (sblaster...)
Something seems very wrong here. If you start with glide disabled (or even without the patch compiled in), does dosbox work??

I just did it, you can find the output in the attached file. Running through Valgrind doesn't make dosbox crash (as the dosbox --enable-debug did). However, trying one of the 3dfx tests freezes dosbox.

My guess is the problem starts here:

1==14936== Invalid write of size 4
2==14936==    at 0x80EC8CB: GLIDE::GLIDE(Section*) (glide.cpp:204)
3==14936==    by 0x80EC308: GLIDE_Init(Section*) (glide.cpp:268)
4==14936==    by 0x81D4664: Section::ExecuteInit(bool) (setup.cpp:271)
5==14936==    by 0x81D4CB7: Config::Init() (setup.cpp:256)
6==14936==    by 0x80FF896: main (sdlmain.cpp:1499)
7==14936==  Address 0x4D0F384 is 0 bytes after a block of size 516 alloc'd
8==14936==    at 0x40054E5: malloc (vg_replace_malloc.c:149)
9==14936==    by 0x80EC88D: GLIDE::GLIDE(Section*) (glide.cpp:192)
10==14936==    by 0x80EC308: GLIDE_Init(Section*) (glide.cpp:268)
11==14936==    by 0x81D4664: Section::ExecuteInit(bool) (setup.cpp:271)
12==14936==    by 0x81D4CB7: Config::Init() (setup.cpp:256)
13==14936==    by 0x80FF896: main (sdlmain.cpp:1499)
14==14936== 

but I'm not sure of it...

Yes, with glide disabled dosbox works just fine, so it surely is a problem in the glide initialization somewhere...

That malloc might indeed be 1 element too small 😀

try

fn_pt = (void**)malloc(sizeof(void*)*(GLIDE_END-GLIDE_START)+1);

if it 1 element shouldn't it be
fn_pt = (void**)malloc(sizeof(void*)*(GLIDE_END-GLIDE_START+1));