cookertron wrote on Yesterday, 17:02:

FIXED and released! […]
Show full quote

Yoghoo wrote on Yesterday, 15:23:

cookertron wrote on Yesterday, 14:48:

Version 0.64.0 Fixes: […]
Show full quote

Version 0.64.0 Fixes:

• Shell-to-DOS Jemmex crash fix
• BSS-to-segment migration: Moved shadow_buf (4 KB) and doc_table (3 KB) to separately-allocated DOS segments via INT 21h/48h, reclaiming 7 KB from the 64 KB COM segment

This version does not work at all for me (with or without adding a file name on the command line). I see only the mouse and nothing else.

FIXED and released!

Version 0.64 now works with 4DOS. All tests pass!
The issue was that 4DOS doesn't clear memory when allocating it out so the buffers contained garage data which corrupted specific tests. A better explanation is in the changelog if you're interested .😎

NOW, here's a question for everyone... how would you feel about a DOSBox-X host shared clipboard? This means you can copy text from the host system (Win/Linux) directly into TEDIT and vice versa. I'd love to hear your opinions.

Sorry but it's not fixed here. Still the same problem.

Regarding host shared clipboard it's not really for me. I only use Dosbox-X to quickly test or compile something. The rest I do on real retro pc's. 😀

Yoghoo wrote on Yesterday, 17:15:

cookertron wrote on Yesterday, 17:02:

FIXED and released! […]
Show full quote

Yoghoo wrote on Yesterday, 15:23:

This version does not work at all for me (with or without adding a file name on the command line). I see only the mouse and nothing else.

FIXED and released!

Version 0.64 now works with 4DOS. All tests pass!
The issue was that 4DOS doesn't clear memory when allocating it out so the buffers contained garage data which corrupted specific tests. A better explanation is in the changelog if you're interested .😎

NOW, here's a question for everyone... how would you feel about a DOSBox-X host shared clipboard? This means you can copy text from the host system (Win/Linux) directly into TEDIT and vice versa. I'd love to hear your opinions.

Sorry but it's not fixed here. Still the same problem.

Regarding host shared clipboard it's not really for me. I only use Dosbox-X to quickly test or compile something. The rest I do on real retro pc's. 😀

I'm really sorry, I didn't commit the new fix to GitHub. I've done it now 😔

cookertron wrote on Yesterday, 17:32:

Yoghoo wrote on Yesterday, 17:15:

cookertron wrote on Yesterday, 17:02:

FIXED and released! […]
Show full quote

FIXED and released!

Version 0.64 now works with 4DOS. All tests pass!
The issue was that 4DOS doesn't clear memory when allocating it out so the buffers contained garage data which corrupted specific tests. A better explanation is in the changelog if you're interested .😎

NOW, here's a question for everyone... how would you feel about a DOSBox-X host shared clipboard? This means you can copy text from the host system (Win/Linux) directly into TEDIT and vice versa. I'd love to hear your opinions.

Sorry but it's not fixed here. Still the same problem.

Regarding host shared clipboard it's not really for me. I only use Dosbox-X to quickly test or compile something. The rest I do on real retro pc's. 😀

I'm really sorry, I didn't commit the new fix to GitHub. I've done it now 😔

No worries. Issues are indeed fixed. Only it uses almost 280KB of memory when I do a dos shell. Seems a bit excessive but further than that it works fine.

A 4DOS compatibility... Wow! The latest TEDIT version 0.64 is really good 😀 Also the new Agent86 0.20.1 works fine even with the older code.

Just a few minor bugs: for me <Ctrl>+<Alt>+<S> ("Close all...") and <Ctrl>+<Alt>+<S> ("Save all...") keyboard shortcuts do not work at all. And <Ctrl>+<Shift>+<W> combo works as <Ctrl>+<W> ("Close") - probably not really a bug. But <Shift>+<Tab> now works fine.

And why not some <Fn> or key combo assigned for "Shell to DOS and some shortcuts for "Load project..." and "Save project..."?

For the DOSBox-X clipboard sharing - I'm not sure, if you have to use the freed bits for such a functionality. I use DOSBox and DOSBox-X for quick tests and DOS compile/build only.

@cookertron, do you mind, if I keep tinkering with the old 0.57 version source code?

aVd wrote on Yesterday, 18:59:

Just a few minor bugs: for me <Ctrl>+<Alt>+<S> ("Close all...") and <Ctrl>+<Alt>+<S> ("Save all...") keyboard shortcuts do not work at all. And <Ctrl>+<Shift>+<W> combo works as <Ctrl>+<W> ("Close") - probably not really a bug.

I'll look in to that, thanks.

aVd wrote on Yesterday, 18:59:

And why not some <Fn> or key combo assigned for "Shell to DOS and some shortcuts for "Load project..." and "Save project..."?

Good point but not sure which key combo to assign - any thoughts?

aVd wrote on Yesterday, 18:59:

For the DOSBox-X clipboard sharing - I'm not sure, if you have to use the freed bits for such a functionality. I use DOSBox and DOSBox-X for quick tests and DOS compile/build only.

Thanks for feedback.

aVd wrote on Yesterday, 18:59:

@cookertron, do you mind, if I keep tinkering with the old 0.57 version source code?

Absolutely not! You do whatever you like with it 😀

@cookertron

Thank you for this new build v0.64 which fixed the JEMMEX issue when shelling.

If I may, can I ask you to please add a small feature? A Unix/Amiga (LF) to Windows/DOS (CR+LF) line ending conversion (back and forth). It would of course, require that when opening a text file to detect and indicate somewhere the current line ending present.

For what it is worth, I am not a DOSBOX user. I use either a real machine, VirtualBox and 86Box and may try any other "complete" x86 PC emulator eventually.

Thanks again for your continued development.

cookertron wrote on Yesterday, 19:21:

aVd wrote on Yesterday, 18:59:

And why not some <Fn> or key combo assigned for "Shell to DOS and some shortcuts for "Load project..." and "Save project..."?

Good point but not sure which key combo to assign - any thoughts?

I have no idea about the "shelling". We may look in some of the countless Norton Commander's clones - most of them (if not all of them) have "start command interpreter" option. Or maybe Ignacio can suggest some suitable keyboard shortcut. As for the project's shortcuts - some popular DOS IDE may be of help too. Old Borland C++ DOS IDE, RHIDE...?

cookertron wrote on Yesterday, 19:21:

aVd wrote on Yesterday, 18:59:

For the DOSBox-X clipboard sharing - I'm not sure, if you have to use the freed bits for such a functionality. I use DOSBox and DOSBox-X for quick tests and DOS compile/build only.

Thanks for feedback.

Seems like Ignacio's suggestion for CR to LF, CR (and backwards) line break convertor will be more useful for me.

cookertron wrote on Yesterday, 19:21:

aVd wrote on Yesterday, 18:59:

@cookertron, do you mind, if I keep tinkering with the old 0.57 version source code?

Absolutely not! You do whatever you like with it 😀

Thank you! It will be only cosmetic work - like rearranging the menu items. And don't worry, I have only basic knowledge in assembly, so I'll not do anything deeper to break your original code entirely 😉

P.S. I think, I found another bug.

After unsuccessful tryout to open some big file and the error message "Out of memory" I got something like empty file in the opened file list:

Wouldn't it be more proper behavior to not open "empty file" at all after this "Out of memory" error?

Also, I'm not sure what to chose as a response for this message:

Just a FYI for someone who wants to change ALT-Q to ALT-X. These lines need to be changed:

1Change line 135: DB 'Quit', 0	To:  DB 'Exit', 0
2Change line 143: DB 'Alt+Q', 0	To:  DB 'Alt+X', 0
3Change line 332: DB 0, 'Q'		To:  DB 1, 'X'
4Change line 334: DB 10h, 0		To:  DB 2Dh, 0

This is for version 0.64 so line numbers can change in upcoming versions. 😀

Made a newer old single-file edit TEDIT version 0.57.2 with new "Search" menu. Now "Edit" and "Search" menus look like this:

Attachment with the modified source code and the compiled com-executable:

Unfortunately I stll can't figure out how to make <Shift>+<Tab> combo to work in dialog boxes in reversed direction.

EDIT: <Shift>+<Tab> problem solved by @cookertron. The latest update for the 0.57.x variant of TEDIT is here.

Release v0.65 - https://github.com/cookertron/TEDIT:

• Menu item 'Quit' renamed to 'Exit' with shortcut changed to ALT-X
• Large document invokes 'Out of Memory' and a ghost document in side panel - fixed. Drops back to previous document.
• Exiting TEDIT with modified documents invokes confusing save dialog. Now says 'Discard unsaved changes?' with options 'Yes|No'
• Shell to DOS shortcut is F8
• All menu shortcuts should now work but this isn't guaranteed 😁

I couldn't work out which shortcut to use for projects so just left it empty. Maybe someone will get inspired 🤷

Before doing anything else I'm going to explore removing the original document from memory altogether. When edits are made to a document the original file isn't touched, it's only when the document is saved. TEDIT walks through the piece table and makes the changes that have accumulated. That's why if you make a lot of changes you'll eventually be prompted to save your work to free up the piece table. It also means the original file doesn't need loading into the memory at all, the text can be read directly from the disk. That's the theory anyway. Let's see how it goes!

aVd wrote on Today, 10:40:

Unfortunately I stll can't figure out how to make <Shift>+<Tab> combo to work in dialog boxes in reversed direction.

By replacing some TUI source code, @cookertron fixed <Shift>+<Tab> navigation problem. So, this 0.57.3 version seems like the final one of the single-file edit TEDIT 0.57.x updates:

Tnanks @cookertron!

Now it's time to test the newest and the coolest multi-file edit TEDIT version 0.65 😀

cookertron wrote on Today, 11:51:

• Menu item 'Quit' renamed to 'Exit' with shortcut changed to ALT-X

Good to see ALT-X by default. 😜

Nothing else to add as everything seems to work fine. But maybe look at the memory consumption when shelling to dos (230+KB without any documents open). Not really an issue for me but it could hinder pc's with limited (free) memory.

I don't know how we missed this. It will be an easy fix, but the "File" menu needs some shortcut-letters rework:

"Edit" menu seems Ok.

Just made a quick test fix for "File" menu partially inspired from BC++ DOS IDE. It looks like this:

1m_file_entries:
2    ; New
3    DW m_str_new, menu_new_handler
4    DB 0, 'N'
5    DW m_str_acc_cn
6    DB 0, 0
7
8    ; Open...
9    DW m_str_open, menu_open_handler
10    DB 0, 'O'
11    DW m_str_acc_co
12    DB 0, 0
13
14    ; Close
15    DW m_str_close, menu_close_handler
16    DB 0, 'C'
17    DW m_str_acc_cw
18    DB 0, 0
19
20    ; Close All
21    DW m_str_closeall, menu_closeall_handler
22    DB 4, 'E' ;  - CHANGED -
23    DW m_str_acc_caw
24    DB 0, 0
25
26    ; ---- divider ----
27    DW 0, 0
28    DB 0, 0
29    DW 0
30    DB 0, 0
31
32    ; Save
33    DW m_str_save, menu_save_handler
34    DB 0, 'S'
35    DW m_str_acc_cs
36    DB 0, 0
37
38    ; Save As...
39    DW m_str_saveas, menu_saveas_handler
40    DB 1, 'A' ;  - CHANGED -
41    DW m_str_acc_css
42    DB 0, 0
43
44    ; Save All
45    DW m_str_saveall, menu_saveall_handler
46    DB 6, 'L' ;  - CHANGED -
47    DW m_str_acc_cas
48    DB 0, 0
49
50    ; ---- divider ----
51    DW 0, 0
52    DB 0, 0
53    DW 0
54    DB 0, 0
55
56    ; Load Project...
57    DW m_str_loadprj, menu_loadprj_handler
58    DB 8, 'J' ;  - CHANGED -
59    DW 0
60    DB 0, 0

61
62    ; Save Project...
63    DW m_str_saveprj, menu_saveprj_handler
64    DB 5, 'P'
65    DW 0
66    DB 0, 0
67
68    ; ---- divider ----
69    DW 0, 0
70    DB 0, 0
71    DW 0
72    DB 0, 0
73
74    ; Shell to DOS
75    DW m_str_shell, menu_shell_handler
76    DB 9, 'D' ;  - CHANGED -
77    DW m_str_acc_f8
78    DB 42h, 0                       ; accelkey=42h (F8 global dispatch)
79
80    ; ---- divider ----
81    DW 0, 0
82    DB 0, 0
83    DW 0
84    DB 0, 0
85
86    ; Exit
87    DW m_str_quit, menu_quit_handler
88    DB 1, 'X'
89    DW m_str_acc_ax
90    DB 2Dh, 0                       ; accelkey=2Dh (Alt+X global dispatch)

This is just a suggestion. Someone may give a better idea for letter assignments in "File" menu.