the gus works fine without the patches.
maybe not with all games. but with enough games.

the mt32 doesn't work without the rom
we could do a replacement rom, but canadacow was never fond of that.
I respect that.

A mt32 is a nice stand alone project. The problem that you can not select that approiate midi driver is of some concern. I have no idea if that is possible for dosbox to select. If not; that's not a problem of dosbox, more a lack on flexibility on your os.

Couldn't midiOutOpen in midi_win32.h be used to select either default MIDI_MAPPER device (as it is done now) or Munt device? But then this would also have to be done for oss and alsa, but I guess the calls are similar...

maybe it can be put in that configline of of the midi stuff.

A mt32 is a nice stand alone project. The problem that you can not select that approiate midi driver is of some concern. I have no idea if that is possible for dosbox to select. If not; that's not a problem of dosbox, more a lack on flexibility on your os.

Lack on flexibility of my OS(win32)?, well, i can think that you never used windows before(i will think that), but as far as i know, a LOT of programs can select the midi device(check for example, duke nukem 3d win32 port, you can get the source...). Midi output selection is a problem of dosbox, not a OS problem(when you said that were you on drugs??).

If you (dosbox team) add support to windows users to select midi out device we will be happy, but as i said before, MacOSX users(and any other user of minority OS except linux) will never get mt32 sound until munt author want to do another device driver. Also, if i install Windows 64, running dosbox on that machine sould be easy, but i won't get mt32 sound until munt author port their driver to that OS(and it't not a trivial task, like a simple recompilation).

what i mean is that is better to dosbox to depend less in what other does and do it yourselves.

Wasn't that exactly what SDL was meant for?

fish wrote:

Wasn't that exactly what SDL was meant for?

SDL's native MIDI interface is GPL'd (a problem for some, not for DOSBox) and I believe Linux only.

I mean isn't SDL made to provide some standard among low-level access routines through many OSes?

The post was targeted at "what i mean is that is better to dosbox to depend less in what other does and do it yourselves."

The problem here is that the MT-32 emulator is written as a pseudo hardware driver.

The driver has to be ported to various OSes in order to be accessible through SDL.

@gulikoza

Did you make it to work(compile munt with dosbox)? As i use your builds it should be interesting if you can get it compiled and working.

Sorry for a delay, I wasn't around.
Here is what I use now for midi_mt32.h, Im not sure if I changed something since that older version.

1/*
2 *  Copyright (C) 2002-2003  The DOSBox Team
3 *
4 *  This program is free software; you can redistribute it and/or modify
5 *  it under the terms of the GNU General Public License as published by
6 *  the Free Software Foundation; either version 2 of the License, or
7 *  (at your option) any later version.
8 *
9 *  This program is distributed in the hope that it will be useful,
10 *  but WITHOUT ANY WARRANTY; without even the implied warranty of
11 *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
12 *  GNU Library General Public License for more details.
13 *
14 *  You should have received a copy of the GNU General Public License
15 *  along with this program; if not, write to the Free Software
16 *  Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.
17 */
18
19#include "mt32emu.h"
20#include "mixer.h"
21
22MT32Emu::Synth *_usesynth;
23MixerChannel *mt32chan;
24
25static void MT32_CallBack(Bitu len) {
26	_usesynth->render((Bit16s *)MixTemp, len);
27	mt32chan->AddSamples_s16(len,(Bit16s *)MixTemp);
28}
29
30static void vdebug(void *data, const char *fmt, va_list list) {
31}
32
33static int report(void *userData, MT32Emu::ReportType type, const void *reportData) {
34	switch(type) {
35	case MT32Emu::ReportType_errorControlROM:
36		LOG(LOG_ALL,LOG_ERROR)("MT32: Couldn't find control files");
37		break;
38	case MT32Emu::ReportType_errorPCMROM:
39		LOG(LOG_ALL,LOG_ERROR)("MT32: Couldn't open MT32_PCM.ROM file");
40		break;
41	default:
42		//LOG(LOG_ALL,LOG_NORMAL)("MT32: Report %d",type);
43		break;
44	}
45	return 0;
46}
47
48
49class MidiHandler_mt32: public MidiHandler {
50private:
51	MT32Emu::Synth *_synth;
52	int _outputRate;
53	bool isOpen;
54
55public:
56	MidiHandler_mt32() : isOpen(false),MidiHandler() {};
57	char * GetName(void) { return "mt32";};
58	bool Open(const char * conf) {
59		MT32Emu::SynthProperties tmpProp;
60		memset(&tmpProp, 0, sizeof(tmpProp));

61		tmpProp.sampleRate = 32000;
62		tmpProp.useDefaultReverb = true;
63		tmpProp.useReverb = true;
64		tmpProp.reverbType = 1;
65		tmpProp.reverbTime = 5;
66		tmpProp.reverbLevel = 3;
67		tmpProp.printDebug = &vdebug;
68		tmpProp.report = &report;
69		_synth = new MT32Emu::Synth();
70		if (_synth->open(tmpProp)==0) {
71			LOG(LOG_ALL,LOG_ERROR)("MT32: Error initialising emulation");
72			return false;
73		}
74		_usesynth=_synth;
75		
76		mt32chan=MIXER_AddChannel(MT32_CallBack,tmpProp.sampleRate,"MT32");
77		mt32chan->Enable(false);
78		return true;
79	};
80	void Close(void) {
81		if (!isOpen) return;
82		_synth->close();
83		delete _synth;
84		_synth = NULL;
85		isOpen=false;
86	};
87	void PlayMsg(Bit8u * msg) {
88		mt32chan->Enable(true);
89		_synth->playMsg(*((Bit32u*) msg));
90	};
91	void PlaySysex(Bit8u * sysex,Bitu len) {
92		LOG_MSG("sysex");
93		if (sysex[0] == 0xf0) {
94			_synth->playSysex(sysex, len);
95		} else {
96			_synth->playSysexWithoutFraming(sysex, len);
97		}
98	};
99};
100
101MidiHandler_mt32 Midi_mt32; 

Here's also a complete source which I compile with vs.net(without project files, though) including latest official munt. Basically only midi.cpp is changed from dosbox files, mt32cvs and freeverb are added to include paths and cpp files added as project files . ROM files should be in dosbox directory when running and midi device set as mt32.

Exaltor wrote:

MacOSX users(and any other user of minority OS except linux) will never get mt32 sound until munt author want to do another device driver

Hey dude, BIG news for you: Munt is open source and mainly developed by an ex-Amiga coder. So go get cracking or find someone to do it for you (I'm sure Richard Bannister wouldn't mind having a look at it). KingGuppy and CanadaCow have been working their asses off to make the softsynth a shared driver precisely to avoid seeing it mangled and brought down-to-date in proprietary projects.

Thanks very much Srecko, i will try it.

if I were to add support for midi selection in win32 ( i browsed through msdn and determined that it's easy to add) what would be the prefered way ?
(it will an option in that config line idea)

do you want to specify the name of the device ? or do you want a device number ?

and should dosbox list the midi devices on startup (so you can get the correct names or device numbers. ?

The device name is more descriptive, but number is shorter.
What about this:
- if it is a number then take it as number
- if it is not number, take it as device name

Listing of MIDI devices is a good idea - it will save some explanation to newbies where to find out what to put there.

Mirek

I don't like an automatic listing. I would rather see something like the mount -cd option which lists device-numbers for use with mount -usecd.

Perhaps the mixer command can be extended to list not only left/right volumes, but also MIDI device names?

hmm mixer would be a good idea.
but then numbers will be fine as well.
hmm will see if can do it.

Using a number is a good idea, also some Windows Frontend can also allow the user to show all midi devices and choose one, and this FE writes to a dosbox config file the number of midi device.

I've gone through this thread and made some notes, perhaps they'll clear a few things up:

- There's nothing illegal about Munt - I don't think this is an issue for anyone.

- I personally have no objection to Munt being directly supported by DOSBox. I have no objection to it not being supported, either.

- I don't have access to operating systems other than Windows and Linux, so I won't personally be able to write a driver for those. Unless someone contributes drivers, those users won't be able to use the MT-32 emulator with DOSBox unless it's integrated.

- The Munt code is very modular; the core is now a static link library which should be extremely portable and easy to integrate. The library basically just has functions for sending MIDI data and retrieving samples - it's very easy to plug into whatever sound environment is available.

- The code in ScummVM is (aside from a few file name changes) identical to that in Munt. I'm a developer on ScummVM, so I maintain both versions. I would prefer for ScummVM to use the link library (a fairly trivial change), but this way is more convenient for people compiling their own version of ScummVM, and not much effort for me to keep it in sync. I'd prefer that Munt source isn't directly included in DOSBox in this way, since I'm unable to maintain it. However, it should be considered that the API is likely to change as the library is still alpha. Optionally linking with the mt32emu link lib and directing users to a specific release would - in my opinion - be best.

- It is a pain to change the default MIDI output device in Windows, and it would be great to see DOSBox providing a method for choosing a specific device to use whether Munt is integrated or not. I have nothing useful to say about how the device should best be specified, sorry.

@Exaltor: No I can't get it to work. I even tried compiling with VS.NET (although I must say MinGW is easier to configure, not to mention it's free 😜). It always crashes when I start a mt32 game. Perhaps I should test this with working Munt as midi device to see if it works at all...

As for selecting midi device...I would rather not complicate much. There's no default tool in Windows to show you midi device number so many users will probably be confused what to enter. So far there hasn't (?) been any request for selecting a midi device (except for mt32), I think most people just use the default. A simple selection in the conf file - use default or mt32 if detected would probably be enough. Although...advanced configuration could probably come in handy sometimes 😀

I agree with KingGuppy. it seems that Dosbox team don't like too much mt32 integration, but as you don't need to change too much in you code, i think that if you add an option at compile time to link with munt library if it's available should be great, so any user of any OS that dosbox is ported to would be happy.

Also selection of midi device in win32 is nice, not only if you don't want to integrate mt32 into dosbox, so at least we can(win32 users) load different soundfonts in diferent devices(my SB has 2 independent devices) and i can shoose for each game wich device to play the midi with.