That's strange, i think the current behaviour is what i remember from back then, maybe somebody can confirm either behaviour on a real system.

What games are affected?

jazztickets is right, confirmed on 386 and pentiummmx

It's more for those games that used the classic "if(kbhit()) key = getch()" combo. I was going through my old games that I made in high school and I noticed something was off. I was using Windows 98 and Borland C++ at the time, so kbhit() would use the windows keyboard delay.

😀 Thanks.

games ZZT keyboard key release issue

doesn't work at my place.
the old key doesn't start repeating here.

the old key shouldn't start repeating (that is how it works on real computer and in winxp's cmd)
only the new key should not stop when you release the old key (like it is in dosbox without the patch)

Anyway the patch doesn't make it as it was on real computer as it introduces a short delay when releasing the old key (the delay doesn't happen on real computer and in winxp's cmd)

Not sure what you mean by "real computer". A computer running MS-DOS?

I wrote the patch on a Windows XP box. My patch mimics the behavior exactly. When you release the old key there's always a delay before the repeat starts on the key that's still down.

ddddddddddddddd(delay when pressing "j")jjjjjjjjjjjjjjjjjjjjjjjjjjjj(no delay when releasing "d")jjjjjjjjjjjjjjjjjjjjjjjjj

I checked that on winxp32bit cmd, win7 64bit cmd, and on pentium 166mmx in msdos6.2 and on 286 with msdos6.2

Interesting. That doesn't happen on any computer i've ever used. What keyboard are you using?

basic 101/102 keyboards, and what are yours? have you tested it now on other computers? cause memory may not be good 😉

All mine are 104 or greater and USB. I have one 104 PS/2 keyboard that I haven't tried but i'm sure that works all the same.

Regardless, the issue at hand is whether the last key should be repeating. I think we can all agree that the patch should be implemented.

i'll look at it again.

heh, usb doesn't even work in dos so i wonder how you used it in the old days 😉 so the ps2 one is definitely worth trying (my ps2 is actually also about 104 as it has win keys), but there were no win keys in the dos days too heh.

Yeah, I don't have any DOS computers around. I'm just talking about Windows XP and beyond.

ok so try the ps2 keyboard please 😀

I am going with robertmo his observations and added a slightly simpler version of your patch to the SVN.

Thanks to both of you.

IMO, the default repeat delay was fine as it was. Some games might work better with less delay, but you can change it with MODE.COM or other keyboard utility programs (that's how it was on real DOS systems). Unless I type light and fast at the prompt, I get lots of typos from "bounced" keys.

I say make it a command line option or editable in a .conf file. One less program to hunt down.