VOGONS


First post, by mkvreak

User metadata
Rank Newbie
Rank
Newbie

Hello!
I just downloaded the newest DOSBox SVN Daum build and was reported an error message “Set /P is not supported. Use Choice!”
The source code tells me that there is just another if expression that checks for /p in the set command, no comment or explanation. So why is this done?

An explanation why I think this is a bug: I usually put a line “set dircmd=/p/w” in the autoexec section in dosbox.conf, so that “dir” automatically lists directories with /p parameter set (and /w for wide format).
The added query in r3825 does not check if /p is just a string to be added to the variable dircmd instead of /p as a set command parameter, so this breaks the functionality of set command. 🙁

If I’m posting this bug on a wrong place, feel free to correct me. I found a DOSBox bugtracker, but it seems it’s only for the released versions.

Reply 1 of 9, by Dominus

User metadata
Rank DOSBox Moderator
Rank
DOSBox Moderator

I *think* this was added because people tried to use set /p even though real dos didn't support that. Only the Windows command line did that. And to not have to deal with the recurring "why does set /p not work" the devs added the reply that you should use choice.
This is just how I think it is not entirely sure.

Windows 3.1x guide for DOSBox
60 seconds guide to DOSBox
DOSBox SVN snapshot for macOS (10.4-11.x ppc/intel 32/64bit) notarized for gatekeeper

Reply 2 of 9, by Dominus

User metadata
Rank DOSBox Moderator
Rank
DOSBox Moderator

Yep, just googled it. The /p switch was introduced with Windows 2k.
So that's not a bug 😉

Windows 3.1x guide for DOSBox
60 seconds guide to DOSBox
DOSBox SVN snapshot for macOS (10.4-11.x ppc/intel 32/64bit) notarized for gatekeeper

Reply 3 of 9, by Dominus

User metadata
Rank DOSBox Moderator
Rank
DOSBox Moderator

But yeah, you might be right that it checks too much. I should read more thoroughly what others write. Sorry

Windows 3.1x guide for DOSBox
60 seconds guide to DOSBox
DOSBox SVN snapshot for macOS (10.4-11.x ppc/intel 32/64bit) notarized for gatekeeper

Reply 4 of 9, by mkvreak

User metadata
Rank Newbie
Rank
Newbie

Ok, that explains the intention. This is fine with me, I don’t need the /p option. But the implementation is kind of, how do I say it politely … unfortunate. It breaks the main function of set because it’s not transparent. I cannot assign any string to a variable that contains “/p”.

Normally I would comment the two lines and compile, but I want to use SVN Daum version, and I don’t know where the repository is hosted and what prerequisites I need. So this better be fixed in the standard DOSbox SVN repository.

Where do I have to report this bug to get this done?

Reply 5 of 9, by Dominus

User metadata
Rank DOSBox Moderator
Rank
DOSBox Moderator

On the SF bug tracker. (Don't have a linkright now andnot where i can look it up)

Windows 3.1x guide for DOSBox
60 seconds guide to DOSBox
DOSBox SVN snapshot for macOS (10.4-11.x ppc/intel 32/64bit) notarized for gatekeeper

Reply 6 of 9, by Dominus

User metadata
Rank DOSBox Moderator
Rank
DOSBox Moderator

https://sourceforge.net/p/dosbox/bugs/ <- bug tracker

Windows 3.1x guide for DOSBox
60 seconds guide to DOSBox
DOSBox SVN snapshot for macOS (10.4-11.x ppc/intel 32/64bit) notarized for gatekeeper

Reply 9 of 9, by Dominus

User metadata
Rank DOSBox Moderator
Rank
DOSBox Moderator

mkvreak, Qbix just now relaxed the Set /p restrictions in SVN. Good call

Windows 3.1x guide for DOSBox
60 seconds guide to DOSBox
DOSBox SVN snapshot for macOS (10.4-11.x ppc/intel 32/64bit) notarized for gatekeeper